d3b7dffa3c
zcash_client_backend: Restrict use of backend-specific note identifiers.
...
In general, it is preferable to use globally relevant identifiers where
possible. This PR removes the `WalletRead::TxRef` associated type in
favor of using `TxId` directly for the transaction identifier, and
restricts the use of the `NoteRef` type to those scenarios where the
result of one query is intended to be used directly as the input to
another query.
Closes #834
2023-08-07 11:27:38 -06:00
d7bd566b21
Merge pull request #889 from nuttycom/avoid_checkpoint_add_conflict
...
zcash_client_sqlite: Ensure that re-adding the same checkpoint information does not cause a database conflict.
2023-08-07 18:18:53 +01:00
cdb904a28c
Merge pull request #886 from nuttycom/bug/memo_row_absent
...
Fix a number of bugs related to the creation of change memos and storage of empty memos.
2023-08-07 15:49:30 +01:00
522f1e4da0
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2023-08-07 08:07:21 -06:00
027b3c9af8
zcash_client_sqlite: Ensure that re-adding the same checkpoint information does not cause a database conflict.
...
The `add_checkpoint` method is intended to be idempotent. In the case
that we add a checkpoint at an already-checkpointed block height, we
should only raise an error in the case that the note commitment tree
position or the set of notes spent in the checkpointed block has
changed.
2023-08-04 15:12:04 -06:00
0ee45e40c4
zcash_client_sqlite: Replace Either-based definition of `wallet::commitment_tree::Error` with a bespoke error type.
2023-08-04 15:01:15 -06:00
cb0d16cfa9
Fix clippy complaint.
2023-08-04 14:35:58 -06:00
90412ebdc2
Fix SentTransactionOutput documentation.
2023-08-04 14:11:24 -06:00
a5a8562ddd
zcash_client_backend, zcash_client_sqlite: Ensure consistency between sent & stored memos.
2023-08-04 14:05:00 -06:00
f0b2fc3421
zcash_client_sqlite: Store the empty memo as a single 0xf6 byte.
2023-08-02 11:35:27 -06:00
40ecaaf758
zcash_client_backend: Fix error where change memos were not being included in sent transactions.
2023-08-02 11:35:27 -06:00
e718e76989
zcash_client_sqlite: Add a test that demonstrates the expected behavior of `get_memo` for empty-memo situations.
2023-08-02 11:35:27 -06:00
eade2acab9
Merge pull request #887 from nuttycom/fix/time_msrv
...
Pin `time` dependency to avoid forced MSRV bump.
2023-08-02 18:34:24 +01:00
e640f82ff6
Pin `time` dependency to avoid forced MSRV bump.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2023-08-02 10:22:54 -06:00
176ec3e96f
Merge pull request #884 from zcash/update-shardtree-rev
...
Migrate to latest `shardtree` revision
2023-07-27 21:43:28 +01:00
facd4ccac5
Migrate to latest `shardtree` revision
2023-07-25 20:57:49 +00:00
b4f083f4eb
Merge pull request #883 from zcash/put_blocks-parallel-tree-building
...
zcash_client_sqlite: Build subtrees from new commitments in a threadpool
2023-07-25 18:24:41 +01:00
b2bb1b8716
Merge pull request #881 from zcash/zcash_client_backend-cache-ivks
...
zcash_client_backend: Precompute IVKs in `scan_cached_blocks`
2023-07-25 17:00:14 +01:00
20c53fc7cd
Merge pull request #882 from zcash/nullifier-map-index
...
`zcash_client_sqlite`: Add index for foreign key of `nullifier_map` table
2023-07-25 16:59:35 +01:00
99ecdf3a89
zcash_client_sqlite: Build subtrees from new commitments in a threadpool
...
The new `multicore` feature flag can be used to disable this behaviour.
2023-07-25 15:59:03 +00:00
0f6970aefd
zcash_client_sqlite: Cache statement for `wallet::prune_nullifier_map`
2023-07-25 13:46:44 +00:00
e773cd3ed4
zcash_client_sqlite: Add index for foreign key of `nullifier_map` table
...
This greatly improves the performance of `wallet::prune_nullifier_map`
by speeding up `ON DELETE CASCADE`.
2023-07-25 13:45:52 +00:00
2d3d5e8fe6
zcash_client_backend: Precompute IVKs in `scan_cached_blocks`
2023-07-25 02:21:15 +00:00
b33330f9ca
zcash_client_backend: Accept owned keys in `scan_block_with_runner`
...
This internal helper function can now take owned or borrowed keys. The
public `scan_block` function is left unaltered.
2023-07-25 02:14:18 +00:00
46ca3202e4
Merge pull request #879 from zcash/877-shardtree-migration-perf
...
zcash_client_sqlite: Only import recent frontiers into `ShardTree`
2023-07-24 00:09:35 +01:00
ed06a37b09
zcash_client_sqlite: Mark existing blocks scanned in `shardtree` migration
...
The `shardtree` migration is applied to a database state that was
created via linear scanning, so we have complete wallet information for
those blocks.
2023-07-21 21:01:03 +00:00
97a3f818ec
zcash_client_sqlite: Only import recent frontiers into `ShardTree`
...
We only need to load frontiers into the ShardTree that are close enough
to the wallet's known chain tip to fill `PRUNING_DEPTH` checkpoints, so
that ShardTree's witness generation will be able to correctly handle
anchor depths. Loading frontiers further back than this doesn't add any
useful nodes to the ShardTree (as we don't support rollbacks beyond
`PRUNING_DEPTH`, and we won't be finding notes in earlier blocks), and
hurts performance (as frontier importing has a significant Merkle tree
hashing cost).
Closes zcash/librustzcash#877 .
2023-07-21 20:59:24 +00:00
2ed0747b67
Merge pull request #878 from zcash/876-nullifier-map
...
zcash_client_sqlite: Maintain a nullifier map from out-of-order scanning
2023-07-21 21:57:12 +01:00
0f2689b9c3
zcash_client_sqlite: Maintain a nullifier map from out-of-order scanning
...
Closes zcash/librustzcash#876 .
2023-07-21 18:01:52 +00:00
4d2abd5c3a
zcash_client_sqlite: Add test showing out-of-order balance problem
2023-07-21 17:53:14 +00:00
fab68d217e
zcash_client_sqlite: Fix `WalletDb::block_fully_scanned` implementation
2023-07-21 15:25:39 +00:00
8e582109ca
Merge pull request #875 from zcash/blockmeta-upsert
...
Use an upsert for `FsBlockDb::write_block_metadata`
2023-07-19 19:00:29 +01:00
963496d0ab
Use an upsert for `FsBlockDb::write_block_metadata`
2023-07-19 16:41:01 +00:00
f4221889fe
Merge pull request #872 from nuttycom/feature/pre_dag_sync-suggest_scan_ranges
...
Implement `suggest_scan_ranges` and updated chain validation.
2023-07-19 17:37:43 +01:00
c7b308b312
Rename `VALIDATION_DEPTH` constant to `VERIFY_LOOKAHEAD`
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-07-19 16:03:02 +00:00
e16aa41117
Add test for join_nonoverlapping.
2023-07-19 14:54:01 +00:00
359ff55ce3
Do nothing if `update_chain_tip` is given a tip lower than we can use
...
Previously it would panic due to constructing invalid `ScanRange`s.
2023-07-19 14:54:01 +00:00
98ea08e497
Migrate to latest `shardtree` to improve performance
2023-07-19 14:54:01 +00:00
a87dca00e2
Documentation updates, fixes, and cleanups
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-07-19 14:54:01 +00:00
2a98f94f05
Add more debug and trace logging
...
The `Debug` impl for `sapling::Node` is updated to output hex-encoded
bytes for readability.
2023-07-18 17:23:57 +00:00
510944777c
Transactionally modify the wallet DB in `replace_queue_entries`
...
We don't want to delete old scan range queue entries unless we are
guaranteed to write the updated queue entries.
2023-07-18 17:23:57 +00:00
281dbd5524
Ensure that `extended_range` in `scan_complete` is a superset of `range`
...
Previously `extended_range` only covered the extent of the leaves of
all subtrees in which notes were found during a scan. When the scanned
range was large, this was not guaranteed to be contained within the
subtree leaves, causing an assertion failure when an invalid `ScanRange`
was constructed.
2023-07-18 17:23:57 +00:00
cb887efa06
Use correct levels for cap nodes in `put_shard_roots`
...
The Merkle hashes used for the note commitment trees are domain
separated by level, so when pretending that the subtree roots are leaves
of the cap tree, we need to adjust for their level not being zero.
Closes zcash/librustzcash#874 .
Co-authored-by: Sean Bowe <ewillbefull@gmail.com>
2023-07-18 17:23:57 +00:00
f7163e9dd9
Code simplifications
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-07-18 17:23:55 +00:00
bb920341a6
Fix bug in `RightFirstDisjoint` insertion logic
2023-07-18 17:22:48 +00:00
2c0acac1bd
Use explicit arguments for internal `suggest_scan_ranges` helper
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-07-18 17:22:48 +00:00
ed4b6dc9b9
Fix bugs in `ScanRange::truncate_*`
2023-07-18 17:22:48 +00:00
e3aeb63e0a
Fix off-by-one bugs with `ScanRange` end bounds
...
Maximum chain heights are end-inclusive, while `ScanRange` is
end-exclusive.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-07-12 16:27:52 +00:00
352e1c709a
Add a test for `scan_complete` and `update_chain_tip`
2023-07-07 20:13:45 -06:00
6db4355fc4
Fix an error in dominance calculation.
2023-07-07 20:13:45 -06:00
Kris Nuttycombe
str4d
str4d
Sean Bowe