309d83af57
Retrieve nullifiers for all unconfirmed notes.
...
Previously we were retrieving nullifiers for notes that were not
marked spent, but not checking against whether the spending
transaction had been included in a block.
2021-03-24 16:18:54 -06:00
cb6a993840
zcash_client_backend: Use correct output index for t-addr recipients
...
`create_spend_to_address` was originally written only for sending to
Sapling addresses. It was later amended to support sending to
transparent addresses, but the assumption about there being a Sapling
output was not removed. This was not an issue for most transactions
because there would be change, but in the case of a z->t transaction
with no change, `create_spend_to_address` would reliably panic.
This commit fixes the bug by setting the output index for transparent
recipients to 0. The `output_index` field of `SentTransaction` is also
documented to correctly reflect its dependency on the type of
`recipient_address`.
2021-03-24 19:01:35 +13:00
7c8b29e693
zcash_client_sqlite: Add test that exposes the no-change bug
2021-03-24 18:46:55 +13:00
334442c505
Address comments from review.
2021-03-17 09:21:10 -06:00
8a84203685
Remove Default impl from MemoBytes
...
Memo fields have two ways to encode an empty memo:
- 0xF6 followed by all-zeroes, encoding "there is no memo".
- All-zeroes, encoding the empty UTF-8 string.
In almost all cases you want the former, but users thinking about byte
slices may expect MemoBytes::default() to result in the latter. To
ensure clarity, we now require calling either MemoBytes::default() or
MemoBytes::from_bytes(&[]) to be explicit.
No such confusion exists for the Memo enum, because the two types are
visibly separated as different enum cases, and Memo::Empty makes sense
as the default.
2021-03-17 21:16:01 +13:00
c7a3ef0e88
Split memo-handling into MemoBytes struct and Memo enum
...
The MemoBytes struct is a minimal wrapper around the memo bytes, and only
imposes the existence of null-padding for shorter memos. The only error
case is attempting to construct a memo that is too long. MemoBytes is
guaranteed to be round-trip encodable (modulo null padding).
The Memo enum implements the additional memo rules defined in ZIP 302,
interpreting the contents of a memo (for example, parsing it as text).
2021-03-17 21:05:50 +13:00
48f7ef84a4
Move Memo into zcash_primitives::memo
2021-03-17 19:58:40 +13:00
5a9b29a75a
Address comments from code review.
2021-03-11 13:01:22 -07:00
0e022f2283
Allow block scanning using either IVKs or FVKs.
2021-03-09 21:00:40 -07:00
16289750e8
Remove WalletWrite::transactionally
2021-03-09 20:59:57 -07:00
a74cc8b231
Remove sqlite-specific data organization from data access api.
2021-03-09 20:59:57 -07:00
b5bbbb6f5a
Factor out nullifier update from database actions in scan_cached_blocks
2021-03-09 20:59:57 -07:00
463e252af4
Fix more intra-doc links
2021-03-04 23:01:42 +00:00
98530184c0
Fix clippy complaints.
2021-02-03 14:27:31 -07:00
df09877b11
Use an enum to distinguish between sent and received notes in sqlite backend.
2021-01-20 10:51:27 -07:00
7f43b05e21
Update protobuf dependency version.
2021-01-19 13:01:51 -07:00
779a5670e0
Improve data access api method documentation.
2021-01-19 12:45:55 -07:00
8fe6f0fdfd
Remove default get_balance method.
...
Recommended by @str4d
2021-01-19 08:25:10 -07:00
8e8ed2bb4f
Rename get_verified_balance -> get_balance_at
2021-01-15 12:00:14 -07:00
c70a9ed81f
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <thestr4d@gmail.com>
2021-01-15 11:57:58 -07:00
f59124ce19
Pass account ID with IVK.
2021-01-15 10:18:43 -07:00
8a7d051138
Rustfmt
2021-01-13 18:06:42 -07:00
a3f9fa788d
Update data_api doctests for error handling changes.
2021-01-13 15:43:39 -07:00
5a21580f13
Correct the hierarchy of errors.
2021-01-13 15:20:11 -07:00
6c6b05fa9b
Trivial rename.
2021-01-12 21:32:46 -07:00
ce06db197a
Rustfmt.
2021-01-12 21:10:34 -07:00
eef2d5944b
Use a slice literal instead of a vec in put_received_note
2021-01-12 21:06:57 -07:00
fcb2f7a433
Use collect instead of collecting a vec manually.
2021-01-12 21:04:42 -07:00
011eda364f
Add get_spendable_notes method to WalletRead
2021-01-12 20:42:04 -07:00
48f226f8b5
Move decoding errors to sqlite crate.
...
Also move dependency on params out of wallet read/write methods.
The result is cleaner because these parameters are only required
for backend-specific encoding and decoding operations.
2021-01-12 20:07:02 -07:00
ca4567b275
More data api documentation.
2021-01-12 13:55:22 -07:00
34bc655f64
Add MockBlockSource and MockWalletDB
...
These can readily be made into an in-memory wallet implementation.
2021-01-12 12:55:24 -07:00
7d92150965
Fix test compilation with WalletWrite changes.
2021-01-11 18:13:40 -07:00
aad2e174c1
Consistently use nullifier and AccountId newtypes.
2021-01-08 21:49:38 -07:00
56adbbb545
Make `WalletWrite` depend upon `WalletRead`.
2021-01-08 12:49:10 -07:00
e96578195a
Not sure how this happened.
2020-12-03 10:10:37 -07:00
4e608216c1
Do not create nested transaction in rewind_to_height
...
Fixes #321
2020-12-02 14:36:56 -07:00
d77784eba8
Do not update `is_change` in received_notes with null values.
...
Fixes #322
2020-12-02 13:16:02 -07:00
7ac08631b9
Fix doctest imports.
2020-12-02 09:46:17 -07:00
cf2dae8af0
Add hrp_sapling_extended_spending_key to Parameters trait.
2020-12-02 09:46:17 -07:00
1fd74d0a71
Improve naming for wallet/block database connections.
2020-12-02 09:46:17 -07:00
897a70dd9e
Simplify block source & clean up chain validation.
2020-12-02 09:46:17 -07:00
8a215d67fe
Improve wallet "database" trait names.
2020-12-02 09:46:17 -07:00
b2cc240454
Do not require wallet database for chain scan.
2020-12-02 09:46:17 -07:00
e6de7c07f0
Use <module_name>.rs instead of <module_name>/mod.rs
2020-12-02 09:46:17 -07:00
f742895118
Fix test/doctest errors.
2020-12-02 09:46:17 -07:00
2e2f34b033
Use named_params macro for query_and_then_named (less error-prone)
2020-12-02 09:46:17 -07:00
25b5fc965f
Fix broken empty_database_has_no_balance test
2020-12-02 09:46:17 -07:00
c60b9d3ece
Remove database initialization calls from common API.
2020-12-02 09:46:17 -07:00
903ef58ec6
Fix transactionality in rewind_to_height
2020-12-02 09:46:17 -07:00
4c2cda48e6
Clean up transactional API.
...
This API is still somewhat unsafe in that it doesn't inhibit nested
transactions, but it's better than it was.
2020-12-02 09:46:17 -07:00
cd2729bbd0
Move 'create_spend_to_address' to wallet backend.
...
This required changing a bit about the relationship between
database errors and wallet errors, and opens up the possibility
of now simplifying the error situation a bit.
2020-12-02 09:46:17 -07:00
e144015558
Reuse sent note insertion for wallet/transact.
2020-12-02 09:46:17 -07:00
68737dd1dd
Remove duplicate method.
2020-12-02 09:46:17 -07:00
8de05f3429
Move transact.rs to wallet module.
2020-12-02 09:46:17 -07:00
8967745c22
Push chain & wallet functionality down to child modules.
2020-12-02 09:46:17 -07:00
22ef05239c
Split init module into chain and wallet-related parts.
2020-12-02 09:46:17 -07:00
a181203179
Move related functions into the same modules.
2020-12-02 09:46:17 -07:00
eab2951c99
Move decrypt_and_store_transaction to zcash_client_backend
2020-12-02 09:46:17 -07:00
0165ae7003
Minor renamings.
2020-12-02 09:46:17 -07:00
746c4c9a00
Move scan_cached_blocks out of sqlite crate.
2020-12-02 09:46:17 -07:00
d16c124ffe
Abstract over data access in scan_cached_blocks.
2020-12-02 09:46:17 -07:00
06c1772692
Move traversal of cached blocks to CacheOps
2020-12-02 09:46:17 -07:00
604294dd9f
Factor out nullifier retrieval into data api.
2020-12-02 09:46:17 -07:00
ffd503134d
Factor out witness retrieval from scan.
2020-12-02 09:46:17 -07:00
499dcd2e6c
Add the remainder of sqlite/query.rs functions to the data API.
2020-12-02 09:46:17 -07:00
56e6091876
Factor out `get_commitment_tree` from scan.
2020-12-02 09:46:17 -07:00
d16c74725e
Extract get_extended_full_viewing_keys function.
...
This required a bit of generalization of the data_api error types.
2020-12-02 09:46:17 -07:00
3eec6f8faa
Add get_balance, get_verified_balance to data api.
2020-12-02 09:46:17 -07:00
70de11dd32
Add address retrieval.
2020-12-02 09:46:17 -07:00
b72251ee28
Add accounts table initialization.
2020-12-02 09:46:17 -07:00
724fbac33a
Add database initialization implementation.
2020-12-02 09:46:17 -07:00
f3f3512068
Move get_target_and_anchor_heights to data_api.
2020-12-02 09:46:17 -07:00
9874abfd6c
Implement chain validation & fix doctests.
2020-12-02 09:46:17 -07:00
936b399599
Fix remaining tests after default fee change
2020-11-24 01:50:47 +00:00
7176ff077c
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-10-24 12:05:15 +01:00
450d68f073
Merge branch 'master' into zcash_client_sqlite-0.2.1
2020-10-24 00:44:37 +01:00
524cc2e979
zcash_client_sqlite: Read rcm correctly from data DB after Canopy
...
ZIP 212 alters the note plaintext to store a seed from which rcm is
derived, rather than storing rcm directly. In the mobile SDKs we only
need rcm, so for post-ZIP 212 notes, we derive rcm from the seed and
store rcm in the data DB.
However, when selecting notes to spend, `create_to_address` was using the
transaction's target height to determine if Canopy is active, and parsing
the rcm value as the seed if so. This effectively applied a seed->rcm
derivation to all selected notes' rcms once Canopy activated on the
chain. As a result, the note commitments were incorrect, and thus the
anchors derived from the witness paths were also incorrect. This caused
two kinds of observed failures:
- If more than one note was selected, the builder would fail with
"anchor mismatch", as the note commitments would be effectively
randomised, causing the derived anchors to also randomise.
- If a single note was selected, the transaction would be built using
the randomised anchor, and then rejected when sent to the network.
The fix is to "pretend" in `create_to_address` that all notes are
pre-ZIP 212 notes. This works fine because we never need to serialize
back to the note plaintext while spending a note.
2020-10-24 00:23:05 +01:00
b1c3f9d3f0
ZIP 321 Reference Implementation ( #294 )
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2020-10-15 14:03:40 +01:00
e0587e752b
Merge pull request #290 from str4d/273-remove-decryption-epk-subgroup-check
...
Take epk as a jubjub::ExtendedPoint for note decryption
2020-09-22 03:05:35 +12:00
cfb6850d7c
Rustfmt
2020-09-18 10:52:58 -06:00
80e1d35ea6
Apply additional suggestions from code review.
2020-09-18 10:40:30 -06:00
90d8980162
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-18 10:39:37 -06:00
1ad9294933
Remove static determination of network state.
...
In the interest of making the library usable for both
testnet and mainnet without recompilation, static resolution
of network parameters has been replaced with a parameter passed
to the relevant functions. This also moves addres prefix constants
into the network parameters.
2020-09-17 10:34:42 -06:00
efaba87681
Add newtype for block height.
2020-09-17 10:26:41 -06:00
192db29a25
Take epk as a jubjub::ExtendedPoint for note decryption
...
We don't need to check if epk is in the prime-order subgroup before we
trial-decrypt, which saves a third of the cost of trial-decrypting
outputs that are not ours.
2020-09-10 00:39:21 +01:00
c7e9523dce
Merge pull request #284 from str4d/259-ovk-none
...
zcash_primitives: Support ovk = ⊥ in note encryption
2020-09-09 14:32:57 -06:00
d4f87c12ed
rusqlite 0.24
2020-09-09 00:53:42 +01:00
40e135783c
zcash_primitives: Support ovk = ⊥ in note encryption
...
Closes zcash/librustzcash#259 .
2020-08-28 21:17:16 +01:00
d15acf8acc
zcash_primitives: Rename Note::cm to Note::cmu
2020-08-21 18:35:04 +01:00
fdf06032e3
s/{pairing::bls12_381, zcash_primitives::jubjub}/{bls12_381, jubjub}
...
FINALLY.
2020-08-19 23:08:19 +01:00
c3d89644e2
Revert SaplingNoteEncryption::new() API to take rng instead of esk
2020-08-06 12:47:35 +08:00
9970a8aefd
Hard-code NetworkUpgrade::Canopy in generate_random_rseed
2020-08-06 12:27:20 +08:00
b05e257f79
Fix database queries in scan.rs and transact.rs
2020-08-06 12:00:49 +08:00
44f46e50ce
Add <P: consensus::Parameters> type parameter to Builder struct
2020-08-06 11:43:07 +08:00
d6deaddc0a
Only query last_height when needed in decrypt_and_store_transaction()
2020-08-05 16:09:41 +08:00
2ed9b6f881
Refactor contextual random rseed generation into util method in zcash_primitives
2020-08-05 15:21:42 +08:00
d5f80618ef
Switch plaintext version on height in commit_to_address() in zcash_client_sqlite
2020-08-05 14:26:57 +08:00
a25348dfba
Revert passing Parameters to methods
2020-08-05 12:47:29 +08:00
74b2f0a79e
Pass height to decrypt_transaction()
2020-08-04 21:05:29 +08:00
895e251793
Fix tests
2020-07-31 22:40:48 +08:00
65504d9ca7
Add enum Rseed<E::Fs> to Note struct
2020-07-31 22:28:40 +08:00
b537f0f712
Pass height to methods which encrypt or decrypt Sapling outputs
2020-07-31 12:39:39 +08:00
8c250ca3de
zcash_sqlite: Add an unreliability warning to query::get_balance docs
2020-07-10 09:50:43 +12:00
8188fae779
zcash_client_sqlite: Implement outgoing viewing key policies
...
This enables an SQLite light client to specify whether recipient history
can be recovered from the block chain (and by what outgoing viewing key)
with per-transaction granularity.
2020-07-09 23:48:09 +12:00
131e00e25d
zcash_client_sqlite::scan::decrypt_and_store_transaction
2020-06-25 18:54:41 +12:00
3036064cd0
zcash_client_sqlite: Update received note during scan if present
...
Fixes a bug where rewinding a block that contained a received note would
cause a constraint violation.
2020-06-25 18:54:41 +12:00
9363ec36d9
Added a limit value for scanning.
...
This provides a way to expose a more fine grained measure of scan progress. For example, by scanning in batches of 100 blocks, rather than everything that is pending.
2020-06-25 18:54:41 +12:00
c8074d42b8
zcash_client_sqlite: Store is_change as INTEGER instead of BOOLEAN
...
Needed because SQLite internally stores BOOLEAN as INTEGER anyway, but
this causes problems with newer versions of Room on Android.
2020-06-25 18:54:41 +12:00
4cfdacedec
zcash_client_sqlite: Support sending to t-addrs
2020-06-25 18:54:41 +12:00
380c2f726f
Chain validity and reorg handling
2020-06-25 18:54:41 +12:00
f0ce0c5530
Add mainnet support to zcash_client_sqlite via a feature flag
2020-06-25 18:54:41 +12:00
02324fb767
zcash_client_sqlite::query::get_*_memo_as_utf8()
2020-06-25 18:54:41 +12:00
34725df086
zcash_client_sqlite::transact::create_to_address()
2020-06-25 18:54:41 +12:00
3ef03f2f1d
zcash_client_sqlite::scan::scan_cached_blocks()
2020-06-25 18:54:41 +12:00
72dd76e4db
zcash_client_sqlite::query::{get_balance, get_verified_balance}
2020-06-25 18:54:41 +12:00
c8b70e569c
zcash_client_sqlite::query::get_address()
2020-06-25 18:54:41 +12:00
c0cf55c127
SQLite database structure and initialisation
2020-06-25 18:54:34 +12:00
Kris Nuttycombe
Jack Grigg
Jack Grigg
Kris Nuttycombe
str4d
ebfull
therealyingtong
Kevin Gorham