56b577b31e
clippy: Fix small lints
2021-03-27 19:01:03 +13:00
564c2714fe
clippy: Use Iterator::try_for_each
2021-03-27 19:01:03 +13:00
636845d0f9
Renames to use lower-case abbreviations (matching Rust convention)
...
As of our MSRV bump to 1.51.0, we get lints for this.
2021-03-27 19:01:03 +13:00
eefc516e26
zcash_primitives: Update changelog for Sapling refactor
2021-03-27 17:10:18 +13:00
8ac663f116
Fix some doctests and intra-doc links after moving Sapling primitives
2021-03-27 17:10:18 +13:00
33effb7d67
Move sapling keys into sapling module.
2021-03-27 16:18:21 +13:00
4086df772c
Move sapling-specific primitives into the sapling module.
2021-03-27 16:18:21 +13:00
abbf5dfd83
Move pedersen hash test vectors into Sapling
2021-03-27 16:18:21 +13:00
bc087a5ff7
Move pedersen hashes to sapling module.
2021-03-27 16:18:21 +13:00
88d58aac0a
Move relevant utils into sapling module.
2021-03-27 16:18:21 +13:00
16948d9d78
Move zcash_primitives::prover to sapling module
2021-03-27 16:18:21 +13:00
bf97b21632
Move redjubjub to sapling module.
2021-03-27 16:18:21 +13:00
de1345a1c2
Move group_hash to sapling module.
2021-03-27 16:18:21 +13:00
c839193b20
Move TZE components to a separate module & add TzeOutPoint
2021-03-27 15:52:20 +13:00
97f2502a5e
Factor transparent transaction components into a separate module.
2021-03-27 15:49:17 +13:00
96709c6423
Move Sapling transaction components to a separate module.
2021-03-27 15:49:17 +13:00
7fcb7bbe99
Factor Sprout transaction elements into a separate module.
2021-03-27 15:49:17 +13:00
6e371a8c13
Make Sprout elements crate-public.
2021-03-27 15:49:17 +13:00
9d9c0579f8
Use new name for broken_intra_doc_links lint
...
We also add the lint to crates in the workspace that didn't have it.
Closes zcash/librustzcash#279 .
2021-03-27 08:27:17 +13:00
afa0b29e62
Bump MSRV to 1.51.0
...
This is the MSRV for the orchard crate, which we will be depending on
soon.
2021-03-27 08:21:45 +13:00
725699c76b
zcash_primitives 0.5.0
2021-03-26 18:51:35 +13:00
675048e52b
Fix broken intra-doc links and lints
2021-03-26 10:07:20 +13:00
55e73d7910
Fix clippy lints
2021-03-26 10:07:20 +13:00
c41c71c514
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2021-03-25 15:00:54 -06:00
ebdd6cf976
Add SaplingIvk newtype to changelogs.
2021-03-24 18:39:21 -06:00
e122c3d974
Remove reference to ZIP 302 structured memos from changelog
...
We're removing those from the ZIP draft until they can be agreed upon.
2021-03-23 13:52:22 +13:00
46872e2590
Update changelogs with Memo changes
2021-03-18 10:00:27 +13:00
8a84203685
Remove Default impl from MemoBytes
...
Memo fields have two ways to encode an empty memo:
- 0xF6 followed by all-zeroes, encoding "there is no memo".
- All-zeroes, encoding the empty UTF-8 string.
In almost all cases you want the former, but users thinking about byte
slices may expect MemoBytes::default() to result in the latter. To
ensure clarity, we now require calling either MemoBytes::default() or
MemoBytes::from_bytes(&[]) to be explicit.
No such confusion exists for the Memo enum, because the two types are
visibly separated as different enum cases, and Memo::Empty makes sense
as the default.
2021-03-17 21:16:01 +13:00
c7a3ef0e88
Split memo-handling into MemoBytes struct and Memo enum
...
The MemoBytes struct is a minimal wrapper around the memo bytes, and only
imposes the existence of null-padding for shorter memos. The only error
case is attempting to construct a memo that is too long. MemoBytes is
guaranteed to be round-trip encodable (modulo null padding).
The Memo enum implements the additional memo rules defined in ZIP 302,
interpreting the contents of a memo (for example, parsing it as text).
2021-03-17 21:05:50 +13:00
48f7ef84a4
Move Memo into zcash_primitives::memo
2021-03-17 19:58:40 +13:00
b5bbbb6f5a
Factor out nullifier update from database actions in scan_cached_blocks
2021-03-09 20:59:57 -07:00
463e252af4
Fix more intra-doc links
2021-03-04 23:01:42 +00:00
d221b230c6
Fix intra-doc links
2021-03-04 17:41:08 +00:00
464b533937
Bump MSRV to 1.47.0
...
We'll be needing it shortly for ff et al.
2021-03-04 17:32:57 +00:00
8b64c18b0d
aes 0.6
2021-03-04 17:04:26 +00:00
9463e41cab
hex-literal 0.3
2021-03-04 17:01:59 +00:00
b960cdfd92
secp256k1 0.20
2021-03-04 17:01:59 +00:00
36e4b0d51a
Merge pull request #329 from nuttycom/ivk_payment_addresses
...
Introduce SaplingIvk newtype & use IVKs where possible.
2021-03-04 07:04:05 +13:00
47f3b5f045
Merge pull request #343 from str4d/changelogs-add-unreleased
...
Add details of unreleased changes to changelogs
2021-02-23 08:57:52 +13:00
d999463d26
Add temporary workaround for funty breakage
2021-02-22 19:15:37 +00:00
1f6f45bbe7
Add details of unreleased changes to changelogs
2021-02-22 16:59:07 +00:00
9f14c757e6
Merge pull request #340 from str4d/changelogs
...
Add changelogs to the crates
2021-02-14 02:34:20 +13:00
b37b5876f2
Merge pull request #318 from nuttycom/tx_version_enum
...
Add TxVersion enum to make interacting with transaction version values safer.
2021-02-04 12:47:12 -07:00
974669a50b
Fix clippy lints.
2021-02-04 11:41:29 -07:00
796161e9b4
Add suggested comment clarifying future additions to the TxVersion enum
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-02-04 11:22:13 -07:00
bd3e18984c
Changelogs: s/project/library
2021-02-04 15:16:32 +00:00
b5c7d7f1e7
Add changelogs to the crates
...
The changelogs are accurate for the 0.4.0 release tag, but don't yet
include changes before or after that tag.
2021-02-04 15:13:22 +00:00
1cc7949518
Rename CommitmentTree::new -> CommitmentTree::empty
2021-02-04 07:49:48 -07:00
3423b03c6d
Fix a couple more lints.
2021-02-04 07:31:00 -07:00
98530184c0
Fix clippy complaints.
2021-02-03 14:27:31 -07:00
7a57aee530
Introduce SaplingIvk newtype & use IVKs where possible.
...
This includes making it possible to obtain a payment address from just the IVK + diversifier.
2021-02-02 15:27:13 -07:00
45f3f5a945
Simplify a few pattern matches
...
A few pattern-matches correspond directly to standard combinators on
`Result`, `Option`. This uses them for concision / clarity.
Refactorings reviewed by the author after suggestion from [comby-rust](https://github.com/huitseeker/comby-rust ).
2021-02-01 13:37:54 -05:00
937fa06136
Fix randomized tests of zfuture transaction roundtrip.
2021-01-25 16:32:57 -07:00
6373e7d053
Raise an error in the case that sprout version < 1.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-01-25 16:32:57 -07:00
1dd5a6dbcb
Check all transaction versions in has_sprout and uses_groth_proof checks.
2021-01-25 16:32:57 -07:00
06cd91059f
Enable transaction serialization roundtrip tests outsize zfuture.
2021-01-25 16:32:57 -07:00
da4cf23668
Add TxVersion enum to make interacting with transaction version values safer.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2021-01-25 16:32:57 -07:00
6315f7dc28
Use wNAF multiplication for Sapling key agreement.
2021-01-22 15:16:06 -07:00
8e8ed2bb4f
Rename get_verified_balance -> get_balance_at
2021-01-15 12:00:14 -07:00
c70a9ed81f
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <thestr4d@gmail.com>
2021-01-15 11:57:58 -07:00
ce06db197a
Rustfmt.
2021-01-12 21:10:34 -07:00
db9eb29eba
Merge remote-tracking branch 'upstream/master' into data_access_api
2021-01-12 21:09:40 -07:00
7acc75249b
Fix documentation of human-readable prefixes.
2021-01-12 20:45:28 -07:00
7d92150965
Fix test compilation with WalletWrite changes.
2021-01-11 18:13:40 -07:00
aad2e174c1
Consistently use nullifier and AccountId newtypes.
2021-01-08 21:49:38 -07:00
27d7b6c569
A few doc updates.
2021-01-08 18:08:02 -07:00
472dac7a22
Revert intra_doc_link_resolution_failure flag change.
2020-12-17 07:36:18 -07:00
cf0c3ea90f
Relax RngCore type constraints.
...
The intent of this change is to permit tests to use deterministic
random sources, rather than cryptographically strong ones.
2020-12-14 13:44:05 -07:00
c24f663e40
Use methods on sigversion to gate ZIP-243 and TZE signature parts.
2020-12-14 14:54:29 +00:00
790071953c
Use rust feature flagging to allow conditionally enabling TZE-related code.
...
This also uses the test-dependencies feature flag for conditional
inclusion of proptest-related modules which may be used by
dependent crates for generation of samples in testing.
2020-12-14 14:54:12 +00:00
62675f4b4f
Use the SHA-256d HashReader and HashWriter for transaction hashing.
...
This hashes the transaction as it is read, rather than hashing a re-serialization.
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-12-03 21:22:58 +00:00
1f18da239f
Add HashReader and HashWriter for SHA-256d.
...
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-12-03 21:22:58 +00:00
cf2dae8af0
Add hrp_sapling_extended_spending_key to Parameters trait.
2020-12-02 09:46:17 -07:00
ee0e059eb3
Add coin_type to consensus parameters.
2020-12-02 09:46:17 -07:00
a437df191e
Initial skeleton of low-level database access API.
2020-12-02 09:46:17 -07:00
1285ab0af2
Fix tests to account for modified default fees.
2020-11-24 01:24:19 +00:00
53ebc378cc
ZIP-313 change default fee amount.
2020-11-24 01:22:14 +00:00
f40174464a
Use slices as parameters rather than &Vec references.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-11-19 14:49:24 -07:00
726f02513d
Make the functions which produce the components of the sighash reusable.
...
When implementing transaction nonmalleability, it will be useful
to have this already done.
2020-11-19 11:25:24 -07:00
be8bae71be
Suppress clippy lints where we want the given behaviour
2020-10-30 14:10:35 +00:00
91796adcda
Remove wrapping closures around mapping functions
2020-10-30 14:10:35 +00:00
025deda712
impl Default for T on types with T::new()
2020-10-30 14:10:35 +00:00
44cbc6cc6d
Remove unnecessary references
2020-10-30 14:10:35 +00:00
88474c71c7
Simplify expressions
2020-10-30 13:51:40 +00:00
0cb51f963c
Remove unnecessary clones
2020-10-30 13:51:40 +00:00
bc9ca20d56
Make use of assignment operators
2020-10-30 13:26:36 +00:00
890648df4d
Use !x.is_empty() instead of x.len() > 0
2020-10-30 13:25:08 +00:00
0bbcd8c408
Remove unnecessary imports
2020-10-30 13:22:46 +00:00
70ecd6b2d8
Export notesize constants
2020-10-26 11:31:22 -07:00
d657ff906e
zcash_primitives: Small simplification to Script::address
2020-10-18 13:17:16 +01:00
b1c3f9d3f0
ZIP 321 Reference Implementation ( #294 )
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2020-10-15 14:03:40 +01:00
eeb0c2b08a
Update comment in zcash_primitives/src/transaction/builder.rs
2020-10-13 14:28:54 -06:00
536c77bea7
Fix formatting.
2020-10-13 07:12:33 -06:00
cc121ede8e
Document `TzeIn` serialization.
2020-10-09 16:37:00 -06:00
39ab6e5b95
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-10-09 16:19:44 -06:00
26aa23988c
Replace domain separator with a 1-byte tag.
2020-09-30 10:22:51 -06:00
03b4e56a44
Formatting fix.
2020-09-23 17:14:35 -06:00
b6cd096c10
Generate plausible scripts for transaction proptests.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-23 14:48:10 -06:00
9963fb9e57
Use CompactSize & Vector::write for tze sighash construction.
2020-09-23 14:37:48 -06:00
995d063992
Documentation fixes from code review.
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-23 14:16:29 -06:00
6a536aa88a
Use more informative type names in Extension trait.
2020-09-23 13:35:14 -06:00
36c28341b3
Additional future -> zfuture renaming.
2020-09-23 13:11:47 -06:00
99eb5b9336
Rename `Future -> ZFuture`
...
Proactively distinguish against future use of the
futures crate for source greppability.
2020-09-22 10:17:58 -06:00
a0a36eddfd
Merge remote-tracking branch 'upstream/master' into zip-tzes
...
Fix benchmark build issues.
2020-09-21 16:43:33 -06:00
ab2d5bf603
Merge remote-tracking branch 'upstream/master' into zip-tzes
2020-09-21 10:08:05 -06:00
e0587e752b
Merge pull request #290 from str4d/273-remove-decryption-epk-subgroup-check
...
Take epk as a jubjub::ExtendedPoint for note decryption
2020-09-22 03:05:35 +12:00
924ee09bc4
Add documentation to primary `Extension` trait
2020-09-18 11:21:44 -06:00
cfb6850d7c
Rustfmt
2020-09-18 10:52:58 -06:00
80e1d35ea6
Apply additional suggestions from code review.
2020-09-18 10:40:30 -06:00
90d8980162
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-18 10:39:37 -06:00
d232133216
Add constants to support static resolution of network parameters.
2020-09-17 12:58:23 -06:00
1ad9294933
Remove static determination of network state.
...
In the interest of making the library usable for both
testnet and mainnet without recompilation, static resolution
of network parameters has been replaced with a parameter passed
to the relevant functions. This also moves addres prefix constants
into the network parameters.
2020-09-17 10:34:42 -06:00
efaba87681
Add newtype for block height.
2020-09-17 10:26:41 -06:00
c35c501734
Add comment on FUTURE_TX_VERSION/GROUP_ID`
2020-09-10 14:52:47 -06:00
208208238d
Add property test for round-trip serialization of TZE-bearing transactions.
2020-09-10 14:52:47 -06:00
a5d5f87b48
Bind TZE inputs and outputs in signature.
2020-09-10 14:52:47 -06:00
eb4a2d5032
Add domain separator to transparent signatures.
...
Once TZEs are active, we would like to ensure that collisions
between TZE input signatures and transparent input signatures
cannot occur, so we add a domain separator to both.
This also ensures that if TZE inputs are presented for signature
without using the `Future` sighash version, that the signing
code will report an error.
2020-09-10 14:52:47 -06:00
5a432b5e2b
Ensure that prevout, extension_id & mode data can be signed in builder.
2020-09-10 14:52:47 -06:00
1a8168e1c9
Document transaction builder methods.
2020-09-10 14:52:47 -06:00
671caa8b84
Remove unused Epoch trait.
2020-09-10 14:52:47 -06:00
23634d4cd0
Document ExtensionTxBuilder methods
2020-09-10 14:52:47 -06:00
9d2f388b3b
Apply idiomatic rustlang suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-10 14:52:47 -06:00
9ef15b536c
Update method documentation in zcash_primitives/src/extensions/transparent.rs
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-10 14:52:47 -06:00
b15e49ef47
Documentation update to zcash_primitives/src/extensions/transparent.rs
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-09-10 14:52:47 -06:00
af931d524a
Demo TZE fixes in response to PR comments.
2020-09-10 14:52:47 -06:00
aed2759e1e
Use NetworkUpgrade for TZE epoch determination.
...
This adds a `Future` variant for both BranchId and NetworkUpgrade.
2020-09-10 14:52:47 -06:00
81b6f8afd7
Formatter fix.
2020-09-10 14:52:47 -06:00
4bf6309c54
Update to non-yanked version of subtle crate.
2020-09-10 14:52:47 -06:00
8299f336d3
Add test for tze txn parsing.
2020-09-10 11:58:40 -06:00
dc9b007e8e
Add signature hash over TZE data.
2020-09-10 11:58:40 -06:00
294aa86195
Change extension_id and mode types to u32
2020-09-10 11:58:40 -06:00
4edbd26d7f
Keep transaction details private.
2020-09-10 11:58:40 -06:00
fe6bea1fce
Check transparent input for correctness before modifying vin.
2020-09-10 11:58:40 -06:00
4a954c7f8f
Add tests for transaction builder support.
2020-09-10 11:58:40 -06:00
ca8e24eef5
Add validation to demo transaction builder.
2020-09-10 11:58:40 -06:00
659c34a954
Make error a type member of FromPayload trait rather than a type variable.
...
Fix demo test compilation errors.
2020-09-10 11:58:40 -06:00
961d251178
Add transaction-builder suport for TZE-bearing transactions.
2020-09-10 11:58:40 -06:00
bf7f95b0e9
TZE consensus context and program sets
...
Co-authored-by: Kris Nuttycombe <kris.nuttycombe@gmail.com>
2020-09-10 11:58:40 -06:00
ce9a695ded
Demo TZE parsing and consensus logic
2020-09-10 11:58:40 -06:00
b3332db3e9
Add TZEs to transaction format
2020-09-10 11:58:40 -06:00
192db29a25
Take epk as a jubjub::ExtendedPoint for note decryption
...
We don't need to check if epk is in the prime-order subgroup before we
trial-decrypt, which saves a third of the cost of trial-decrypting
outputs that are not ours.
2020-09-10 00:39:21 +01:00
0b9063e479
zcash_primitives: Add benchmark for Sapling note decryption
2020-09-10 00:21:05 +01:00
d4cba74402
Version bump 0.4.0 for crates
...
Bumps zcash_proofs, zcash_primitives, zcash_client_backend to 0.4.0
Also bumps zcash_client_sqlite to 0.2.0
2020-09-09 14:41:19 -06:00
c7e9523dce
Merge pull request #284 from str4d/259-ovk-none
...
zcash_primitives: Support ovk = ⊥ in note encryption
2020-09-09 14:32:57 -06:00
59e26a0c0f
bls12_381 0.3.1 and jubjub 0.5.1
2020-09-09 16:51:53 +01:00
6a62993714
secp256k1 0.19
2020-09-09 00:38:54 +01:00
96bd59b942
Migrate to ff 0.8 and bellman 0.8
...
bellman 0.8 includes fixes for several performance regressions.
MSRV is now 1.44.0, matching the ff crate.
2020-09-09 00:27:51 +01:00
40e135783c
zcash_primitives: Support ovk = ⊥ in note encryption
...
Closes zcash/librustzcash#259 .
2020-08-28 21:17:16 +01:00
72817b0edc
zcash_primitives: Add OutgoingCipherKey struct
2020-08-28 16:17:15 +01:00
3f06d92eec
Depend on published versions of subtree crates
2020-08-27 23:25:20 +01:00
e25a7dacdf
zcash_primitives 0.3.0
2020-08-23 16:23:53 +01:00
d112add8a3
jubjub 0.4.0
2020-08-23 16:23:53 +01:00
5f99c52143
bls12_381 0.2.0
2020-08-23 16:23:53 +01:00
bdb42bcbc8
pairing 0.17.0
2020-08-23 15:31:09 +01:00
ee3e8fbfbb
group 0.7.0
2020-08-23 15:31:09 +01:00
55fa366730
ff 0.7.0
2020-08-23 15:31:09 +01:00
a3cb89dff9
zcash_primitives: Add feature flags to docs.rs documentation
2020-08-23 06:56:03 +01:00
cfed47c176
Rename ValueCommitment.cm() to .commitment() (because it's confusing to have cm referring to both note and value commitments).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-08-22 01:28:13 +01:00
20c5096793
Fix remaining cases of cm -> cmu.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-08-22 01:28:13 +01:00
ee6c21f95b
Scripted diff:
...
```
find . -not -path '*/.git/*' -a -type f -exec sed -i -e 's/hash_x/hash_u/g' {} \;
find . -not -path '*/.git/*' -a -type f -exec sed -i -e 's/hash_y/hash_v/g' {} \;
```
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-08-22 01:28:13 +01:00
d15acf8acc
zcash_primitives: Rename Note::cm to Note::cmu
2020-08-21 18:35:04 +01:00
7a6223202e
zcash_primitives: Remove redundant TODO
...
The primitives are no longer generic over a curve; we hard-code Jubjub,
so we know that the smallest u-coordinate that is not on the curve is 1.
2020-08-21 18:27:09 +01:00
ca5bc6b0ae
zcash_primitives: Fix names of some test vector macros
2020-08-21 18:25:30 +01:00
ed3489a111
zcash_primitives: Explicitly type zero-initialised arrays
2020-08-21 18:22:29 +01:00
b9a8e1e415
zcash_primitives: Remove Jubjub implementation
...
We now use the jubjub crate for this.
2020-08-19 23:08:19 +01:00
fdf06032e3
s/{pairing::bls12_381, zcash_primitives::jubjub}/{bls12_381, jubjub}
...
FINALLY.
2020-08-19 23:08:19 +01:00
10c571f2cd
zcash_primitives: Define generator constants using new crates
...
Includes tests to ensure that the new generator constants match the
current zcash_primitives::JUBJUB generators.
2020-08-19 23:08:19 +01:00
b86558c63a
Decrypt sapling output description given OCK ( #271 )
...
* decrypt sapling outputs directly with ock
* make prf_ock public
* unit tests for ock sapling output decryption
2020-08-19 06:38:09 +12:00
45a7861720
zcash_primitives: fpe 0.3
2020-08-16 11:16:23 +01:00
751ddad17d
zcash_primitives: crypto_api_chachapoly 0.4
2020-08-14 17:44:17 +01:00
9ced89a1b0
zcash_primitives: secp256k1 0.17
2020-08-14 17:44:17 +01:00
bc8a839c61
Migrate to hex 0.4
2020-08-14 17:44:17 +01:00
5fe2d6a57c
zcash_primitives: ripemd160 0.9 and sha2 0.9
2020-08-14 17:44:17 +01:00
72cc8fc916
Minor refactor of enumeration in tests in note_encryption.rs
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-08-07 08:46:15 +08:00
13f4d0844e
Avoid using unwrap() when calling derive_esk()
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-08-07 00:12:07 +08:00
d54fd09c5f
Add esk check in parse_note_plaintext_without_memo() and try_sapling_output_recovery()
2020-08-06 18:39:49 +08:00
5480a376df
Extract derive_esk() into separate function
2020-08-06 18:21:27 +08:00
7cee29bbcc
Use <P: consensus::Parameters> type for Builder impl
2020-08-06 18:12:15 +08:00
0f8f1b3f5d
Fix parsing of rseed in parse_note_plaintext_without_memo() and try_sapling_output_recovery()
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-08-06 18:12:15 +08:00
40a908e0a8
Refactor leadbyte_array in note_encryption tests
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-08-06 18:12:10 +08:00
8968547981
Document pub enum Rseed<Fs> with link to ZIP 212
2020-08-06 13:13:49 +08:00
878646855c
Switch on leadbyte instead of tx height when decrypting outputs
2020-08-06 12:57:48 +08:00
c3d89644e2
Revert SaplingNoteEncryption::new() API to take rng instead of esk
2020-08-06 12:47:35 +08:00
4f22077cf6
Remove const activation heights from consensus.rs
2020-08-06 12:30:48 +08:00
9970a8aefd
Hard-code NetworkUpgrade::Canopy in generate_random_rseed
2020-08-06 12:27:20 +08:00
44f46e50ce
Add <P: consensus::Parameters> type parameter to Builder struct
2020-08-06 11:43:07 +08:00
88072d64ec
Remove network cfg from zcash_client_backend and zcash_primitives
2020-08-06 11:35:05 +08:00
c8fcdeb50b
Minor changes in note_encryption.rs
2020-08-05 15:45:18 +08:00
2ed9b6f881
Refactor contextual random rseed generation into util method in zcash_primitives
2020-08-05 15:21:42 +08:00
a3ae1b273d
Switch plaintext version on height for dummy outputs in Builder
2020-08-05 14:27:36 +08:00
a25348dfba
Revert passing Parameters to methods
2020-08-05 12:47:29 +08:00
0a47a9dbea
Pass rseed to Prover
2020-08-04 16:40:53 +08:00
b34e8b903c
Add invalid version byte tests for ZIP212
2020-08-03 13:51:45 +08:00
eba542c95f
Add activation heights as consts in consensus::Parameters
2020-08-03 13:40:39 +08:00
b1ddd556af
Check derived esk against claimed epk when decrypting note
2020-07-31 22:40:52 +08:00
895e251793
Fix tests
2020-07-31 22:40:48 +08:00
6904c8f933
Implement plaintext_version_is_valid()
2020-07-31 22:28:51 +08:00
eda00ec7ad
Pass esk to SaplingNoteEncryption::new and add generate_or_derive_esk()
2020-07-31 22:28:50 +08:00
65504d9ca7
Add enum Rseed<E::Fs> to Note struct
2020-07-31 22:28:40 +08:00
b537f0f712
Pass height to methods which encrypt or decrypt Sapling outputs
2020-07-31 12:39:39 +08:00
71d31abad6
Set activation heights for Canopy
2020-07-30 12:52:02 +08:00
f55f094ef6
Merge pull request #248 from str4d/equihash-crate
...
Move Equihash verifier into equihash crate
2020-07-10 11:57:11 +12:00
b5bd52e7a1
equihash 0.1.0
2020-07-10 10:25:52 +12:00
d380a8c8d2
Merge pull request #246 from str4d/zcash_client_sqlite
...
zcash_client_sqlite crate
2020-07-10 10:22:37 +12:00
5b2c71e112
Move Equihash verification APIs into equihash crate
2020-06-26 13:01:04 +12:00
34725df086
zcash_client_sqlite::transact::create_to_address()
2020-06-25 18:54:41 +12:00
a4b010e003
Placeholders for Canopy network upgrade
2020-06-04 15:44:15 +08:00
3779c12e31
Set activation heights for Heartwood network upgrade
2020-06-04 15:33:07 +12:00
4b1d8e5226
Add methods to get OutPoint n, hash
2020-05-22 18:02:44 -07:00
4edff96321
Fix various lints
2020-05-22 18:52:35 +12:00
d7d49285d8
Remove explicit std::marker from Sized bound
...
Sized is always part of the prelude, and binding on std causes
compilation issues for no-std crates.
2020-05-15 00:20:32 +12:00
c597db59a6
ff: Rename PrimeField::into_repr -> PrimeField::to_repr
2020-05-02 18:55:13 +12:00
15e229509a
ff: Move pow_vartime back into Field trait
...
The only places we don't use constant u64 limbs, we use PrimeField::char
instead (except in a single test where we use a field element).
2020-05-02 18:54:02 +12:00
fb31d09218
ff: Remove Ord bound from PrimeField
...
ff_derive still implements Ord and PartialOrd for the fields it
implements, because pairing::bls12_381 internally assumes that those are
implemented. Once we delete that implementation, we will remove the Ord
and PartialOrd implementations from ff_derive.
2020-05-02 18:54:02 +12:00
38f87c2e73
ff: Add PrimeField::ReprEndianness associated type
...
This enables generic code to reliably operate on the bits of an encoded
field element, by converting them to and from a known (little)
endianness.
The BitAnd and Shr bounds on PrimeField are now removed, as users can
perform these operations themselves as needed.
2020-05-02 18:54:02 +12:00
55568b4d6e
ff: Remove frobenius_map from Field trait
...
It is only used internally in the bls12_381 crate, and field extensions
aren't exposed anywhere in the Zcash stack.
2020-05-02 16:07:48 +12:00
1761ebfb35
ff: Remove SqrtField trait
...
The sqrt() function is now part of the Field trait. ff_derive returns an
error on fields for which it does not support generating a square root
function.
Note that Fq6 and Fq12 in pairing::bls12_381 leave the function
unimplemented. They will be dropped once the migration to the bls12_381
crate is complete. The equivalent structs in that crate are not exposed.
2020-05-02 16:07:48 +12:00
b02cf3b467
Merge pull request #223 from str4d/remove-primefieldrepr
...
Remove ff::PrimeFieldRepr
2020-05-01 08:59:41 +12:00
49f119fb03
ff: Remove PrimeFieldRepr trait
...
The ff::PrimeField::Repr associated type now has the minimal necessary
bounds, which can be satisfied by a newtype around a byte array.
2020-04-23 18:15:14 +12:00
1fe3e3784c
ff: Add Ord bound to PrimeField
2020-04-23 17:31:33 +12:00
1a40cfd39c
zcash_primitives: Make jubjub::Fs::invert constant time
2020-04-23 16:23:24 +12:00
08500ee712
ff: PrimeField: BitAnd<u64, Output = u64> + Shr<u32, Output = Self>
2020-04-23 16:23:24 +12:00
1fdca393bb
ff: PrimeField::{is_even, is_odd}
2020-04-23 16:23:24 +12:00
232f0a50b8
ff: Rework BitIterator to work with both u8 and u64 limb sizes
...
This enables BitIterator to be used with both the byte encoding and limb
representation of scalars.
2020-04-23 16:23:24 +12:00
fd79de5408
ff: Add PrimeField: From<u64> constraint
2020-04-23 16:23:24 +12:00
3ccadf3017
Add binding signature only if needed
2020-04-04 10:29:30 -07:00
b6457a905b
ff: Move pow_vartime into a trait that is generic over the limb size
...
The trait is implemented by default for u8 and u64, allowing pow_vartime
to be used with both the byte encoding and limb representation of field
elements.
2020-03-28 00:27:59 +13:00
2df2a2b2f2
Merge branch 'develop'
2020-03-14 10:36:58 +13:00
100878cd14
Version bump of all crates (except librustzcash)
2020-03-12 15:59:19 -06:00
b52e4aac3a
Fix Field::random method declarations.
2020-03-03 17:47:29 -07:00
2d30c29d06
Pass &impl TxProver to Builder::build
...
This allows the caller to build multiple transactions with a single
proving backend.
2020-02-08 00:37:31 +00:00
76e0f658c1
Rename CommitmentTreeWitness -> MerklePath
2020-02-08 00:36:40 +00:00
3a3008caf9
Pass CommitmentTreeWitness directly into Builder::add_sapling_spend
...
This is more likely to be the data that the caller has available, and
is all we need now that a CommitmentTreeWitness can compute its root.
2020-02-07 17:31:38 +00:00
8a210ec271
CommitmentTreeWitness::root(leaf)
2020-02-07 17:21:59 +00:00
2064d1c801
Refactor zcash_primitives::merkle_tree::CommitmentTreeWitness
...
- The internal Option wrapper was an unnecessary leftover from when this
code was directly inside the prover, where Some(x) represents an
assigned variable.
- CommitmentTreeWitness::from_slice_with_depth is more idiomatic Rust.
2020-02-07 00:06:57 +00:00
865275e2a2
Correcting some trivial Rust option/iterator warts
2020-01-29 13:53:05 -08:00
00499b3441
Migrate zcash_primitives benchmarks to criterion
2019-12-19 16:11:11 -06:00
ec2c304efd
no_std support for ff crate
2019-12-14 12:55:34 +00:00
1c9f5742fa
Improve Field::pow API and impl
...
Renamed to Field::pow_vartime to indicate it is still variable time with
respect to the exponent.
2019-12-14 12:27:48 +00:00
3d2acf48ce
Constant-time field square root
...
WARNING: THIS IS NOT FULLY CONSTANT TIME YET!
This will be fixed once we migrate to the jubjub and bls12_381 crates.
2019-12-13 20:13:30 +00:00
40749da9a7
Constant-time field inversion
...
WARNING: THIS IS NOT ACTUALLY CONSTANT TIME YET!
The jubjub and bls12_381 crates will replace our constant-time usages,
but we NEED to fix ff_derive because other users will expect it to
implement the Field trait correctly.
2019-12-13 19:46:04 +00:00
662be3551f
impl ConditionallySelectable for Field
2019-12-12 23:15:48 +00:00
cded08b0c5
Make Field::square take &self and return Self
2019-12-12 23:09:28 +00:00
9dac748224
Make Field::double take &self and return Self
2019-12-12 22:59:18 +00:00
91c32f1c7c
Move from Field::negate to Neg operator
2019-12-12 22:52:17 +00:00
27c8f34601
Move Field operations to operator-backed traits
...
The ff_derive, pairing, zcash_primitives::jubjub, and bellman dummy_engine
changes are minimally implemented on top of the existing *_assign()
functions.
2019-12-12 21:19:46 +00:00
0aa127d7b1
refactor to manage test code and data in separate modules
2019-12-11 23:58:13 +00:00
e6a8630b35
impl TryFrom<u32> for BranchId
2019-11-27 13:18:31 +00:00
cd326f2b6a
Consensus parameters for network upgrades
2019-11-27 13:18:30 +00:00
c24024b8e1
Create a consensus::BranchId enum for type safety
...
Includes all currently-known consensus branch IDs for the Zcash network.
2019-11-25 21:04:20 +00:00
219391ac92
Add missing sighash declaration
2019-11-14 09:54:07 -08:00
67d700feab
Merge pull request #107 from str4d/transaction-builder-transparent-inputs
...
Add P2PKH transparent input support to transaction::Builder
2019-11-13 22:15:55 +00:00
8d6f882510
Renames after moves
2019-11-13 19:21:47 +00:00
8d967c8609
Move transparent input pushing onto TransparentInputs
2019-11-13 19:20:09 +00:00
d9d50b98ab
Move transparent signing onto TransparentInputs
2019-11-13 19:12:55 +00:00
5823a695e2
Merge pull request #139 from adityapk00/tx_compare
...
Implement sorting for TxIDs
2019-11-04 16:29:59 +00:00
40d22ea2cc
Merge pull request #135 from NikVolf/extern-purge
...
Remove unneeded "extern crate"
2019-10-31 17:12:26 +00:00
b479981689
Implement clone for some structs
2019-10-15 17:47:53 +13:00
885e09a82f
Create OutPoint from hash and n
2019-10-15 17:47:23 +13:00
fab9160b26
transparent inputs should use serialize_der()
2019-10-15 17:46:33 +13:00
5a177eea27
Make mod serialize public
2019-10-15 17:42:49 +13:00
3425eabda2
transaction::Builder::add_transparent_input()
2019-10-15 17:42:46 +13:00
70857b0eed
Pass Script to signature_hash by reference
2019-10-15 17:32:34 +13:00
42b7f328fb
legacy::Script::address
...
This is the counterpart to legacy::TransparentAddress::script.
2019-10-15 17:32:34 +13:00
cd1083e086
Implememt sorting for TxIDs
2019-10-14 13:40:08 -07:00
2bbd25b36b
Add prevHash field to CompactBlock
...
This enables basic verification of chain validity when CompactBlocks are
received without the full header.
2019-10-09 14:11:14 +13:00
a3b85b8fe6
Compute and store BlockHash inside BlockHeader
2019-10-09 14:11:14 +13:00
7844394364
Remove unneeded extern crate
2019-10-08 16:12:14 +03:00
8b08528bb0
zcash_primitives 0.1.0
2019-10-08 17:43:33 +13:00
2399d9f3e3
Merge pull request #93 from defuse/qed-it-lrz
...
Bring in QED-it Tests
2019-10-08 13:47:36 +13:00
93563c3c65
Specify rand_core >= 0.5.1 for OsRng import.
2019-10-05 12:16:10 +02:00
524055bbb4
Merge pull request #134 from NikVolf/z-rng
...
Avoid using rand_os crate (fixes warnings)
2019-10-02 17:35:56 -06:00
730d2cbc7e
fix outdated example
2019-09-28 12:50:28 +03:00
b42477a0bf
update from rand_os to fix warnings
2019-09-28 10:48:43 +03:00
4ad3988e43
Crate docs
2019-09-24 14:23:59 +01:00
7f3036d2c8
Update READMEs
2019-09-24 14:23:55 +01:00
d9a0b9c83f
CI: Check intra-doc links
...
Credit: https://twitter.com/tomaka17/status/1176017851410526208
2019-09-24 10:35:12 +01:00
1d02363752
Add READMEs to Cargo.toml files
...
This will cause crates.io to render each crate's README as its
information page.
2019-09-23 14:42:38 +01:00
3701c2b442
Increase the number of pedersen hash generators, exercise all test vectors.
2019-09-17 00:05:54 +01:00
4dff8055bf
Remove unfinished find_group_hash test.
2019-09-16 23:44:14 +01:00
e391594e9e
Fix broken linear relation checking
2019-09-16 22:51:11 +01:00
15b4c37ab0
adds test for linear relation between pedersen hash generators
2019-09-16 22:23:28 +01:00
68ba93f5fd
PH test vectors for edge-cases
2019-09-16 21:58:28 +01:00
6240c02208
Long and random PH test vectors
2019-09-16 21:57:53 +01:00
be18eb240c
Move test vectors into own module
2019-09-16 21:57:42 +01:00
9080b4ccf3
Many test vectors for pedersen hash
2019-09-16 20:52:11 +01:00
f5dfe07355
A test vector for pedersen hash
2019-09-16 20:50:22 +01:00
2edcc12e8e
group_hash: adds test vectors generated by go-jubjub
2019-09-16 20:34:14 +01:00
7ee61c4f94
pedersen_hash: adds test vectors for the circuit implementation
2019-09-16 20:23:07 +01:00
15633ad434
pedersen hashes: example of size limit bug
2019-09-16 20:17:50 +01:00
414d651c9c
pedersen_hash: adds tests for Daniel's vector
2019-09-16 20:12:38 +01:00
8541b2bde4
pedersen_hash: prints hashes, adds comments
2019-09-16 20:12:33 +01:00
0a3b0a9341
Upgrade to hex-literal 0.2
2019-09-12 19:38:51 +01:00
d6f6b50ecd
Check try_sapling_output_recovery fails with identity as pk_d
2019-09-04 19:48:39 -04:00
abbd43ff57
Make pk_d validity an invariant of PaymentAddress
...
Introduces a PaymentAddress::from_parts constructor, and getters for
the diversifier and pk_d fields (which are now private).
2019-09-04 19:48:35 -04:00
86142d044c
PaymentAddress::to_bytes
2019-09-04 19:46:46 -04:00
73ee19239c
Replace manual address decoding with PaymentAddress::from_bytes
2019-09-04 19:46:46 -04:00
0c7eb84d36
impl FromStr for Memo
...
Memo::from_str was previously shadowing a built-in trait method.
2019-08-24 00:40:32 +01:00
7c1d4d9a5b
Log distinct error cases in Equihash verification
2019-08-24 00:40:30 +01:00
fe93f2ff6b
Rename into_ -> to_ where &self is used.
2019-08-24 00:39:54 +01:00
3a8efd9e67
Address various clippy warnings/errors in zcash_primitives
2019-08-24 00:39:49 +01:00
d78c94b2a2
Move Equihash validator into zcash_primitives
2019-08-24 00:37:00 +01:00
d63fa334ff
Remove unnecessary raw marker
...
Co-Authored-By: str4d <thestr4d@gmail.com>
2019-08-21 16:14:28 -06:00
76795a9014
cargo fmt
2019-08-20 22:22:03 -06:00
c28ae31c71
cargo fix --edition-idioms for zcash_primitives
2019-08-20 22:20:22 -06:00
09882c6d08
Add edition = 2018
2019-08-20 18:31:20 -06:00
b35a819a09
Replace try! macro
2019-08-20 18:24:47 -06:00
f523ac285d
cargo fmt
2019-08-20 17:17:21 -06:00
b0d8747697
cargo fix --edition for zcash_primitives
2019-08-20 17:15:07 -06:00
e12d315ab9
Warning cleanup
2019-08-20 16:45:10 -06:00
81c58172c3
cargo fmt zcash_primitives
2019-08-15 10:39:55 -06:00
5fb9b86ba0
Move Jubjub, Pedersen hash and primitives into zcash_primitives
2019-08-14 10:47:22 +01:00
2ae5804a67
Move Sprout and Sapling circuits into zcash_proofs
2019-08-14 10:45:55 +01:00
7ea6d10480
Move redjubjub into zcash_primitives
2019-08-14 10:43:25 +01:00
3211536324
Upgrade to crypto_api_chachapoly >= 0.2.1
2019-08-14 01:12:26 +01:00
2f1cae62b1
Upgrade to fpe 0.2
2019-08-14 01:12:23 +01:00
4a6c9ec425
Comment that we support a minimal set of script opcodes
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-08-14 00:30:18 +01:00
a28d94ff2e
Panic if Amount addition or subtraction overflows
2019-08-14 00:16:09 +01:00
1760b275a7
Simplify transaction builder tests
...
Requires impl PartialEq for Transaction, which is implemented as a TxId
comparison (relying on the invariant that Transaction is immutable).
2019-08-13 15:24:08 +01:00
3a73f946c5
Simplify structure of transaction builder errors
2019-08-13 15:10:57 +01:00
e6663212ff
Improve documentation for Amount
2019-08-08 09:21:09 +01:00
7c07914bfd
Separate Amount::{from_i64, from_nonnegative_i64} APIs
...
This is more intuitive than a boolean flag for handling non-negative
Amounts stored in i64 values.
2019-08-08 00:55:23 +01:00
59ed258c7f
Make Amount opaque, and use it more
...
This helps to ensure type-safety of values that are required to satisfy
zatoshi range bounds.
2019-07-27 00:35:29 +01:00
ab60b8804a
impl operators for Amount
2019-07-27 00:35:28 +01:00
0ea4408d46
Amount::{zero, is_positive, is_negative}
2019-07-27 00:35:27 +01:00
fa50d551c8
Move Amount impl into a submodule
2019-07-27 00:35:26 +01:00
17f6bbcc67
Pass tx builder RNG to spend_sig()
2019-07-27 00:35:04 +01:00
532299d46e
Allow transaction::Builder RNG to be configured
2019-07-27 00:32:56 +01:00
4b61120cd0
Pass tx builder RNG to SaplingNoteEncryption
2019-07-27 00:31:16 +01:00
a1cd9dfbac
transaction::Builder::add_transparent_output()
2019-07-27 00:28:02 +01:00
c26188a0bb
TransparentAddress struct for P2PKH and P2SH
2019-07-27 00:28:01 +01:00
dab3c002b7
Script opcode and data support
...
Overrides the shift-left operator for pushing opcodes onto the Script,
matching the notation used in zcashd.
2019-07-27 00:28:00 +01:00
1862354ea6
Sapling transaction builder
2019-07-27 00:27:50 +01:00
01618038bf
TxProver trait to abstract over the circuit parameters
...
An implementation using local parameters is provided in the zcash_proofs
crate.
2019-07-26 23:56:00 +01:00
05f098e893
Merge pull request #91 from str4d/upgrade-rand
...
Upgrade rand crate dependency to 0.7
2019-07-26 23:31:42 +01:00
5a48d179b8
Merge pull request #90 from adityapk00/paperwallet
...
Make some methods pub for use in External Wallet Generators
The exposed APIs may change in future crate versions.
2019-07-22 13:25:25 +01:00
7f60f0f881
Make some methods in DiversifierKey, DiversiferIndex pub
2019-07-18 16:19:45 -07:00
6f9083b5ab
Migrate to rand 0.7
2019-07-19 00:47:40 +02:00
8f7adec0d9
Migrate zcash_primitives to rand_core 0.4
2019-07-19 00:46:37 +02:00
6149166ccb
Migrate zcash_primitives to rand 0.5
2019-07-19 00:35:06 +02:00
8361674efc
Merge branch 'master' into blake2_simd
2019-07-18 18:22:20 +02:00
504c3eaeae
Address Daira's review comments
2019-07-15 16:33:43 +02:00
07dbfbef59
Address Eirik's review comments
2019-07-10 13:53:22 -04:00
79006ecbdf
Unify Sapling tree depth constants
...
When sapling-crypto is refactored, the zcash_primitives::sapling
constant would become the canonical one.
2019-07-10 13:53:22 -04:00
e67560b154
Document merkle_tree module
2019-07-10 13:53:22 -04:00
b9cea33804
Move merkle_tree::Node into sapling module
...
This makes the merkle_tree module properly generic over the tree hash.
It still hard-codes a depth 32 tree, because Rust doesn't yet support
generic sizes, and we are unlikely to need to alter the tree depth in
future circuit changes.
2019-07-10 13:53:22 -04:00
263bbe1207
Use Iterator::all() in place of Iterator::fold()
2019-07-10 13:53:22 -04:00
98d7621135
Don't assert when parsing a CommitmentTreeWitness
2019-07-10 13:53:22 -04:00
9b4186705a
Add serialization APIs to CommitmentTree and IncrementalWitness
2019-07-10 13:53:22 -04:00
70a7069058
Helper for serializing Option<T>
2019-07-10 13:53:22 -04:00
Jack Grigg
Kris Nuttycombe
Kris Nuttycombe
Jack Grigg
François Garillot
Sean Bowe
Daira Hopwood
Kevin Gorham
Aditya Kulkarni
Matthew Fors
ying tong
therealyingtong
str4d
zancas
NikVolf
Jim Posen
Taylor Hornby
Kobi Gurkan
Aurélien Nicolas
Eirik Ogilvie-Wigley
Eirik Ogilvie-Wigley