From 4296860a862b587d60cac8e670101e523717aec4 Mon Sep 17 00:00:00 2001 From: Gygaxis Vainhardt Date: Thu, 8 Dec 2022 16:36:54 -0400 Subject: [PATCH] Partially apply suggestions from code review Co-authored-by: str4d --- CHANGELOG.md | 9 +++++---- src/builder.rs | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 261ea5dc..75ab53e9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,10 +12,11 @@ and this project adheres to Rust's notion of - `OutputsDisabled` ### Changed -- `orchard::builder::Builder::{add_spend, add_output}` now use - concrete error types instead of `&'static str`s. -- `orchard::builder::Error` is now `BuildError` to differentiate from - new error types +- `orchard::builder`: + - `Builder::{add_spend, add_output}` now use concrete error types instead of + `&'static str`s. + - `Error` has been renamed to `BuildError` to differentiate from new error + types. ## [0.3.0] - 2022-10-19 ### Added diff --git a/src/builder.rs b/src/builder.rs index f69a3cb6..847a3d14 100644 --- a/src/builder.rs +++ b/src/builder.rs @@ -295,7 +295,7 @@ impl Builder { memo: Option<[u8; 512]>, ) -> Result<(), OutputsDisabled> { if !self.flags.outputs_enabled() { - return Err(()); + return Err(OutputsDisabled); } self.recipients.push(RecipientInfo {