From 158f3e6e7134f2dd76e5b04f8ad1272d91165879 Mon Sep 17 00:00:00 2001 From: Tomas Krnak Date: Sat, 13 Aug 2022 15:35:01 +0200 Subject: [PATCH 1/2] Publicize `ValueCommitment::derive` constructor --- src/value.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/value.rs b/src/value.rs index a760e77b..29e10c2f 100644 --- a/src/value.rs +++ b/src/value.rs @@ -286,13 +286,13 @@ impl<'a> Sum<&'a ValueCommitment> for ValueCommitment { } impl ValueCommitment { - /// $ValueCommit^Orchard$. + /// Derives a `ValueCommitment` by ValueCommit^Orchard. /// /// Defined in [Zcash Protocol Spec § 5.4.8.3: Homomorphic Pedersen commitments (Sapling and Orchard)][concretehomomorphiccommit]. /// /// [concretehomomorphiccommit]: https://zips.z.cash/protocol/nu5.pdf#concretehomomorphiccommit #[allow(non_snake_case)] - pub(crate) fn derive(value: ValueSum, rcv: ValueCommitTrapdoor) -> Self { + pub fn derive(value: ValueSum, rcv: ValueCommitTrapdoor) -> Self { let hasher = pallas::Point::hash_to_curve(VALUE_COMMITMENT_PERSONALIZATION); let V = hasher(&VALUE_COMMITMENT_V_BYTES); let R = hasher(&VALUE_COMMITMENT_R_BYTES); From 47004ee87aac73c3aab59b3a5390b71d36caaa81 Mon Sep 17 00:00:00 2001 From: Daira Hopwood Date: Mon, 19 Sep 2022 14:49:16 +0100 Subject: [PATCH 2/2] Use math notation for ValueCommit^Orchard --- src/value.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/value.rs b/src/value.rs index 29e10c2f..8068fbbf 100644 --- a/src/value.rs +++ b/src/value.rs @@ -286,7 +286,7 @@ impl<'a> Sum<&'a ValueCommitment> for ValueCommitment { } impl ValueCommitment { - /// Derives a `ValueCommitment` by ValueCommit^Orchard. + /// Derives a `ValueCommitment` by $\mathsf{ValueCommit^{Orchard}}$. /// /// Defined in [Zcash Protocol Spec § 5.4.8.3: Homomorphic Pedersen commitments (Sapling and Orchard)][concretehomomorphiccommit]. ///