clean todo

This commit is contained in:
adust09 2023-08-13 17:49:57 +09:00
parent cab9a397a9
commit 64d6716839
3 changed files with 3 additions and 6 deletions

View File

@ -31,7 +31,6 @@ pub const DEFAULT_FEE: Amount = Amount(1000);
/// by the network consensus rules.
///
/// [`Transaction`]: crate::transaction::Transaction
/// TODO: should downgrade rust analyzer?
#[derive(Clone, Copy, Debug, PartialEq, PartialOrd, Eq, Ord)]
pub struct Amount(i64);
@ -248,7 +247,6 @@ impl TryFrom<orchard::ValueSum> for Amount {
///
/// A NonNegativeAmount can only be constructed from an integer that is within the valid monetary
/// range of `{0..MAX_MONEY}` (where `MAX_MONEY` = 21,000,000 × 10⁸ zatoshis).
/// TODO: should downgrade rust analyzer?
#[derive(Clone, Copy, Debug, PartialEq, PartialOrd, Eq, Ord)]
pub struct NonNegativeAmount(Amount);

View File

@ -46,7 +46,7 @@ impl AssetType {
assert_eq!(ASSET_IDENTIFIER_PERSONALIZATION.len(), 8);
// Create a new BLAKE2s state for deriving the asset identifier
//TODO:sinsemillaに置き換える
// TODO: sinsemilla hasに置き換える?そのままでもいい気がしてきた
let h = Blake2sParams::new()
.hash_length(ASSET_IDENTIFIER_LENGTH)
.personal(ASSET_IDENTIFIER_PERSONALIZATION)
@ -122,7 +122,7 @@ impl AssetType {
}
/// Produces a value commitment generator with cofactor cleared
/// todo:返り値をsubgroup
/// TODO:返り値をsubgroupにする
pub fn value_commitment_generator(&self) -> () {
CofactorGroup::clear_cofactor(&self.asset_generator());
}

View File

@ -470,7 +470,7 @@ impl plonk::Circuit<pallas::Base> for Circuit {
merkle_inputs.calculate_root(layouter.namespace(|| "Merkle path"), leaf)?
};
// TODO:add vb
// TODO: add vb
// Value commitment integrity (https://p.z.cash/ZKS:action-cv-net-integrity?partial).
let v_net_magnitude_sign = {
// Witness the magnitude and sign of v_net = v_old - v_new
@ -614,7 +614,6 @@ impl plonk::Circuit<pallas::Base> for Circuit {
pk_d_old
};
//TODO:add vb
// Old note commitment integrity (https://p.z.cash/ZKS:action-cm-old-integrity?partial).
{
let rcm_old = ScalarFixed::new(