From 69f0ea493f918daec73bb32c56a8e6197e2e7d15 Mon Sep 17 00:00:00 2001
From: Paul <lauxpaul@protonmail.com>
Date: Tue, 24 May 2022 20:23:50 +0300
Subject: [PATCH] fixed clippy warrnings

---
 src/builder.rs | 2 +-
 src/circuit.rs | 2 +-
 src/value.rs   | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/builder.rs b/src/builder.rs
index b2f894c4..e07e31f1 100644
--- a/src/builder.rs
+++ b/src/builder.rs
@@ -141,7 +141,7 @@ impl ActionInfo {
     /// [orchardsend]: https://zips.z.cash/protocol/nu5.pdf#orchardsend
     fn build(self, mut rng: impl RngCore) -> (Action<SigningMetadata>, Circuit) {
         let v_net = self.value_sum();
-        let cv_net = ValueCommitment::derive(v_net, self.rcv.clone(), NoteType::native());
+        let cv_net = ValueCommitment::derive(v_net, self.rcv, NoteType::native());
 
         let nf_old = self.spend.note.nullifier(&self.spend.fvk);
         let sender_address = self.spend.note.recipient();
diff --git a/src/circuit.rs b/src/circuit.rs
index 13a8d264..39c34bdb 100644
--- a/src/circuit.rs
+++ b/src/circuit.rs
@@ -906,7 +906,7 @@ mod tests {
 
         let value = spent_note.value() - output_note.value();
         let rcv = ValueCommitTrapdoor::random(&mut rng);
-        let cv_net = ValueCommitment::derive(value, rcv.clone(), NoteType::native());
+        let cv_net = ValueCommitment::derive(value, rcv, NoteType::native());
 
         let path = MerklePath::dummy(&mut rng);
         let anchor = path.root(spent_note.commitment().into());
diff --git a/src/value.rs b/src/value.rs
index 24deb4a9..84f376c2 100644
--- a/src/value.rs
+++ b/src/value.rs
@@ -208,7 +208,7 @@ impl TryFrom<ValueSum> for i64 {
 }
 
 /// The blinding factor for a [`ValueCommitment`].
-#[derive(Clone, Debug)]
+#[derive(Clone, Copy, Debug)]
 pub struct ValueCommitTrapdoor(pallas::Scalar);
 
 impl ValueCommitTrapdoor {
@@ -418,7 +418,7 @@ mod tests {
     use crate::primitives::redpallas;
 
     fn _bsk_consistent_with_bvk(
-        values: &Vec<(ValueSum, ValueCommitTrapdoor)>,
+        values: &[(ValueSum, ValueCommitTrapdoor)],
         note_type: NoteType,
     ) {
         let value_balance = values
@@ -434,8 +434,8 @@ mod tests {
             .into_bsk();
 
         let bvk = (values
-            .into_iter()
-            .map(|(value, rcv)| ValueCommitment::derive(value.clone(), rcv.clone(), note_type))
+            .iter()
+            .map(|(value, rcv)| ValueCommitment::derive(*value, *rcv, note_type))
             .sum::<ValueCommitment>()
             - ValueCommitment::derive(value_balance, ValueCommitTrapdoor::zero(), note_type))
         .into_bvk();