This commit is contained in:
ebfull 2022-05-05 15:29:19 +00:00
parent bc6985db90
commit da76039d70
6 changed files with 10 additions and 549 deletions

View File

@ -180,11 +180,11 @@ transactions to 1-in, 2-out).</p>
bundle of actions, where each action is both a spend and an output. This provides the same
inherent arity-hiding as multi-JoinSplit Sprout, but using Sapling value commitments to
balance the transaction without doubling its size.</p>
<p>TODO: Depending on the circuit cost, we <em>may</em> switch to having an action internally
represent either a spend or an output. Externally spends and outputs would still be
indistinguishable, but the transaction would be larger.</p>
<h2><a class="header" href="#memo-fields" id="memo-fields">Memo fields</a></h2>
<p>TODO: One memo per tx vs one memo per output</p>
<p>Each Orchard action has a memo field for its corresponding output, as with Sprout and
Sapling. We did at one point consider having a single Orchard memo field per transaction,
and/or having a mechanism for enabling multiple recipients to decrypt the same memo, but
these were decided against in order to keep the overall design simpler.</p>
</main>

View File

@ -1,260 +0,0 @@
window.BENCHMARK_DATA = {
"lastUpdate": 1651679119320,
"repoUrl": "https://github.com/zcash/orchard",
"entries": {
"Orchard Benchmarks": [
{
"commit": {
"author": {
"email": "jack@electriccoin.co",
"name": "str4d",
"username": "str4d"
},
"committer": {
"email": "noreply@github.com",
"name": "GitHub",
"username": "web-flow"
},
"distinct": true,
"id": "39495dc94b90380caccf32bbb4190685585e2804",
"message": "Merge pull request #319 from zcash/279-update-builder-docs\n\nUpdate `Builder::build` docs",
"timestamp": "2022-05-04T16:21:07+01:00",
"tree_id": "080582becccc62d8e0db0cce1ae07d14233521d4",
"url": "https://github.com/zcash/orchard/commit/39495dc94b90380caccf32bbb4190685585e2804"
},
"date": 1651678606380,
"tool": "cargo",
"benches": [
{
"name": "proving/bundle/1",
"value": 5252825229,
"range": "± 172298188",
"unit": "ns/iter"
},
{
"name": "proving/bundle/2",
"value": 5419327447,
"range": "± 126606233",
"unit": "ns/iter"
},
{
"name": "proving/bundle/3",
"value": 7722071197,
"range": "± 74802883",
"unit": "ns/iter"
},
{
"name": "proving/bundle/4",
"value": 9743272283,
"range": "± 206718056",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/1",
"value": 42146321,
"range": "± 1698181",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/2",
"value": 43573703,
"range": "± 2506332",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/3",
"value": 46715743,
"range": "± 1774078",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/4",
"value": 51971171,
"range": "± 2317565",
"unit": "ns/iter"
}
]
},
{
"commit": {
"author": {
"email": "jack@electriccoin.co",
"name": "str4d",
"username": "str4d"
},
"committer": {
"email": "noreply@github.com",
"name": "GitHub",
"username": "web-flow"
},
"distinct": true,
"id": "dc89386df14efc47d57f95ab4bed6ddd134d5529",
"message": "Merge pull request #320 from zcash/243-compact-action-nullifier\n\nAdd nullifier field to `CompactAction`",
"timestamp": "2022-05-04T16:27:03+01:00",
"tree_id": "c74972c406e2ebd480646594e268582552d51a4b",
"url": "https://github.com/zcash/orchard/commit/dc89386df14efc47d57f95ab4bed6ddd134d5529"
},
"date": 1651679118103,
"tool": "cargo",
"benches": [
{
"name": "proving/bundle/1",
"value": 4628038034,
"range": "± 35673476",
"unit": "ns/iter"
},
{
"name": "proving/bundle/2",
"value": 4623520025,
"range": "± 10153190",
"unit": "ns/iter"
},
{
"name": "proving/bundle/3",
"value": 6617421522,
"range": "± 13638042",
"unit": "ns/iter"
},
{
"name": "proving/bundle/4",
"value": 8613461096,
"range": "± 16080522",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/1",
"value": 37999758,
"range": "± 360640",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/2",
"value": 38052759,
"range": "± 161611",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/3",
"value": 42462875,
"range": "± 284307",
"unit": "ns/iter"
},
{
"name": "verifying/bundle/4",
"value": 46448394,
"range": "± 2230933",
"unit": "ns/iter"
},
{
"name": "note-decryption/valid",
"value": 1241786,
"range": "± 1194",
"unit": "ns/iter"
},
{
"name": "note-decryption/invalid",
"value": 157124,
"range": "± 164",
"unit": "ns/iter"
},
{
"name": "note-decryption/compact-valid",
"value": 1236772,
"range": "± 4477",
"unit": "ns/iter"
},
{
"name": "compact-note-decryption/invalid",
"value": 161453660,
"range": "± 331043",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/valid/10",
"value": 24419178,
"range": "± 52748",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/invalid/10",
"value": 2756091,
"range": "± 2441",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/compact-valid/10",
"value": 24417861,
"range": "± 20978",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/compact-invalid/10",
"value": 2710700,
"range": "± 2260",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/valid/50",
"value": 122020860,
"range": "± 63016",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/invalid/50",
"value": 13715731,
"range": "± 7857",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/compact-valid/50",
"value": 122001110,
"range": "± 83107",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/compact-invalid/50",
"value": 13494271,
"range": "± 15338",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/valid/100",
"value": 244003137,
"range": "± 413487",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/invalid/100",
"value": 27427762,
"range": "± 18723",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/compact-valid/100",
"value": 244080679,
"range": "± 457638",
"unit": "ns/iter"
},
{
"name": "batch-note-decryption/compact-invalid/100",
"value": 26979011,
"range": "± 14349",
"unit": "ns/iter"
},
{
"name": "derive_fvk",
"value": 578366,
"range": "± 1400",
"unit": "ns/iter"
},
{
"name": "default_address",
"value": 639759,
"range": "± 433",
"unit": "ns/iter"
}
]
}
]
}
}

View File

@ -1,279 +0,0 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1, user-scalable=yes" />
<style>
html {
font-family: BlinkMacSystemFont,-apple-system,"Segoe UI",Roboto,Oxygen,Ubuntu,Cantarell,"Fira Sans","Droid Sans","Helvetica Neue",Helvetica,Arial,sans-serif;
-webkit-font-smoothing: antialiased;
background-color: #fff;
font-size: 16px;
}
body {
color: #4a4a4a;
margin: 8px;
font-size: 1em;
font-weight: 400;
}
header {
margin-bottom: 8px;
display: flex;
flex-direction: column;
}
main {
width: 100%;
display: flex;
flex-direction: column;
}
a {
color: #3273dc;
cursor: pointer;
text-decoration: none;
}
a:hover {
color: #000;
}
button {
color: #fff;
background-color: #3298dc;
border-color: transparent;
cursor: pointer;
text-align: center;
}
button:hover {
background-color: #2793da;
flex: none;
}
.spacer {
flex: auto;
}
.small {
font-size: 0.75rem;
}
footer {
margin-top: 16px;
display: flex;
align-items: center;
}
.header-label {
margin-right: 4px;
}
.benchmark-set {
margin: 8px 0;
width: 100%;
display: flex;
flex-direction: column;
}
.benchmark-title {
font-size: 3rem;
font-weight: 600;
word-break: break-word;
text-align: center;
}
.benchmark-graphs {
display: flex;
flex-direction: row;
justify-content: space-around;
align-items: center;
flex-wrap: wrap;
width: 100%;
}
.benchmark-chart {
max-width: 1000px;
}
</style>
<title>Benchmarks</title>
</head>
<body>
<header id="header">
<div class="header-item">
<strong class="header-label">Last Update:</strong>
<span id="last-update"></span>
</div>
<div class="header-item">
<strong class="header-label">Repository:</strong>
<a id="repository-link" rel="noopener"></a>
</div>
</header>
<main id="main"></main>
<footer>
<button id="dl-button">Download data as JSON</button>
<div class="spacer"></div>
<div class="small">Powered by <a rel="noopener" href="https://github.com/marketplace/actions/continuous-benchmark">github-action-benchmark</a></div>
</footer>
<script src="https://cdn.jsdelivr.net/npm/chart.js@2.9.2/dist/Chart.min.js"></script>
<script src="data.js"></script>
<script id="main-script">
'use strict';
(function() {
// Colors from https://github.com/github/linguist/blob/master/lib/linguist/languages.yml
const toolColors = {
cargo: '#dea584',
go: '#00add8',
benchmarkjs: '#f1e05a',
pytest: '#3572a5',
googlecpp: '#f34b7d',
catch2: '#f34b7d',
julia: '#a270ba',
benchmarkdotnet: '#178600',
customBiggerIsBetter: '#38ff38',
customSmallerIsBetter: '#ff3838',
_: '#333333'
};
function init() {
function collectBenchesPerTestCase(entries) {
const map = new Map();
for (const entry of entries) {
const {commit, date, tool, benches} = entry;
for (const bench of benches) {
const result = { commit, date, tool, bench };
const arr = map.get(bench.name);
if (arr === undefined) {
map.set(bench.name, [result]);
} else {
arr.push(result);
}
}
}
return map;
}
const data = window.BENCHMARK_DATA;
// Render header
document.getElementById('last-update').textContent = new Date(data.lastUpdate).toString();
const repoLink = document.getElementById('repository-link');
repoLink.href = data.repoUrl;
repoLink.textContent = data.repoUrl;
// Render footer
document.getElementById('dl-button').onclick = () => {
const dataUrl = 'data:,' + JSON.stringify(data, null, 2);
const a = document.createElement('a');
a.href = dataUrl;
a.download = 'benchmark_data.json';
a.click();
};
// Prepare data points for charts
return Object.keys(data.entries).map(name => ({
name,
dataSet: collectBenchesPerTestCase(data.entries[name]),
}));
}
function renderAllChars(dataSets) {
function renderGraph(parent, name, dataset) {
const canvas = document.createElement('canvas');
canvas.className = 'benchmark-chart';
parent.appendChild(canvas);
const color = toolColors[dataset.length > 0 ? dataset[0].tool : '_'];
const data = {
labels: dataset.map(d => d.commit.id.slice(0, 7)),
datasets: [
{
label: name,
data: dataset.map(d => d.bench.value),
borderColor: color,
backgroundColor: color + '60', // Add alpha for #rrggbbaa
}
],
};
const options = {
scales: {
xAxes: [
{
scaleLabel: {
display: true,
labelString: 'commit',
},
}
],
yAxes: [
{
scaleLabel: {
display: true,
labelString: dataset.length > 0 ? dataset[0].bench.unit : '',
},
ticks: {
beginAtZero: true,
}
}
],
},
tooltips: {
callbacks: {
afterTitle: items => {
const {index} = items[0];
const data = dataset[index];
return '\n' + data.commit.message + '\n\n' + data.commit.timestamp + ' committed by @' + data.commit.committer.username + '\n';
},
label: item => {
let label = item.value;
const { range, unit } = dataset[item.index].bench;
label += ' ' + unit;
if (range) {
label += ' (' + range + ')';
}
return label;
},
afterLabel: item => {
const { extra } = dataset[item.index].bench;
return extra ? '\n' + extra : '';
}
}
},
onClick: (_mouseEvent, activeElems) => {
if (activeElems.length === 0) {
return;
}
// XXX: Undocumented. How can we know the index?
const index = activeElems[0]._index;
const url = dataset[index].commit.url;
window.open(url, '_blank');
},
};
new Chart(canvas, {
type: 'line',
data,
options,
});
}
function renderBenchSet(name, benchSet, main) {
const setElem = document.createElement('div');
setElem.className = 'benchmark-set';
main.appendChild(setElem);
const nameElem = document.createElement('h1');
nameElem.className = 'benchmark-title';
nameElem.textContent = name;
setElem.appendChild(nameElem);
const graphsElem = document.createElement('div');
graphsElem.className = 'benchmark-graphs';
setElem.appendChild(graphsElem);
for (const [benchName, benches] of benchSet.entries()) {
renderGraph(graphsElem, benchName, benches)
}
}
const main = document.getElementById('main');
for (const {name, dataSet} of dataSets) {
renderBenchSet(name, dataSet, main);
}
}
renderAllChars(init()); // Start
})();
</script>
</body>
</html>

View File

@ -384,11 +384,11 @@ transactions to 1-in, 2-out).</p>
bundle of actions, where each action is both a spend and an output. This provides the same
inherent arity-hiding as multi-JoinSplit Sprout, but using Sapling value commitments to
balance the transaction without doubling its size.</p>
<p>TODO: Depending on the circuit cost, we <em>may</em> switch to having an action internally
represent either a spend or an output. Externally spends and outputs would still be
indistinguishable, but the transaction would be larger.</p>
<h2><a class="header" href="#memo-fields" id="memo-fields">Memo fields</a></h2>
<p>TODO: One memo per tx vs one memo per output</p>
<p>Each Orchard action has a memo field for its corresponding output, as with Sprout and
Sapling. We did at one point consider having a single Orchard memo field per transaction,
and/or having a mechanism for enabling multiple recipients to decrypt the same memo, but
these were decided against in order to keep the overall design simpler.</p>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/katex@0.12.0/dist/katex.min.css" integrity="sha384-AfEj0r4/OFrOo5t7NnNe46zW/tFgW6x/bCJG8FqQCEo3+Aro6EYUG4+cU+KJWu/X" crossorigin="anonymous">
<h1><a class="header" href="#commitments" id="commitments">Commitments</a></h1>
<p>As in Sapling, we require two kinds of commitment schemes in Orchard:</p>

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long