Commit Graph

1280 Commits

Author SHA1 Message Date
Jack Grigg caca664b20 Make `Debug` impl for `TransmittedNoteCiphertext` less verbose
We now print the ciphertexts as hex bytes, for which we unambiguously
encode them in RPC outputs (vs 32-byte values which are more complex).
2022-04-06 17:22:17 +00:00
Jack Grigg 6941fe1109 Make `Debug` impl for `Proof` much less verbose
For the default `{:?}` debug formatting we now only print the length of
the proof, while `{#?}` continues to print the full byte vector.
2022-04-06 17:21:48 +00:00
str4d 5b8690338e
Merge pull request #310 from zcash/update-deps
Update dependencies
2022-04-06 13:34:33 +01:00
Jack Grigg 6873782a48 Remove unused dependencies
Closes zcash/orchard#307.
2022-04-06 11:35:57 +00:00
Jack Grigg 3b5fb01218 Migrate to `halo2_proofs 0.1.0-beta.4` 2022-04-06 11:30:39 +00:00
Kris Nuttycombe 420d600f0e
Merge pull request #305 from zcash/fvk-scope
Add explicit scoping for viewing keys and addresses
2022-03-30 08:37:20 -06:00
therealyingtong eaa0cfdbf6 Check that the internal IVK can be derived from a spending key
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-30 20:49:38 +08:00
therealyingtong e550c3d536 Check IVK derivations during FullViewingKey::from_bytes.
Closes zcash/orchard#303

Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-30 20:49:38 +08:00
therealyingtong a0424984c6 Add explicit scoping for viewing keys and addresses
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-30 20:49:37 +08:00
str4d cbe032f3d4
Merge pull request #302 from zcash/release-0.1.0-beta.2
Release 0.1.0-beta.2
2022-03-22 23:56:13 +00:00
Jack Grigg 75aef252d2 orchard 0.1.0-beta.2 2022-03-22 21:29:36 +00:00
Jack Grigg 56a946dafc halo2_proofs 0.1.0-beta.3
The change to the pinned circuit description is due to removing the
unnecessary `selector_map` pin in zcash/halo2#521. This invalidates
previous proofs due to changing Fiat-Shamir transcript initialization).
2022-03-22 21:29:36 +00:00
Jack Grigg f9ddb46687 incrementalmerkletree 0.3.0-beta.1 2022-03-22 20:42:30 +00:00
str4d 43d38f5b97
Merge pull request #301 from zcash/non-consensus-changes-on-branchid-c4cd541e
Merge non-consensus changes
2022-03-22 19:42:35 +00:00
Jack Grigg d6d1dbea14 Update serialized proof test case for circuit changes 2022-03-22 17:59:56 +00:00
Jack Grigg 6c9ff19342 Merge branch 'main' into non-consensus-changes-on-branchid-c4cd541e 2022-03-22 17:55:59 +00:00
str4d 0ee6cf894f
Merge pull request #296 from zcash/commitivk-identity-error
spec.rs: Check that commit_ivk returns a nonzero base.
2022-03-17 22:27:27 +00:00
Jack Grigg 72b6febf7b Move zero-handling from inside CommitIVK to outside it
This more closely matches the change to the protocol spec.
2022-03-17 18:51:33 +00:00
str4d e14a923a9d
Merge pull request #300 from zcash/add-orchard-serialized-proof-test-case
Add serialized proof test case
2022-03-17 05:00:57 +00:00
Jack Grigg 795fb78d2d Add serialized proof test case
Co-authored-by: Sean Bowe <ewillbefull@gmail.com>
2022-03-16 19:47:00 +00:00
Jack Grigg 5356804bfe Update comment in `spec::commit_ivk` 2022-03-15 23:26:57 +00:00
therealyingtong 72f1ca6b45 spec.rs: Check that commit_ivk returns a nonzero base. 2022-03-16 01:28:13 +08:00
Kris Nuttycombe f4587f790d
Merge pull request #295 from nuttycom/bundle_decrypt_with_ovks
Add convenience methods on `Bundle` to decrypt actions with OVKs.
2022-03-15 09:30:03 -06:00
Kris Nuttycombe 40efd57757
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-15 07:47:21 -06:00
Kris Nuttycombe 45a6a30b21 Add convenience methods on `Bundle` to decrypt actions with OVKs.
This renames `decrypt_outputs_for_keys` to `decrypt_outputs_with_keys`
for consistency with `decrypt_output_with_key` and tne newly added
`recover_output*_with_ovk*` methods.
2022-03-14 19:28:47 -06:00
str4d 3ddf6c49f7
Merge pull request #293 from zcash/merge-non-consensus-changes-2
Merge non-consensus changes again
2022-02-28 21:17:26 +00:00
Jack Grigg f983242986 Update changelog 2022-02-28 20:59:55 +00:00
Jack Grigg eb7a9668aa Merge branch 'non-consensus-changes-on-branchid-c4cd541e' into merge-non-consensus-changes-2 2022-02-28 20:46:55 +00:00
str4d a5f701f318
Merge pull request #292 from zcash/debug-trait-bounds
Add missing `Debug` trait bounds for `Builder` components
2022-02-28 20:34:47 +00:00
Jack Grigg def4d4d9ae Add missing `Debug` trait bounds for `Builder` components
All relevant types have `Debug` impls, but some of the trait and method
impls were lacking `Debug` bounds on their generic types. This prevented
`Debug` impls being used on the overall partially-constructed `Bundle`
types.
2022-02-28 20:09:30 +00:00
Kris Nuttycombe 8449fd133c Merge branch 'update_incrementalmerkletree' into non-consensus-changes-on-branchid-c4cd541e 2022-02-24 13:15:31 -07:00
Kris Nuttycombe 273662c00b
Apply suggestions from code review
Co-authored-by: str4d <thestr4d@gmail.com>
2022-02-24 09:16:39 -07:00
Kris Nuttycombe e32a075ef0 Update the incremental merkle tree version and the Rust toolchain.
Use derived equality and ordering (which delegate to constant-time
versions) for note::nullifier::Nullifier and tree::MerkleHashOrchard
so that these types can be used as map keys in wallets.
2022-02-24 09:12:12 -07:00
Kris Nuttycombe 1cf828fe7b Update the incremental merkle tree version and the Rust toolchain.
Use derived equality and ordering (which delegate to constant-time
versions) for note::nullifier::Nullifier and tree::MerkleHashOrchard
so that these types can be used as map keys in wallets.
2022-02-23 20:43:02 -07:00
str4d 3b8d07f7b6
Merge pull request #289 from zcash/internal-fvk
Add `FullViewingKey::derive_internal`
2022-02-22 14:06:23 +00:00
Jack Grigg 65f3e6ec32 Add `FullViewingKey::derive_internal`
This is identical to the changes introduced in zcash/orchard#270, except
that the output is non-optional (since the derivation is non-fallible).
2022-02-21 14:41:47 +00:00
Dimitris Apostolou b96533a2b8
Fix typos 2022-02-18 23:31:27 +02:00
str4d f1795f8068
Merge pull request #286 from zcash/merge-non-consensus-changes
Merge non-consensus changes
2022-02-15 23:36:29 +00:00
Jack Grigg 0944cf8800 Fix clippy lint 2022-02-15 23:15:44 +00:00
Jack Grigg 28c22718c0 Remove `hash_bundle_txid_data, hash_bundle_auth_data` from API 2022-02-15 23:03:02 +00:00
Jack Grigg 9283002c13 Update changelog 2022-02-15 22:56:01 +00:00
Jack Grigg 4ba063a07d Update non-consensus tests for changes in consensus branch 2022-02-15 22:48:28 +00:00
Jack Grigg b1d7787ab6 Re-introduce `ValueSum::from_raw` as a `pub(crate)` method
We removed this in zcash/orchard#267 as it did not need to be part of
the public API, but we do still need a way to convert the user-defined
valueBalance type into a `ValueSum` when constructing `bvk`, and this
method is preferable to exposing the `ValueSum` internals.
2022-02-15 22:47:05 +00:00
Jack Grigg 17ad25ee35 Merge branch 'non-consensus-changes-on-branchid-c4cd541e' into merge-non-consensus-changes 2022-02-15 22:46:47 +00:00
str4d 4dc1ae059a
Merge pull request #285 from zcash/bundle-builder-test
Functional test for building and verifying bundles
2022-02-15 22:45:56 +00:00
Jack Grigg 62da82bd38 Add functional test for creating and verifying a shielded bundle
The text exposed some limitations of the current crate API, which have
been fixed.
2022-02-15 22:17:15 +00:00
Jack Grigg 0b6bd07904 Add functional test for creating and verifying a shielding bundle
The text exposed some limitations of the current crate API, which have
been fixed.
2022-02-15 22:17:15 +00:00
str4d d0ed65c37c
Merge pull request #283 from nuttycom/ivk_expose_dk
Allow decryption of the diversifier index for an an address using the IVK.
2022-02-15 22:16:49 +00:00
Daira Hopwood e92d1167af The address used to derive g_d_old and pk_d_old is the recipient address of the note being spent. 2022-02-15 14:39:32 -07:00
Kris Nuttycombe 00deb330e6 Fix pprof version. 2022-02-15 14:39:32 -07:00