Commit Graph

835 Commits

Author SHA1 Message Date
Kris Nuttycombe 082c8de59c Add kdf_personalized to OrchardDomain 2023-06-16 17:30:32 -06:00
Kris Nuttycombe 2a4f27c937 Update `zcash_note_encryption` to remove unused arguments from parse_note_plaintext_without_memo_ovk. 2023-05-26 09:28:01 -06:00
Kris Nuttycombe 729def6c60
Merge pull request #394 from zcash/note-encryption-avoid-redundant-checks
Remove redundant checks during note encryption
2023-05-26 09:13:20 -06:00
Kris Nuttycombe 6cf6f15bf1 Update the `incrementalmerkletree` and `bridgetree` patch versions.
This also removes the `bridgetree` transitive dependency when building
using the `test-dependencies` feature flag, as the only use of it can be
satisfied just with `incrementalmerkletree`.
2023-05-24 15:36:25 -06:00
Jack Grigg 90e64cbac0 Remove redundant checks during note encryption
The consistency check between `esk` and `ephemeral_key` is checked
inside `zcash_note_encryption::try_output_recovery_with_ock`, and the
requirement to check it inside the `Domain` implementation is being
lifted in zcash/librustzcash#848.

Removing the check here improves performance, both because we avoid an
extra scalar multiplication from `esk.derive_public()`, and because we
avoid an unnecessary `spec::diversify_hash()` call which is expensive
for Orchard.
2023-05-19 16:43:17 +00:00
Kris Nuttycombe 8bc53ecbde Update to development versions of incrementalmerkletree/bridgetree
This modifies the tests where required to use bridgetree checkpoint
identifiers.
2023-04-11 10:33:25 -06:00
Jack Grigg a65018f93c Fix variable name in `spec::diversify_hash`
Closes zcash/orchard#368.
2023-04-11 00:23:33 +00:00
Kris Nuttycombe dca33119b4 Migrate to zcash_note_encryption 0.3.0 2023-03-21 10:48:47 -06:00
Kris Nuttycombe e9a2de7d97 Fix `cargo doc` complaints. 2023-03-10 14:26:07 -07:00
Kris Nuttycombe cf526f59e2 Fix clippy beta lints that are applicable given an MSRV of 1.60 2023-03-10 14:23:06 -07:00
Jack Grigg 3beea4adb7 Migrate to `ff 0.13`
Closes zcash/orchard#371.
2023-03-09 21:14:41 +00:00
Jack Grigg 0f123ca707 Bump MSRV to 1.60 2023-03-09 21:14:41 +00:00
Kris Nuttycombe e2bfd99454
Merge pull request #365 from zingolabs/add_spends_and_outputs_getters_to_builder
Add spends/outputs getter fns to builders for use in change calculation
2023-01-03 14:57:06 -07:00
Gygaxis Vainhardt b64d6ba01e
Update src/builder.rs
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2023-01-03 17:34:28 -04:00
Dimitris Apostolou 1f13327479
Fix typo 2022-12-31 13:19:43 +02:00
Gygaxis Vainhardt cd8a39bd0c
Format comments
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2022-12-09 13:38:06 -04:00
Hazel OHearn 13d0d5592c
Add spends/outputs getter fns to builders for use in change calculation 2022-12-09 13:37:26 -04:00
Hazel OHearn e466d7b523
Add Display and Error impls for error types 2022-12-08 16:58:30 -04:00
Gygaxis Vainhardt 4296860a86
Partially apply suggestions from code review
Co-authored-by: str4d <thestr4d@gmail.com>
2022-12-08 16:36:54 -04:00
Gygaxis Vainhardt 938b122814
Replace type alias with zero-size struct
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-12-08 16:35:49 -04:00
Hazel OHearn 6e8e2734e1
Error -> BuildError, add PartialEq, Eq to SpendError 2022-12-01 17:01:10 -04:00
Hazel OHearn 8c2326cdac
Error -> BuildError 2022-12-01 16:58:26 -04:00
Hazel OHearn 4f27b6bac3
Add concrete error types for add_spend and add_output 2022-12-01 16:51:04 -04:00
Kris Nuttycombe d05b6cee9d
Merge pull request #362 from zcash/batch-scanner-improvements
Batch scanner improvements
2022-10-20 09:30:49 -06:00
Daira Hopwood a3af4095ae Add more thorough documentation for `ValueCommitmentTrapdoor::from_bytes`.
Also add a CHANGELOG entry for orchard::value::{ValueCommitmentTrapdoor, ValueCommitment::derive}.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-10-18 20:45:54 +01:00
Tomas Krnak d428aa3143 Add `ValueCommitTrapdoor::from_bytes` constructor 2022-10-18 20:36:55 +01:00
Daira Hopwood 591c4b89b9
Merge pull request #351 from jarys/pub-value-commit-derive
Publicize `ValueCommitment::derive` constructor
2022-10-18 20:19:19 +01:00
Kris Nuttycombe 4c9b2096dc Fix beta clippy complaints. 2022-10-18 12:47:18 -06:00
Kris Nuttycombe 7080c37532 Prepare keys only once in decrypt_outputs_with_keys 2022-10-18 12:47:18 -06:00
Daira Hopwood 786d285987 Fix a clippy lint.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-10-18 19:17:15 +01:00
Daira Hopwood b988d4c275
Fix comment that incorrectly referred to Sapling when Orchard was meant 2022-10-18 02:45:24 +01:00
Jack Grigg 050b2f231e Add `memuse::DynamicUsage` impls for types used for batch scanning 2022-10-15 23:29:06 +00:00
Jack Grigg 0b4d7bc9c6 Migrate note encryption to use prepared w-NAF APIs 2022-10-15 23:27:57 +00:00
Kris Nuttycombe 33bce9b567
Merge pull request #359 from daira/add-value-balance-to-builder-docfix
Correct the doc comment and add a test for `Builder::value_balance`
2022-10-10 13:36:35 -06:00
Tomas Krnak 5fbbded49e Add `SpendInfo::new` and `Circuit::from_action_context`
Author: Tomas Krnak <tomas@krnak.cz>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-09-20 18:52:07 +01:00
Daira Hopwood 47004ee87a
Use math notation for ValueCommit^Orchard 2022-09-19 14:49:16 +01:00
Daira Hopwood 6458e27185 Add minimal test that `Builder::value_balance` works.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-09-19 14:05:46 +01:00
Daira Hopwood fbfc8f9ed8 Correct the doc comment for the `Builder::value_balance` method added in #352.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-09-19 14:05:46 +01:00
Daira Hopwood f206b3f5d4
Merge pull request #352 from zingolabs/add_value_balance_to_builder
add value_balance to builder
2022-09-19 13:20:17 +01:00
Hazel OHearn 8011e0d57a
add value_balance to builder 2022-09-15 16:47:54 -03:00
Kris Nuttycombe 4b83deb240
Merge branch 'main' into add-proof-to-batch 2022-09-15 12:41:02 -06:00
Kris Nuttycombe b81d0d1198
Merge pull request #344 from zingolabs/publicize_note_and_diversifier_construction
Publicize necessary functionality for creating diversifiers and notes from data
2022-09-15 12:39:56 -06:00
Hazel OHearn 0800d23fe7
Publicize diversifier method of Address, fix comments, etc 2022-09-15 14:40:21 -03:00
Daira Hopwood 2ff7ff4a54 Dummy implementation of Domain methods for prepared ivk and epk.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-09-15 03:33:04 +01:00
Tomas Krnak 158f3e6e71 Publicize `ValueCommitment::derive` constructor 2022-08-13 15:35:01 +02:00
Hazel OHearn 22e7ba14a2
Add random_seed getter fn 2022-07-07 11:05:07 -03:00
Hazel OHearn 45bcc16f80
Publicize necessary functionality for reading diversifiers and notes from data 2022-07-05 14:55:44 -03:00
Jack Grigg 63fc2adc0e Expose `Proof::add_to_batch` in public API
This supports downstream users that want more control over how proof
batches are processed, instead of just batch validating Orchard bundles
with `orchard::bundle::BatchValidator`.
2022-07-04 20:05:47 +00:00
str4d baabe3d7e2
Merge pull request #340 from zingolabs/enable_compact_action_and_orchard_domain_creation_without_action
Add OrchardDomain::for_nullifier and CompactAction::from_parts
2022-06-24 16:32:34 +01:00
Jack Grigg e76a91adff Document how to obtain inputs for `Builder::add_spend`
Closes zcash/orchard#244.
2022-06-23 22:51:05 +00:00