Commit Graph

818 Commits

Author SHA1 Message Date
Jack Grigg 5a346fa145 pprof 0.5 2021-09-13 17:55:30 +01:00
Jack Grigg 9fcab699ef fpe 0.5 2021-09-13 17:54:56 +01:00
str4d 02804384a1
Merge pull request #185 from zcash/book-sinsemilla-degree
[book] sinsemilla.md: Correct constraint degrees.
2021-09-07 14:21:19 +01:00
Jack Grigg 3d7649c5b9 book: Move Sinsemilla constraints table to bottom of page
This moves it below the rationale for the lookup being degree-6.
2021-09-07 14:20:03 +01:00
Daira Hopwood ee44d2ccf0
Apply suggestions from code review 2021-09-07 02:45:10 +01:00
Daira Hopwood cc0ac1a744 note_commit.md: make the descriptions of range checks for k_0 and k_2 consistent with other short range checks.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 02:39:46 +01:00
Daira Hopwood 462550a26b note_commit.md: fix typo.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 02:26:40 +01:00
Daira Hopwood 030c7d1e30 note-commit.md: non-cosmetic improvements (summary, gate names, region layout for y constraints).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 01:45:12 +01:00
Daira Hopwood c1dc97477e note-commit.md: cosmetics and line wrapping.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 01:41:16 +01:00
Daira Hopwood 97e18a8190
Apply suggestions from code review 2021-09-07 00:56:22 +01:00
Daira Hopwood faddaf9e30 note_commit.rs: make two_pow_* definitions more consistent.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 00:52:37 +01:00
str4d 52a19279df
Merge pull request #196 from zcash/ff-0.11
ff 0.11, group 0.11, pasta_curves 0.2 etc.
2021-09-06 21:29:46 +01:00
Jack Grigg 8c82ceecbf ff 0.11, group 0.11, pasta_curves 0.2 etc. 2021-09-06 20:39:43 +01:00
str4d f1e95fabfa
Merge pull request #194 from zcash/memuse
Switch to `memuse` crate for measuring heap allocations
2021-09-06 19:45:13 +01:00
Jack Grigg 7fad21e7d6 Switch to `memuse` crate for measuring heap allocations 2021-09-05 01:33:27 +01:00
Daira Hopwood 4c25e3c99d note-commit.md: fix an erroneous constraint.
See https://github.com/zcash/orchard/pull/169/files#r700990376 .

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-02 12:23:48 +01:00
Daira Hopwood 9fcbe5dc1b note-commit.md: missing h_0 in a layout diagram.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-01 17:27:00 +01:00
Daira Hopwood 14081efe9b note-commit.md: formatting fix.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-01 15:57:10 +01:00
Daira Hopwood c24c67d5f0 cargo fmt
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-01 14:11:08 +01:00
Kris Nuttycombe bd2a7c2e79
Merge pull request #149 from zcash/zip32
ZIP32 key derivation
2021-08-31 17:14:21 -06:00
Kris Nuttycombe e4a54cdf61 Improve error handling in zip32 APIs. 2021-08-31 16:49:58 -06:00
therealyingtong c3e24794f0 zip32.rs: master and child key derivation for ExtendedSpendingKey 2021-08-31 15:49:32 -06:00
Kris Nuttycombe d50844f146
Merge pull request #170 from nuttycom/keys_ffi_ops
Add serialization and parsing for Orchard keys.
2021-08-31 15:40:25 -06:00
Kris Nuttycombe 77be355912 Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: ying tong <yingtong@z.cash>
2021-08-23 11:29:07 -06:00
Kris Nuttycombe 0449edd5b8 Validate the sign of the y-coordinate for ak when deserializing. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe 43abadfb55 Adds decryption for a specific index within a bundle. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe c406461f64 Expose inner representation of NoteValue 2021-08-23 11:29:07 -06:00
Kris Nuttycombe 872f337811 Expose SpendingKey byte representation. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe c803114bf6 Go ahead and clone IVKs to limit borrowing hassles. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe d8bf892c72 Return key used to decrypt an output along with decrypted note contents. 2021-08-23 11:29:07 -06:00
Kris Nuttycombe 5d78ab3508 Add Eq and Ord implementations for Orchard keys. 2021-08-23 11:29:06 -06:00
Kris Nuttycombe 52f0f158ef Add serialization and parsing of full viewing keys. 2021-08-23 11:28:27 -06:00
Kris Nuttycombe 1fd00e6236 Add raw address serialization and parsing. 2021-08-23 11:28:27 -06:00
Kris Nuttycombe e33cd4ade4 Add trial decryption of actions to Bundle 2021-08-23 11:28:25 -06:00
Kris Nuttycombe 77cf4c9831 Implement IncomingViewingKey::to_bytes 2021-08-23 11:27:02 -06:00
str4d f2400baa01
Improve NoteCommit input value gate doc
Brings it in line with the other gate docs.

Co-authored-by: ying tong <yingtong@z.cash>
2021-08-19 14:35:56 +01:00
str4d bac22d9b19
clippy: Remove redundant clones
Co-authored-by: ying tong <yingtong@z.cash>
2021-08-19 14:34:15 +01:00
str4d ac900148ed
Fix typo in gate documentation
Co-authored-by: ying tong <yingtong@z.cash>
2021-08-19 14:33:52 +01:00
str4d b4a82211ce
Merge pull request #184 from zcash/poseidon-domain-spec
poseidon::Domain: Remove Spec trait bound.
2021-08-17 12:55:01 +01:00
therealyingtong 4082ee615f [book] sinsemilla.md: Correct constraint degrees.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-08-17 00:07:30 +08:00
str4d cb28e00ebd
Merge pull request #178 from zcash/batch-note-decryption
Speed up batched note decryption
2021-08-13 14:27:41 +01:00
Jack Grigg 79988a5317 Move the interpolation logic into `SharedSecret::batch_to_affine`
This makes the method interface clearer, as the same pattern of shared
secrets is returned as was provided.
2021-08-13 14:27:20 +01:00
str4d 63ca0aaf32
Merge pull request #181 from zcash/sinsemilla-moar-speed
More Sinsemilla optimisations
2021-08-13 14:27:02 +01:00
therealyingtong 1f852544cf poseidon::Domain: Remove Spec trait bound.
The methods in the Domain trait are not generic over Spec.
2021-08-13 14:47:02 +08:00
therealyingtong a72d4d3a7f [book] note-commit.md: Update field element regions. 2021-08-13 12:22:51 +08:00
str4d 4e33fe7aec Use correct symbol for incomplete addition
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-08-12 21:34:35 +01:00
str4d 459e68b71e
Fix clippy lint
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-08-12 21:32:14 +01:00
therealyingtong 8d7bf509f2 [book] note-commit.md: Update message piece decomposition gates. 2021-08-13 01:19:30 +08:00
Jack Grigg 9f3c9a7e60 Use mixed addition for Sinsemilla bases
Performance improvements:
- MerkleCRH:  ~5%
- Commit^ivk: ~1%
- NoteCommit: ~3%
2021-08-12 15:45:00 +01:00
Jack Grigg 6197a0ef62 Use `group::Wnaf` to accelerate `sinsemilla::CommitDomain::commit`
Performance improvements:
- Commit^ivk: ~31%
- NoteCommit: ~22%
2021-08-12 15:45:00 +01:00