Jack Grigg
1a1c3c30b0
book: Finish incomplete sentence on nullifier page
...
Closes zcash/orchard#195 .
2022-06-23 22:46:45 +00:00
Jack Grigg
07239e50a8
Add protocol rule links for the Orchard circuit constraints
...
Part of zcash/zcash#3957 .
2022-05-25 22:10:29 +00:00
Jack Grigg
2fc9dc814d
book: Fix TODOs on Actions design page
...
Closes zcash/orchard#78 .
2022-04-29 18:04:01 +00:00
str4d
5e98c7d54c
Merge pull request #277 from zcash/book-delete-gadgets
...
[book] Remove gadgets documentation.
2022-04-28 17:41:04 +01:00
therealyingtong
e130643508
[book] Remove gadgets documentation.
...
The book now instead references the Halo 2 book for relevant circuit
documentation.
2022-04-28 16:27:43 +00:00
Dimitris Apostolou
b96533a2b8
Fix typos
2022-02-18 23:31:27 +02:00
therealyingtong
e0a0a0d509
book: Introduce RangeCheck macro.
2021-11-30 09:30:43 -05:00
therealyingtong
303bdc3f65
Replace local bool_check expressions with utilities::bool_check().
2021-11-29 21:45:48 -05:00
Jack Grigg
1a05398c30
book: Update rotations for Commit^ivk region
...
Matches the change made in zcash/orchard#169 .
2021-09-14 02:09:14 +01:00
str4d
9705ebf353
Merge pull request #182 from zcash/book-notecommit-optimisations
...
[book] Document NoteCommit region optimisations
2021-09-14 02:00:49 +01:00
Jack Grigg
3d7649c5b9
book: Move Sinsemilla constraints table to bottom of page
...
This moves it below the rationale for the lookup being degree-6.
2021-09-07 14:20:03 +01:00
Daira Hopwood
cc0ac1a744
note_commit.md: make the descriptions of range checks for k_0 and k_2 consistent with other short range checks.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 02:39:46 +01:00
Daira Hopwood
462550a26b
note_commit.md: fix typo.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 02:26:40 +01:00
Daira Hopwood
030c7d1e30
note-commit.md: non-cosmetic improvements (summary, gate names, region layout for y constraints).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 01:45:12 +01:00
Daira Hopwood
c1dc97477e
note-commit.md: cosmetics and line wrapping.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-07 01:41:16 +01:00
Daira Hopwood
4c25e3c99d
note-commit.md: fix an erroneous constraint.
...
See https://github.com/zcash/orchard/pull/169/files#r700990376 .
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-02 12:23:48 +01:00
Daira Hopwood
9fcbe5dc1b
note-commit.md: missing h_0 in a layout diagram.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-01 17:27:00 +01:00
Daira Hopwood
14081efe9b
note-commit.md: formatting fix.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-01 15:57:10 +01:00
therealyingtong
4082ee615f
[book] sinsemilla.md: Correct constraint degrees.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-08-17 00:07:30 +08:00
therealyingtong
a72d4d3a7f
[book] note-commit.md: Update field element regions.
2021-08-13 12:22:51 +08:00
therealyingtong
8d7bf509f2
[book] note-commit.md: Update message piece decomposition gates.
2021-08-13 01:19:30 +08:00
Daira Hopwood
b2e25b5ac3
[book] decomposition.md: avoid introducing `m` when we already have `range`.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 17:06:36 +01:00
ying tong
ee878ddc57
Merge pull request #162 from zcash/book-merge-lookups
...
[book] Merge lookup arguments for normal and short variants
2021-07-27 23:34:28 +08:00
ying tong
0bb4a7fd71
[book] decomposition.md: Formatting and phrasing fixes.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-27 23:29:11 +08:00
therealyingtong
ac5404a943
[book] note-commit.md: Update NoteCommit gate region layout.
...
By rearranging the pieces in the gate, we remove a prev() query and
preserve proximity between pieces involved in the same constraint.
2021-07-27 13:56:10 +08:00
therealyingtong
920fe64399
[book] note-commit.md: Document substitution of k_1 with z1_j.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-27 12:53:41 +08:00
Jack Grigg
9ef46ae4ee
book: Fixes to NoteCommit page
...
Noticed during review.
2021-07-27 05:34:36 +01:00
therealyingtong
65ff84da0a
[book] decomposition.md: Merge lookup arguments for normal and short variants.
2021-07-27 11:56:18 +08:00
Daira Hopwood
a6badba32f
[book] src/design/circuit/gadgets/ecc/var-base-scalar-mul.md: we always do addition (possibly of the zero point) at the end of variable-base scalar mul.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 02:01:21 +01:00
Daira Hopwood
7895a2a082
[book] src/design/circuit/gadgets/ecc/var-base-scalar-mul.md: more formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 02:01:05 +01:00
Daira Hopwood
3dfefe0e85
[book] src/design/circuit/gadgets/ecc/addition.md: correctness and clarity.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 01:51:37 +01:00
Daira Hopwood
3ed388e6bb
[book] src/design/circuit/gadgets/ecc/addition.md: formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 01:51:28 +01:00
therealyingtong
f1ccc58d9a
[book] note-commit.md: y-coordinate canonicity constraints.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 01:56:17 +08:00
ying tong
3833d665de
[book] Clarify upper bounds in canonicity shift constraints.
2021-07-26 12:05:25 +08:00
ying tong
14b8d9b048
[book] note-commit.md: 2^140 -> 2^130 in psi check.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-26 11:12:42 +08:00
ying tong
453681f309
[book] commit-ivk.md: Update region layout to use 9 advice columns.
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-26 11:09:47 +08:00
Jack Grigg
0375c64801
[book] Update NoteCommit page to match Commit^ivk style
...
Constraint tables have been added along with the region layout. I also
fixed numerous bugs in the constraints (most of which appeared to be
copy-pasta bugs).
2021-07-26 02:05:35 +01:00
Jack Grigg
5aa05713e7
[book] Use \CommitIvk macro in page heading
...
We can't use KaTeX on the SUMMARY page that generates the sidebar, so
that continues to use a CamelCase approximation.
2021-07-26 02:05:35 +01:00
Jack Grigg
f376a61bb8
[book] Add macros, constraint tables, and region layout to Commit^ivk
...
I also merged in content from a page I wrote independently while
reviewing the Action circuit PR, and made various cleanups to the
Markdown source.
2021-07-26 02:05:35 +01:00
Daira Hopwood
4a5a4cc437
[book] merkle-crh.md: formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-26 02:05:35 +01:00
Daira Hopwood
ed20d539b2
[book] merkle-crh.md: corrections.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-26 02:05:35 +01:00
Daira Hopwood
47a29f10aa
[book] Document NoteCommit message decomposition & canonicity checks
2021-07-26 02:05:35 +01:00
Daira Hopwood
2846593937
[book] Document CommitIvk message decomposition & canonicity checks
2021-07-26 02:05:35 +01:00
Daira Hopwood
9708e296c8
[book] Document Merkle chip layout and message decomposition.
2021-07-26 02:05:35 +01:00
therealyingtong
5dc5e6479a
[book] Recombine Sinsemilla q_S1, q_S2, q_S3 selectors.
...
Since q_S1, q_S2, q_S3 are not simple selectors, they cannot be
automatically combined. We manually combine them here.
2021-07-25 20:28:05 +08:00
ying tong
a2ed3f1b52
Merge pull request #155 from zcash/book-selector-optimisations
...
[Book] Undo selector optimisations
2021-07-25 00:57:35 +08:00
ying tong
3d56fb0716
Merge pull request #146 from zcash/book-short-scalar-mul
...
[book] Update constraints for short signed fixed-base mul.
2021-07-25 00:54:32 +08:00
therealyingtong
782a70a786
[book] Minor fixes.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-25 00:52:38 +08:00
ying tong
ce881bc4fe
[book] Formatting fix.
2021-07-25 00:40:44 +08:00
therealyingtong
78b0ec4e7b
[book] Sinsemilla: reintroduce fixed_y_q column.
...
Loading fixed_y_q into an advice column introduces an additional
row. Instead, we load it into a fixed column.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-24 23:15:17 +08:00