4e3e469780
Update incrementalmerkletree dependency version.
2022-05-04 08:01:02 -06:00
200c366ea4
Rename `Bundle::{try_}authorize` to `Bundle::{try_}map_authorization`
...
Closes zcash/orchard#71 .
2022-04-29 00:16:16 +00:00
5c5c999439
Move `orchard::bundle::Action` to its own module
...
The `Bundle` struct is variable in size and requires allocations, but
`Action` is not. This split will make it cleaner to disable the bundle
logic for no-std support.
2022-04-28 22:59:07 +00:00
4ec036c851
Remove unnecessary usage of `Vec`
2022-04-28 21:26:23 +00:00
30f9452743
Replace unnecessary usage of `std::io`
2022-04-28 20:45:05 +00:00
b1ce38405a
Use `core` instead of `std` where possible
2022-04-28 20:20:23 +00:00
52449ef88f
Migrate to `halo2::plonk::Constraints` helper
2022-04-28 19:52:55 +00:00
4574d4793a
Migrate to 2021 edition
2022-04-28 17:23:30 +00:00
3b52b2abec
Minor cleanup found while performing review for zcash/zcash#5024
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-04-14 08:29:00 -06:00
06995064d7
incrementalmerkletree 0.3.0-beta.2
2022-04-06 18:19:39 +00:00
2c0aed712a
Merge pull request #308 from zcash/improve-debug-impls
...
Improve `Debug` impls
2022-04-06 18:59:33 +01:00
7c2cc814de
Merge pull request #288 from rex4539/typos
...
Fix typos
2022-04-06 18:23:17 +01:00
01d70ec875
Hide `NonEmpty` in `Debug` impl of `Bundle`
...
It is an implementation detail that isn't useful to include in the debug
output.
2022-04-06 17:22:18 +00:00
caca664b20
Make `Debug` impl for `TransmittedNoteCiphertext` less verbose
...
We now print the ciphertexts as hex bytes, for which we unambiguously
encode them in RPC outputs (vs 32-byte values which are more complex).
2022-04-06 17:22:17 +00:00
6941fe1109
Make `Debug` impl for `Proof` much less verbose
...
For the default `{:?}` debug formatting we now only print the length of
the proof, while `{#?}` continues to print the full byte vector.
2022-04-06 17:21:48 +00:00
eaa0cfdbf6
Check that the internal IVK can be derived from a spending key
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-30 20:49:38 +08:00
e550c3d536
Check IVK derivations during FullViewingKey::from_bytes.
...
Closes zcash/orchard#303
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-30 20:49:38 +08:00
a0424984c6
Add explicit scoping for viewing keys and addresses
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-30 20:49:37 +08:00
56a946dafc
halo2_proofs 0.1.0-beta.3
...
The change to the pinned circuit description is due to removing the
unnecessary `selector_map` pin in zcash/halo2#521 . This invalidates
previous proofs due to changing Fiat-Shamir transcript initialization).
2022-03-22 21:29:36 +00:00
d6d1dbea14
Update serialized proof test case for circuit changes
2022-03-22 17:59:56 +00:00
6c9ff19342
Merge branch 'main' into non-consensus-changes-on-branchid-c4cd541e
2022-03-22 17:55:59 +00:00
72b6febf7b
Move zero-handling from inside CommitIVK to outside it
...
This more closely matches the change to the protocol spec.
2022-03-17 18:51:33 +00:00
795fb78d2d
Add serialized proof test case
...
Co-authored-by: Sean Bowe <ewillbefull@gmail.com>
2022-03-16 19:47:00 +00:00
5356804bfe
Update comment in `spec::commit_ivk`
2022-03-15 23:26:57 +00:00
72f1ca6b45
spec.rs: Check that commit_ivk returns a nonzero base.
2022-03-16 01:28:13 +08:00
40efd57757
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-03-15 07:47:21 -06:00
45a6a30b21
Add convenience methods on `Bundle` to decrypt actions with OVKs.
...
This renames `decrypt_outputs_for_keys` to `decrypt_outputs_with_keys`
for consistency with `decrypt_output_with_key` and tne newly added
`recover_output*_with_ovk*` methods.
2022-03-14 19:28:47 -06:00
eb7a9668aa
Merge branch 'non-consensus-changes-on-branchid-c4cd541e' into merge-non-consensus-changes-2
2022-02-28 20:46:55 +00:00
def4d4d9ae
Add missing `Debug` trait bounds for `Builder` components
...
All relevant types have `Debug` impls, but some of the trait and method
impls were lacking `Debug` bounds on their generic types. This prevented
`Debug` impls being used on the overall partially-constructed `Bundle`
types.
2022-02-28 20:09:30 +00:00
273662c00b
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-02-24 09:16:39 -07:00
1cf828fe7b
Update the incremental merkle tree version and the Rust toolchain.
...
Use derived equality and ordering (which delegate to constant-time
versions) for note::nullifier::Nullifier and tree::MerkleHashOrchard
so that these types can be used as map keys in wallets.
2022-02-23 20:43:02 -07:00
65f3e6ec32
Add `FullViewingKey::derive_internal`
...
This is identical to the changes introduced in zcash/orchard#270 , except
that the output is non-optional (since the derivation is non-fallible).
2022-02-21 14:41:47 +00:00
b96533a2b8
Fix typos
2022-02-18 23:31:27 +02:00
28c22718c0
Remove `hash_bundle_txid_data, hash_bundle_auth_data` from API
2022-02-15 23:03:02 +00:00
b1d7787ab6
Re-introduce `ValueSum::from_raw` as a `pub(crate)` method
...
We removed this in zcash/orchard#267 as it did not need to be part of
the public API, but we do still need a way to convert the user-defined
valueBalance type into a `ValueSum` when constructing `bvk`, and this
method is preferable to exposing the `ValueSum` internals.
2022-02-15 22:47:05 +00:00
17ad25ee35
Merge branch 'non-consensus-changes-on-branchid-c4cd541e' into merge-non-consensus-changes
2022-02-15 22:46:47 +00:00
62da82bd38
Add functional test for creating and verifying a shielded bundle
...
The text exposed some limitations of the current crate API, which have
been fixed.
2022-02-15 22:17:15 +00:00
0b6bd07904
Add functional test for creating and verifying a shielding bundle
...
The text exposed some limitations of the current crate API, which have
been fixed.
2022-02-15 22:17:15 +00:00
e92d1167af
The address used to derive g_d_old and pk_d_old is the recipient address of the note being spent.
2022-02-15 14:39:32 -07:00
5d5e289197
Remove default_diversifier and default_address methods.
2022-02-15 14:39:32 -07:00
4c7ab377fb
Make the DiversifierKey type crate-private
2022-02-14 17:04:38 -07:00
ae3cc78a56
Add decryption of the diversifier index for an address to the IVK.
...
Also correct a spelling error.
2022-02-14 17:04:38 -07:00
4ae32ef98a
Merge pull request #282 from zcash/clone-unauthorized-bundle
...
Add `Clone` impls to various structs
2022-02-12 03:23:11 +00:00
c4cd541e6c
Add `Clone` impls to various structs
...
This enables `InProgress<Unproven, Unauthorized>: Clone`, which allows
the bundle returned by `Builder::build` to be cloned. In pure-Rust
wallets this should not be necessary, but it is required for `zcashd`
due to FFI-crossing.
2022-02-12 02:04:52 +00:00
b7f66b48e6
Merge pull request #280 from nuttycom/decrypt_diversifier
...
Add diversifier index decryption to DiversifierKey
2022-02-11 14:51:54 -07:00
8c96640826
Add diversifier index decryption to DiversifierKey.
2022-02-11 14:09:07 -07:00
c1447d6af2
Fix broken main branch
...
This was a non-code merge conflict between zcash/halo2#217 and main,
that caused CI to break after the PR merged.
2022-02-08 15:19:56 +00:00
ce301a6aa3
Shuffle spends and recipients before pairing them into Actions
...
Callers cannot assume that any specific output corresponds to a specific
Orchard recipient, and must trial-decrypt all outputs to find the ones
belonging to them. This is consistent with higher-layer semantics like
having Unified Addresses as recipients (where the mapping from recipient
to a specific output would become much more complex).
Closes zcash/orchard#203 .
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-07 22:37:37 +00:00
40491385c6
Merge pull request #217 from zcash/update-halo2-gadgets
...
Delete gadgets and introduce halo2_gadgets dependency.
2022-02-03 21:23:42 +00:00
91e22e4f92
Use internal keys test vectors.
2022-02-01 18:55:21 +08:00
Kris Nuttycombe
Jack Grigg
Daira Hopwood
therealyingtong
Kris Nuttycombe
Dimitris Apostolou