//! Gadgets for elliptic curve operations. use std::fmt::Debug; use halo2::{ arithmetic::CurveAffine, circuit::{Chip, Layouter}, plonk::Error, }; use crate::circuit::gadget::utilities::UtilitiesInstructions; pub mod chip; /// The set of circuit instructions required to use the ECC gadgets. pub trait EccInstructions: Chip + UtilitiesInstructions { /// Variable representing an element of the elliptic curve's base field, that /// is used as a scalar in variable-base scalar mul. /// /// It is not true in general that a scalar field element fits in a curve's /// base field, and in particular it is untrue for the Pallas curve, whose /// scalar field `Fq` is larger than its base field `Fp`. /// /// However, the only use of variable-base scalar mul in the Orchard protocol /// is in deriving diversified addresses `[ivk] g_d`, and `ivk` is guaranteed /// to be in the base field of the curve. (See non-normative notes in /// https://zips.z.cash/protocol/nu5.pdf#orchardkeycomponents.) type ScalarVar: Clone + Debug; /// Variable representing a full-width element of the elliptic curve's /// scalar field, to be used for fixed-base scalar mul. type ScalarFixed: Clone + Debug; /// Variable representing a signed short element of the elliptic curve's /// scalar field, to be used for fixed-base scalar mul. /// /// A `ScalarFixedShort` must be in the range [-(2^64 - 1), 2^64 - 1]. type ScalarFixedShort: Clone + Debug; /// Variable representing an elliptic curve point. type Point: From + Clone + Debug; /// Variable representing a non-identity elliptic curve point. type NonIdentityPoint: Clone + Debug; /// Variable representing the affine short Weierstrass x-coordinate of an /// elliptic curve point. type X: Clone + Debug; /// Enumeration of the set of fixed bases to be used in scalar mul with a full-width scalar. type FixedPoints: Clone + Debug; /// Enumeration of the set of fixed bases to be used in scalar mul with a base field element. type FixedPointsBaseField: Clone + Debug; /// Enumeration of the set of fixed bases to be used in short signed scalar mul. type FixedPointsShort: Clone + Debug; /// Constrains point `a` to be equal in value to point `b`. fn constrain_equal( &self, layouter: &mut impl Layouter, a: &Self::Point, b: &Self::Point, ) -> Result<(), Error>; /// Witnesses the given point as a private input to the circuit. /// This allows the point to be the identity, mapped to (0, 0) in /// affine coordinates. fn witness_point( &self, layouter: &mut impl Layouter, value: Option, ) -> Result; /// Witnesses the given point as a private input to the circuit. /// This returns an error if the point is the identity. fn witness_point_non_id( &self, layouter: &mut impl Layouter, value: Option, ) -> Result; /// Extracts the x-coordinate of a point. fn extract_p + Clone>(point: &Point) -> Self::X; /// Performs incomplete point addition, returning `a + b`. /// /// This returns an error in exceptional cases. fn add_incomplete( &self, layouter: &mut impl Layouter, a: &Self::NonIdentityPoint, b: &Self::NonIdentityPoint, ) -> Result; /// Performs complete point addition, returning `a + b`. fn add + Clone, B: Into + Clone>( &self, layouter: &mut impl Layouter, a: &A, b: &B, ) -> Result; /// Performs variable-base scalar multiplication, returning `[scalar] base`. fn mul( &self, layouter: &mut impl Layouter, scalar: &Self::Var, base: &Self::NonIdentityPoint, ) -> Result<(Self::Point, Self::ScalarVar), Error>; /// Performs fixed-base scalar multiplication using a full-width scalar, returning `[scalar] base`. fn mul_fixed( &self, layouter: &mut impl Layouter, scalar: Option, base: &Self::FixedPoints, ) -> Result<(Self::Point, Self::ScalarFixed), Error>; /// Performs fixed-base scalar multiplication using a short signed scalar, returning /// `[magnitude * sign] base`. fn mul_fixed_short( &self, layouter: &mut impl Layouter, magnitude_sign: (Self::Var, Self::Var), base: &Self::FixedPointsShort, ) -> Result<(Self::Point, Self::ScalarFixedShort), Error>; /// Performs fixed-base scalar multiplication using a base field element as the scalar. /// In the current implementation, this base field element must be output from another /// instruction. fn mul_fixed_base_field_elem( &self, layouter: &mut impl Layouter, base_field_elem: Self::Var, base: &Self::FixedPointsBaseField, ) -> Result; } /// An element of the given elliptic curve's base field, that is used as a scalar /// in variable-base scalar mul. /// /// It is not true in general that a scalar field element fits in a curve's /// base field, and in particular it is untrue for the Pallas curve, whose /// scalar field `Fq` is larger than its base field `Fp`. /// /// However, the only use of variable-base scalar mul in the Orchard protocol /// is in deriving diversified addresses `[ivk] g_d`, and `ivk` is guaranteed /// to be in the base field of the curve. (See non-normative notes in /// https://zips.z.cash/protocol/nu5.pdf#orchardkeycomponents.) #[derive(Debug)] pub struct ScalarVar + Clone + Debug + Eq> { chip: EccChip, inner: EccChip::ScalarVar, } /// A full-width element of the given elliptic curve's scalar field, to be used for fixed-base scalar mul. #[derive(Debug)] pub struct ScalarFixed where EccChip: EccInstructions + Clone + Debug + Eq, { chip: EccChip, inner: EccChip::ScalarFixed, } /// A signed short element of the given elliptic curve's scalar field, to be used for fixed-base scalar mul. #[derive(Debug)] pub struct ScalarFixedShort where EccChip: EccInstructions + Clone + Debug + Eq, { chip: EccChip, inner: EccChip::ScalarFixedShort, } /// A non-identity elliptic curve point over the given curve. #[derive(Copy, Clone, Debug)] pub struct NonIdentityPoint + Clone + Debug + Eq> { chip: EccChip, inner: EccChip::NonIdentityPoint, } impl + Clone + Debug + Eq> NonIdentityPoint { /// Constructs a new point with the given value. pub fn new( chip: EccChip, mut layouter: impl Layouter, value: Option, ) -> Result { let point = chip.witness_point_non_id(&mut layouter, value); point.map(|inner| NonIdentityPoint { chip, inner }) } /// Constrains this point to be equal in value to another point. pub fn constrain_equal> + Clone>( &self, mut layouter: impl Layouter, other: &Other, ) -> Result<(), Error> { let other: Point = (other.clone()).into(); self.chip.constrain_equal( &mut layouter, &Point::::from(self.clone()).inner, &other.inner, ) } /// Returns the inner point. pub fn inner(&self) -> &EccChip::NonIdentityPoint { &self.inner } /// Extracts the x-coordinate of a point. pub fn extract_p(&self) -> X { X::from_inner(self.chip.clone(), EccChip::extract_p(&self.inner)) } /// Wraps the given point (obtained directly from an instruction) in a gadget. pub fn from_inner(chip: EccChip, inner: EccChip::NonIdentityPoint) -> Self { NonIdentityPoint { chip, inner } } /// Returns `self + other` using complete addition. pub fn add> + Clone>( &self, mut layouter: impl Layouter, other: &Other, ) -> Result, Error> { let other: Point = (other.clone()).into(); assert_eq!(self.chip, other.chip); self.chip .add(&mut layouter, &self.inner, &other.inner) .map(|inner| Point { chip: self.chip.clone(), inner, }) } /// Returns `self + other` using incomplete addition. /// The arguments are type-constrained not to be the identity point, /// and since exceptional cases return an Error, the result also cannot /// be the identity point. pub fn add_incomplete( &self, mut layouter: impl Layouter, other: &Self, ) -> Result { assert_eq!(self.chip, other.chip); self.chip .add_incomplete(&mut layouter, &self.inner, &other.inner) .map(|inner| NonIdentityPoint { chip: self.chip.clone(), inner, }) } /// Returns `[by] self`. #[allow(clippy::type_complexity)] pub fn mul( &self, mut layouter: impl Layouter, by: &EccChip::Var, ) -> Result<(Point, ScalarVar), Error> { self.chip .mul(&mut layouter, by, &self.inner.clone()) .map(|(point, scalar)| { ( Point { chip: self.chip.clone(), inner: point, }, ScalarVar { chip: self.chip.clone(), inner: scalar, }, ) }) } } impl + Clone + Debug + Eq> From> for Point { fn from(non_id_point: NonIdentityPoint) -> Self { Self { chip: non_id_point.chip, inner: non_id_point.inner.into(), } } } /// An elliptic curve point over the given curve. #[derive(Copy, Clone, Debug)] pub struct Point + Clone + Debug + Eq> { chip: EccChip, inner: EccChip::Point, } impl + Clone + Debug + Eq> Point { /// Constructs a new point with the given value. pub fn new( chip: EccChip, mut layouter: impl Layouter, value: Option, ) -> Result { let point = chip.witness_point(&mut layouter, value); point.map(|inner| Point { chip, inner }) } /// Constrains this point to be equal in value to another point. pub fn constrain_equal> + Clone>( &self, mut layouter: impl Layouter, other: &Other, ) -> Result<(), Error> { let other: Point = (other.clone()).into(); self.chip .constrain_equal(&mut layouter, &self.inner, &other.inner) } /// Returns the inner point. pub fn inner(&self) -> &EccChip::Point { &self.inner } /// Extracts the x-coordinate of a point. pub fn extract_p(&self) -> X { X::from_inner(self.chip.clone(), EccChip::extract_p(&self.inner)) } /// Wraps the given point (obtained directly from an instruction) in a gadget. pub fn from_inner(chip: EccChip, inner: EccChip::Point) -> Self { Point { chip, inner } } /// Returns `self + other` using complete addition. pub fn add> + Clone>( &self, mut layouter: impl Layouter, other: &Other, ) -> Result, Error> { let other: Point = (other.clone()).into(); assert_eq!(self.chip, other.chip); self.chip .add(&mut layouter, &self.inner, &other.inner) .map(|inner| Point { chip: self.chip.clone(), inner, }) } } /// The affine short Weierstrass x-coordinate of an elliptic curve point over the /// given curve. #[derive(Debug)] pub struct X + Clone + Debug + Eq> { chip: EccChip, inner: EccChip::X, } impl + Clone + Debug + Eq> X { /// Wraps the given x-coordinate (obtained directly from an instruction) in a gadget. pub fn from_inner(chip: EccChip, inner: EccChip::X) -> Self { X { chip, inner } } /// Returns the inner x-coordinate. pub fn inner(&self) -> &EccChip::X { &self.inner } } /// A constant elliptic curve point over the given curve, for which window tables have /// been provided to make scalar multiplication more efficient. /// /// Used in scalar multiplication with full-width scalars. #[derive(Clone, Debug)] pub struct FixedPoint where EccChip: EccInstructions + Clone + Debug + Eq, { chip: EccChip, inner: EccChip::FixedPoints, } impl FixedPoint where EccChip: EccInstructions + Clone + Debug + Eq, { #[allow(clippy::type_complexity)] /// Returns `[by] self`. pub fn mul( &self, mut layouter: impl Layouter, by: Option, ) -> Result<(Point, ScalarFixed), Error> { self.chip .mul_fixed(&mut layouter, by, &self.inner) .map(|(point, scalar)| { ( Point { chip: self.chip.clone(), inner: point, }, ScalarFixed { chip: self.chip.clone(), inner: scalar, }, ) }) } /// Wraps the given fixed base (obtained directly from an instruction) in a gadget. pub fn from_inner(chip: EccChip, inner: EccChip::FixedPoints) -> Self { FixedPoint { chip, inner } } } /// A constant elliptic curve point over the given curve, used in scalar multiplication /// with a base field element #[derive(Clone, Debug)] pub struct FixedPointBaseField where EccChip: EccInstructions + Clone + Debug + Eq, { chip: EccChip, inner: EccChip::FixedPointsBaseField, } impl FixedPointBaseField where EccChip: EccInstructions + Clone + Debug + Eq, { #[allow(clippy::type_complexity)] /// Returns `[by] self`. pub fn mul( &self, mut layouter: impl Layouter, by: EccChip::Var, ) -> Result, Error> { self.chip .mul_fixed_base_field_elem(&mut layouter, by, &self.inner) .map(|inner| Point { chip: self.chip.clone(), inner, }) } /// Wraps the given fixed base (obtained directly from an instruction) in a gadget. pub fn from_inner(chip: EccChip, inner: EccChip::FixedPointsBaseField) -> Self { FixedPointBaseField { chip, inner } } } /// A constant elliptic curve point over the given curve, used in scalar multiplication /// with a short signed exponent #[derive(Clone, Debug)] pub struct FixedPointShort where EccChip: EccInstructions + Clone + Debug + Eq, { chip: EccChip, inner: EccChip::FixedPointsShort, } impl FixedPointShort where EccChip: EccInstructions + Clone + Debug + Eq, { #[allow(clippy::type_complexity)] /// Returns `[by] self`. pub fn mul( &self, mut layouter: impl Layouter, magnitude_sign: (EccChip::Var, EccChip::Var), ) -> Result<(Point, ScalarFixedShort), Error> { self.chip .mul_fixed_short(&mut layouter, magnitude_sign, &self.inner) .map(|(point, scalar)| { ( Point { chip: self.chip.clone(), inner: point, }, ScalarFixedShort { chip: self.chip.clone(), inner: scalar, }, ) }) } /// Wraps the given fixed base (obtained directly from an instruction) in a gadget. pub fn from_inner(chip: EccChip, inner: EccChip::FixedPointsShort) -> Self { FixedPointShort { chip, inner } } } #[cfg(test)] mod tests { use group::{prime::PrimeCurveAffine, Curve, Group}; use halo2::{ circuit::{Layouter, SimpleFloorPlanner}, dev::MockProver, plonk::{Circuit, ConstraintSystem, Error}, }; use pasta_curves::pallas; use super::chip::{EccChip, EccConfig}; use crate::circuit::gadget::utilities::lookup_range_check::LookupRangeCheckConfig; struct MyCircuit {} #[allow(non_snake_case)] impl Circuit for MyCircuit { type Config = EccConfig; type FloorPlanner = SimpleFloorPlanner; fn without_witnesses(&self) -> Self { MyCircuit {} } fn configure(meta: &mut ConstraintSystem) -> Self::Config { let advices = [ meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), meta.advice_column(), ]; let lookup_table = meta.lookup_table_column(); let lagrange_coeffs = [ meta.fixed_column(), meta.fixed_column(), meta.fixed_column(), meta.fixed_column(), meta.fixed_column(), meta.fixed_column(), meta.fixed_column(), meta.fixed_column(), ]; // Shared fixed column for loading constants let constants = meta.fixed_column(); meta.enable_constant(constants); let range_check = LookupRangeCheckConfig::configure(meta, advices[9], lookup_table); EccChip::configure(meta, advices, lagrange_coeffs, range_check) } fn synthesize( &self, config: Self::Config, mut layouter: impl Layouter, ) -> Result<(), Error> { let chip = EccChip::construct(config.clone()); // Load 10-bit lookup table. In the Action circuit, this will be // provided by the Sinsemilla chip. config.lookup_config.load(&mut layouter)?; // Generate a random non-identity point P let p_val = pallas::Point::random(rand::rngs::OsRng).to_affine(); // P let p = super::NonIdentityPoint::new( chip.clone(), layouter.namespace(|| "P"), Some(p_val), )?; let p_neg = -p_val; let p_neg = super::NonIdentityPoint::new( chip.clone(), layouter.namespace(|| "-P"), Some(p_neg), )?; // Generate a random non-identity point Q let q_val = pallas::Point::random(rand::rngs::OsRng).to_affine(); // Q let q = super::NonIdentityPoint::new( chip.clone(), layouter.namespace(|| "Q"), Some(q_val), )?; // Make sure P and Q are not the same point. assert_ne!(p_val, q_val); // Test that we can witness the identity as a point, but not as a non-identity point. { let _ = super::Point::new( chip.clone(), layouter.namespace(|| "identity"), Some(pallas::Affine::identity()), )?; super::NonIdentityPoint::new( chip.clone(), layouter.namespace(|| "identity"), Some(pallas::Affine::identity()), ) .expect_err("Trying to witness the identity should return an error"); } // Test witness non-identity point { super::chip::witness_point::tests::test_witness_non_id( chip.clone(), layouter.namespace(|| "witness non-identity point"), ) } // Test complete addition { super::chip::add::tests::test_add( chip.clone(), layouter.namespace(|| "complete addition"), p_val, &p, q_val, &q, &p_neg, )?; } // Test incomplete addition { super::chip::add_incomplete::tests::test_add_incomplete( chip.clone(), layouter.namespace(|| "incomplete addition"), p_val, &p, q_val, &q, &p_neg, )?; } // Test variable-base scalar multiplication { super::chip::mul::tests::test_mul( chip.clone(), layouter.namespace(|| "variable-base scalar mul"), &p, p_val, )?; } // Test full-width fixed-base scalar multiplication { super::chip::mul_fixed::full_width::tests::test_mul_fixed( chip.clone(), layouter.namespace(|| "full-width fixed-base scalar mul"), )?; } // Test signed short fixed-base scalar multiplication { super::chip::mul_fixed::short::tests::test_mul_fixed_short( chip.clone(), layouter.namespace(|| "signed short fixed-base scalar mul"), )?; } // Test fixed-base scalar multiplication with a base field element { super::chip::mul_fixed::base_field_elem::tests::test_mul_fixed_base_field( chip, layouter.namespace(|| "fixed-base scalar mul with base field element"), )?; } Ok(()) } } #[test] fn ecc_chip() { let k = 13; let circuit = MyCircuit {}; let prover = MockProver::run(k, &circuit, vec![]).unwrap(); assert_eq!(prover.verify(), Ok(())) } #[cfg(feature = "dev-graph")] #[test] fn print_ecc_chip() { use plotters::prelude::*; let root = BitMapBackend::new("ecc-chip-layout.png", (1024, 7680)).into_drawing_area(); root.fill(&WHITE).unwrap(); let root = root.titled("Ecc Chip Layout", ("sans-serif", 60)).unwrap(); let circuit = MyCircuit {}; halo2::dev::CircuitLayout::default() .render(13, &circuit, &root) .unwrap(); } }