use std::ops::Deref; use super::super::{copy, CellValue, EccConfig, NonIdentityEccPoint, Var}; use super::{INCOMPLETE_HI_RANGE, INCOMPLETE_LO_RANGE, X, Y, Z}; use ff::Field; use halo2::{ circuit::Region, plonk::{Advice, Column, ConstraintSystem, Error, Expression, Selector, VirtualCells}, poly::Rotation, }; use pasta_curves::{arithmetic::FieldExt, pallas}; #[derive(Copy, Clone)] pub(super) struct Config { // Number of bits covered by this incomplete range. num_bits: usize, // Selectors used to constrain the cells used in incomplete addition. pub(super) q_mul: (Selector, Selector, Selector), // Cumulative sum used to decompose the scalar. pub(super) z: Column, // x-coordinate of the accumulator in each double-and-add iteration. pub(super) x_a: Column, // x-coordinate of the point being added in each double-and-add iteration. pub(super) x_p: Column, // y-coordinate of the point being added in each double-and-add iteration. pub(super) y_p: Column, // lambda1 in each double-and-add iteration. pub(super) lambda1: Column, // lambda2 in each double-and-add iteration. pub(super) lambda2: Column, } // Columns used in processing the `hi` bits of the scalar. // `x_p, y_p` are shared across the `hi` and `lo` halves. pub(super) struct HiConfig(Config); impl From<&EccConfig> for HiConfig { fn from(ecc_config: &EccConfig) -> Self { let config = Config { num_bits: INCOMPLETE_HI_RANGE.len(), q_mul: ecc_config.q_mul_hi, x_p: ecc_config.advices[0], y_p: ecc_config.advices[1], z: ecc_config.advices[9], x_a: ecc_config.advices[3], lambda1: ecc_config.advices[4], lambda2: ecc_config.advices[5], }; Self(config) } } impl Deref for HiConfig { type Target = Config; fn deref(&self) -> &Config { &self.0 } } // Columns used in processing the `lo` bits of the scalar. // `x_p, y_p` are shared across the `hi` and `lo` halves. pub(super) struct LoConfig(Config); impl From<&EccConfig> for LoConfig { fn from(ecc_config: &EccConfig) -> Self { let config = Config { num_bits: INCOMPLETE_LO_RANGE.len(), q_mul: ecc_config.q_mul_lo, x_p: ecc_config.advices[0], y_p: ecc_config.advices[1], z: ecc_config.advices[6], x_a: ecc_config.advices[7], lambda1: ecc_config.advices[8], lambda2: ecc_config.advices[2], }; Self(config) } } impl Deref for LoConfig { type Target = Config; fn deref(&self) -> &Config { &self.0 } } impl Config { // Gate for incomplete addition part of variable-base scalar multiplication. pub(super) fn create_gate(&self, meta: &mut ConstraintSystem) { // Closure to compute x_{R,i} = λ_{1,i}^2 - x_{A,i} - x_{P,i} let x_r = |meta: &mut VirtualCells, rotation: Rotation| { let x_a = meta.query_advice(self.x_a, rotation); let x_p = meta.query_advice(self.x_p, rotation); let lambda_1 = meta.query_advice(self.lambda1, rotation); lambda_1.square() - x_a - x_p }; // Closure to compute y_{A,i} = (λ_{1,i} + λ_{2,i}) * (x_{A,i} - x_{R,i}) / 2 let y_a = |meta: &mut VirtualCells, rotation: Rotation| { let x_a = meta.query_advice(self.x_a, rotation); let lambda_1 = meta.query_advice(self.lambda1, rotation); let lambda_2 = meta.query_advice(self.lambda2, rotation); (lambda_1 + lambda_2) * (x_a - x_r(meta, rotation)) * pallas::Base::TWO_INV }; // Constraints used for q_mul_{2, 3} == 1 let for_loop = |meta: &mut VirtualCells, q_mul: Expression, y_a_next: Expression| { let one = Expression::Constant(pallas::Base::one()); // z_i let z_cur = meta.query_advice(self.z, Rotation::cur()); // z_{i+1} let z_prev = meta.query_advice(self.z, Rotation::prev()); // x_{A,i} let x_a_cur = meta.query_advice(self.x_a, Rotation::cur()); // x_{A,i-1} let x_a_next = meta.query_advice(self.x_a, Rotation::next()); // x_{P,i} let x_p_cur = meta.query_advice(self.x_p, Rotation::cur()); // y_{P,i} let y_p_cur = meta.query_advice(self.y_p, Rotation::cur()); // λ_{1,i} let lambda1_cur = meta.query_advice(self.lambda1, Rotation::cur()); // λ_{2,i} let lambda2_cur = meta.query_advice(self.lambda2, Rotation::cur()); let y_a_cur = y_a(meta, Rotation::cur()); // The current bit in the scalar decomposition, k_i = z_i - 2⋅z_{i+1}. // Recall that we assigned the cumulative variable `z_i` in descending order, // i from n down to 0. So z_{i+1} corresponds to the `z_prev` query. let k = z_cur - z_prev * pallas::Base::from_u64(2); // Check booleanity of decomposition. let bool_check = k.clone() * (one.clone() - k.clone()); // λ_{1,i}⋅(x_{A,i} − x_{P,i}) − y_{A,i} + (2k_i - 1) y_{P,i} = 0 let gradient_1 = lambda1_cur * (x_a_cur.clone() - x_p_cur) - y_a_cur.clone() + (k * pallas::Base::from_u64(2) - one) * y_p_cur; // λ_{2,i}^2 − x_{A,i-1} − x_{R,i} − x_{A,i} = 0 let secant_line = lambda2_cur.clone().square() - x_a_next.clone() - x_r(meta, Rotation::cur()) - x_a_cur.clone(); // λ_{2,i}⋅(x_{A,i} − x_{A,i-1}) − y_{A,i} − y_{A,i-1} = 0 let gradient_2 = lambda2_cur * (x_a_cur - x_a_next) - y_a_cur - y_a_next; std::iter::empty() .chain(Some(("bool_check", q_mul.clone() * bool_check))) .chain(Some(("gradient_1", q_mul.clone() * gradient_1))) .chain(Some(("secant_line", q_mul.clone() * secant_line))) .chain(Some(("gradient_2", q_mul * gradient_2))) }; // q_mul_1 == 1 checks meta.create_gate("q_mul_1 == 1 checks", |meta| { let q_mul_1 = meta.query_selector(self.q_mul.0); let y_a_next = y_a(meta, Rotation::next()); let y_a_witnessed = meta.query_advice(self.lambda1, Rotation::cur()); vec![("init y_a", q_mul_1 * (y_a_witnessed - y_a_next))] }); // q_mul_2 == 1 checks meta.create_gate("q_mul_2 == 1 checks", |meta| { let q_mul_2 = meta.query_selector(self.q_mul.1); let y_a_next = y_a(meta, Rotation::next()); // x_{P,i} let x_p_cur = meta.query_advice(self.x_p, Rotation::cur()); // x_{P,i-1} let x_p_next = meta.query_advice(self.x_p, Rotation::next()); // y_{P,i} let y_p_cur = meta.query_advice(self.y_p, Rotation::cur()); // y_{P,i-1} let y_p_next = meta.query_advice(self.y_p, Rotation::next()); // The base used in double-and-add remains constant. We check that its // x- and y- coordinates are the same throughout. let x_p_check = x_p_cur - x_p_next; let y_p_check = y_p_cur - y_p_next; std::iter::empty() .chain(Some(("x_p_check", q_mul_2.clone() * x_p_check))) .chain(Some(("y_p_check", q_mul_2.clone() * y_p_check))) .chain(for_loop(meta, q_mul_2, y_a_next)) }); // q_mul_3 == 1 checks meta.create_gate("q_mul_3 == 1 checks", |meta| { let q_mul_3 = meta.query_selector(self.q_mul.2); let y_a_final = meta.query_advice(self.lambda1, Rotation::next()); for_loop(meta, q_mul_3, y_a_final) }); } /// We perform incomplete addition on all but the last three bits of the /// decomposed scalar. /// We split the bits in the incomplete addition range into "hi" and "lo" /// halves and process them side by side, using the same rows but with /// non-overlapping columns. The base is never the identity point even at /// the boundary between halves. /// Returns (x, y, z). #[allow(clippy::type_complexity)] pub(super) fn double_and_add( &self, region: &mut Region<'_, pallas::Base>, offset: usize, base: &NonIdentityEccPoint, bits: &[Option], acc: (X, Y, Z), ) -> Result<(X, Y, Vec>), Error> { // Check that we have the correct number of bits for this double-and-add. assert_eq!(bits.len(), self.num_bits); // Handle exceptional cases let (x_p, y_p) = (base.x.value(), base.y.value()); let (x_a, y_a) = (acc.0.value(), acc.1.value()); if let (Some(x_a), Some(y_a), Some(x_p), Some(y_p)) = (x_a, y_a, x_p, y_p) { // A is point at infinity if (x_p == pallas::Base::zero() && y_p == pallas::Base::zero()) // Q is point at infinity || (x_a == pallas::Base::zero() && y_a == pallas::Base::zero()) // x_p = x_a || (x_p == x_a) { return Err(Error::SynthesisError); } } // Set q_mul values { // q_mul_1 = 1 on offset 0 self.q_mul.0.enable(region, offset)?; let offset = offset + 1; // q_mul_2 = 1 on all rows after offset 0, excluding the last row. for idx in 0..(self.num_bits - 1) { self.q_mul.1.enable(region, offset + idx)?; } // q_mul_3 = 1 on the last row. self.q_mul.2.enable(region, offset + self.num_bits - 1)?; } // Initialise double-and-add let (mut x_a, mut y_a, mut z) = { // Initialise the running `z` sum for the scalar bits. let z = copy(region, || "starting z", self.z, offset, &acc.2)?; // Initialise acc let x_a = copy(region, || "starting x_a", self.x_a, offset + 1, &acc.0)?; let y_a = copy(region, || "starting y_a", self.lambda1, offset, &acc.1)?; (x_a, y_a.value(), z) }; // Increase offset by 1; we used row 0 for initializing `z`. let offset = offset + 1; // Initialise vector to store all interstitial `z` running sum values. let mut zs: Vec> = Vec::with_capacity(bits.len()); // Incomplete addition for (row, k) in bits.iter().enumerate() { // z_{i} = 2 * z_{i+1} + k_i let z_val = z.value().zip(k.as_ref()).map(|(z_val, k)| { pallas::Base::from_u64(2) * z_val + pallas::Base::from_u64(*k as u64) }); let z_cell = region.assign_advice( || "z", self.z, row + offset, || z_val.ok_or(Error::SynthesisError), )?; z = CellValue::new(z_cell, z_val); zs.push(Z(z)); // Assign `x_p`, `y_p` region.assign_advice( || "x_p", self.x_p, row + offset, || x_p.ok_or(Error::SynthesisError), )?; region.assign_advice( || "y_p", self.y_p, row + offset, || y_p.ok_or(Error::SynthesisError), )?; // If the bit is set, use `y`; if the bit is not set, use `-y` let y_p = y_p .zip(k.as_ref()) .map(|(y_p, k)| if !k { -y_p } else { y_p }); // Compute and assign λ1⋅(x_A − x_P) = y_A − y_P let lambda1 = y_a .zip(y_p) .zip(x_a.value()) .zip(x_p) .map(|(((y_a, y_p), x_a), x_p)| (y_a - y_p) * (x_a - x_p).invert().unwrap()); region.assign_advice( || "lambda1", self.lambda1, row + offset, || lambda1.ok_or(Error::SynthesisError), )?; // x_R = λ1^2 - x_A - x_P let x_r = lambda1 .zip(x_a.value()) .zip(x_p) .map(|((lambda1, x_a), x_p)| lambda1 * lambda1 - x_a - x_p); // λ2 = (2(y_A) / (x_A - x_R)) - λ1 let lambda2 = lambda1 .zip(y_a) .zip(x_a.value()) .zip(x_r) .map(|(((lambda1, y_a), x_a), x_r)| { pallas::Base::from_u64(2) * y_a * (x_a - x_r).invert().unwrap() - lambda1 }); region.assign_advice( || "lambda2", self.lambda2, row + offset, || lambda2.ok_or(Error::SynthesisError), )?; // Compute and assign `x_a` for the next row let x_a_new = lambda2 .zip(x_a.value()) .zip(x_r) .map(|((lambda2, x_a), x_r)| lambda2.square() - x_a - x_r); y_a = lambda2 .zip(x_a.value()) .zip(x_a_new) .zip(y_a) .map(|(((lambda2, x_a), x_a_new), y_a)| lambda2 * (x_a - x_a_new) - y_a); let x_a_val = x_a_new; let x_a_cell = region.assign_advice( || "x_a", self.x_a, row + offset + 1, || x_a_val.ok_or(Error::SynthesisError), )?; x_a = CellValue::new(x_a_cell, x_a_val); } // Witness final y_a let y_a = { let cell = region.assign_advice( || "y_a", self.lambda1, offset + self.num_bits, || y_a.ok_or(Error::SynthesisError), )?; CellValue::new(cell, y_a) }; Ok((X(x_a), Y(y_a), zs)) } }