Migrate to `ff 0.12`, `group 0.12`

MSRV is now 1.56.0.

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           override: true
       - name: Run tests
         uses: actions-rs/cargo@v1
@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           override: true
       - name: Add target
         run: rustup target add ${{ matrix.target }}
@@ -55,7 +55,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           override: true
       # Build benchmarks to prevent bitrot
       - name: Build benchmarks
@@ -71,7 +71,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           override: true
       - name: cargo build
         uses: actions-rs/cargo@v1
@@ -85,7 +85,7 @@ jobs:
         run: mdbook test -L target/debug/deps book/
 
   clippy:
-    name: Clippy (1.51.0)
+    name: Clippy (1.56.0)
     timeout-minutes: 30
     runs-on: ubuntu-latest
 
@@ -93,13 +93,13 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           components: clippy
           override: true
       - name: Run clippy
         uses: actions-rs/clippy-check@v1
         with:
-          name: Clippy (1.51.0)
+          name: Clippy (1.56.0)
           token: ${{ secrets.GITHUB_TOKEN }}
           args: --all-features --all-targets -- -D warnings
 
@@ -158,7 +158,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           override: true
       - name: cargo fetch
         uses: actions-rs/cargo@v1
@@ -181,7 +181,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.51.0
+          toolchain: 1.56.0
           override: true
       - run: rustup component add rustfmt
       - uses: actions-rs/cargo@v1

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to Rust's notion of
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- MSRV is now 1.56.0.
+- Migrated to `ff 0.12`, `group 0.12`.
 
 ## [0.3.1] - 2022-04-20
 ### Added

Cargo.toml

@@ -9,6 +9,7 @@ authors = [
     "Jack Grigg <jack@electriccoin.co>",
 ]
 edition = "2018"
+rust-version = "1.56"
 license = "MIT OR Apache-2.0"
 repository = "https://github.com/zcash/pasta_curves"
 documentation = "https://docs.rs/pasta_curves"
@@ -41,8 +42,8 @@ harness = false
 required-features = ["alloc"]
 
 [dependencies]
-ff = { version = "0.11", default-features = false }
-group = { version = "0.11", default-features = false }
+ff = { version = "0.12", default-features = false }
+group = { version = "0.12", default-features = false }
 rand = { version = "0.8", default-features = false }
 static_assertions = "1.1.0"
 subtle = { version = "2.3", default-features = false }

README.md

@@ -8,7 +8,7 @@ Pallas and Vesta. More details about the Pasta curves can be found
 
 ## Minimum Supported Rust Version
 
-Requires Rust **1.51** or higher.
+Requires Rust **1.56** or higher.
 
 Minimum supported Rust version can be changed in the future, but it will be done with a
 minor version bump.

rust-toolchain

@@ -1 +1 @@
-1.51.0
+1.56.0

src/arithmetic/fields.rs

@@ -27,7 +27,7 @@ pub trait SqrtRatio: ff::PrimeField {
     ///
     /// Field implementations may override this to use an efficient addition chain.
     fn pow_by_t_minus1_over2(&self) -> Self {
-        ff::Field::pow_vartime(&self, &Self::T_MINUS1_OVER2)
+        ff::Field::pow_vartime(self, &Self::T_MINUS1_OVER2)
     }
 
     /// Gets the lower 32 bits of this field element when expressed

src/lib.rs

@@ -4,7 +4,7 @@
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![allow(unknown_lints)]
 #![allow(clippy::op_ref, clippy::same_item_push, clippy::upper_case_acronyms)]
-#![deny(broken_intra_doc_links)]
+#![deny(rustdoc::broken_intra_doc_links)]
 #![deny(missing_debug_implementations)]
 #![deny(missing_docs)]
 #![deny(unsafe_code)]