zec
/
pasta_curves
mirror of https://github.com/zcash/pasta_curves.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

More idiomatic implementation of Ord for Field 

Co-authored-by: str4d <jack@z.cash>
This commit is contained in:
ying tong 2020-10-08 12:23:16 +08:00 committed by therealyingtong
parent 89fd6e4d44
commit 6f6378b2ea
2 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/arithmetic/fields/fp.rs
View File

@ -66,15 +66,14 @@ impl std::cmp::Ord for Fp {
fn cmp(&self, other: &Self) -> std::cmp::Ordering { fn cmp(&self, other: &Self) -> std::cmp::Ordering {
let left = self.to_bytes(); let left = self.to_bytes();
let right = other.to_bytes(); let right = other.to_bytes();
for (left_byte, right_byte) in left.iter().zip(right.iter()).rev() { left.iter()
let tmp = left_byte.cmp(right_byte); .zip(right.iter())
if let std::cmp::Ordering::Equal = tmp { .rev()
continue; .find_map(|(left_byte, right_byte)| match left_byte.cmp(right_byte) {
} else { std::cmp::Ordering::Equal => None,
return tmp; res => Some(res),
} })
} .unwrap_or(std::cmp::Ordering::Equal)
std::cmp::Ordering::Equal
} }
} }

17
src/arithmetic/fields/fq.rs
View File

@ -66,15 +66,14 @@ impl std::cmp::Ord for Fq {
fn cmp(&self, other: &Self) -> std::cmp::Ordering { fn cmp(&self, other: &Self) -> std::cmp::Ordering {
let left = self.to_bytes(); let left = self.to_bytes();
let right = other.to_bytes(); let right = other.to_bytes();
for (left_byte, right_byte) in left.iter().zip(right.iter()).rev() { left.iter()
let tmp = left_byte.cmp(right_byte); .zip(right.iter())
if let std::cmp::Ordering::Equal = tmp { .rev()
continue; .find_map(|(left_byte, right_byte)| match left_byte.cmp(right_byte) {
} else { std::cmp::Ordering::Equal => None,
return tmp; res => Some(res),
} })
} .unwrap_or(std::cmp::Ordering::Equal)
std::cmp::Ordering::Equal
} }
} }