[#1496] Authentication success after previous failure

- Closes #1496
- The onFailed callback now does not reset the helper compose variable anymore
- Toast duration shortened in the auth failed state to improve its UX
- Changelog update

CHANGELOG.md

@@ -12,6 +12,9 @@ directly impact users rather than highlighting other key architectural updates.*
 ### Added
 - Proper ZEC amount abbreviation has been added across the entire app as described by the design document
 
+### Fixed
+- The app authentication now correctly handles authentication success after a previous failed state 
+
 ## [1.1.2 (676)] - 2024-06-24
 
 ### Fixed

ui-lib/src/main/java/co/electriccoin/zcash/ui/Navigation.kt

@@ -341,7 +341,7 @@ private fun MainActivity.ShowSystemAuthentication(
             setCheckedProperty(false)
         },
         onFailed = {
-            setCheckedProperty(false)
+            // No action needed
         },
         useCase = protectedUseCase
     )

ui-lib/src/main/java/co/electriccoin/zcash/ui/common/viewmodel/AuthenticationViewModel.kt

@@ -234,7 +234,7 @@ class AuthenticationViewModel(
                      */
                     override fun onAuthenticationSucceeded(result: BiometricPrompt.AuthenticationResult) {
                         super.onAuthenticationSucceeded(result)
-                        Twig.info { "Authentication successful: $result" }
+                        Twig.info { "Authentication successful" }
                         authenticationResult.value = AuthenticationResult.Success
                     }
 

ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/authentication/AndroidAuthentication.kt

@@ -140,7 +140,8 @@ private fun WrapDeleteWalletAuth(
             Twig.warn { "Authentication result: failed" }
             authenticationViewModel.resetAuthenticationResult()
             onFailed()
-            Toast.makeText(activity, activity.getString(R.string.authentication_toast_failed), Toast.LENGTH_LONG).show()
+            Toast.makeText(activity, activity.getString(R.string.authentication_toast_failed), Toast.LENGTH_SHORT)
+                .show()
         }
         is AuthenticationResult.Error -> {
             Twig.error {
@@ -212,7 +213,7 @@ private fun WrapAppExportPrivateDataAuth(
             Twig.warn { "Authentication result: failed" }
             authenticationViewModel.resetAuthenticationResult()
             onFailed()
-            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_failed), Toast.LENGTH_LONG)
+            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_failed), Toast.LENGTH_SHORT)
                 .show()
         }
         is AuthenticationResult.Error -> {
@@ -285,7 +286,7 @@ private fun WrapSeedRecoveryAuth(
             Twig.warn { "Authentication result: failed" }
             authenticationViewModel.resetAuthenticationResult()
             onFailed()
-            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_failed), Toast.LENGTH_LONG)
+            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_failed), Toast.LENGTH_SHORT)
                 .show()
         }
         is AuthenticationResult.Error -> {
@@ -359,7 +360,7 @@ private fun WrapSendFundsAuth(
             Twig.warn { "Authentication result: failed" }
             authenticationViewModel.resetAuthenticationResult()
             onFailed()
-            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_failed), Toast.LENGTH_LONG)
+            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_failed), Toast.LENGTH_SHORT)
                 .show()
         }
         is AuthenticationResult.Error -> {
@@ -432,7 +433,7 @@ private fun WrapAppAccessAuth(
         AuthenticationResult.Canceled -> {
             Twig.info { "Authentication result: canceled: shutting down" }
             authenticationViewModel.resetAuthenticationResult()
-            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_canceled), Toast.LENGTH_LONG)
+            Toast.makeText(activity, stringResource(id = R.string.authentication_toast_canceled), Toast.LENGTH_SHORT)
                 .show()
             onCancel()
         }

ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/sendconfirmation/AndroidSendConfirmation.kt

@@ -228,12 +228,13 @@ internal fun WrapSendConfirmation(
                             synchronizer = synchronizer,
                         )
                     }
+                    sendFundsAuthentication.value = false
                 },
                 onCancel = {
                     sendFundsAuthentication.value = false
                 },
                 onFailed = {
-                    sendFundsAuthentication.value = false
+                    // No action needed
                 },
                 useCase = AuthenticationUseCase.SendFunds
             )