From 59e8d235f662ceb452763adb9939f8d55bd5d90b Mon Sep 17 00:00:00 2001 From: Carter Jernigan Date: Thu, 2 Jun 2022 15:11:46 -0400 Subject: [PATCH] [#5] Remove subproject configuration for coverage --- .../zcash.android-build-conventions.gradle.kts | 3 --- build.gradle.kts | 12 ------------ 2 files changed, 15 deletions(-) diff --git a/build-convention/src/main/kotlin/zcash.android-build-conventions.gradle.kts b/build-convention/src/main/kotlin/zcash.android-build-conventions.gradle.kts index 999ad457..77ab5ca8 100644 --- a/build-convention/src/main/kotlin/zcash.android-build-conventions.gradle.kts +++ b/build-convention/src/main/kotlin/zcash.android-build-conventions.gradle.kts @@ -1,9 +1,6 @@ import com.android.build.api.dsl.CommonExtension import org.jetbrains.kotlin.gradle.dsl.KotlinJvmOptions -// Note: due to a few limitations with build-conventions, there is some common Android Gradle Plugin -// configuration happening in the root build.gradle.kts with a subprojects block. - pluginManager.withPlugin("com.android.application") { project.the().apply { configureBaseExtension() diff --git a/build.gradle.kts b/build.gradle.kts index d7c3d401..f6b0224f 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -124,15 +124,3 @@ kover { "ui-lib", ) } - -// All of this should be refactored to build-conventions -subprojects { - pluginManager.withPlugin("com.android.library") { - project.the().apply { - // TODO [#5]: Figure out how to move this into the build-conventions - testCoverage { - jacocoVersion = libs.versions.jacoco.get() - } - } - } -}