From 8e17d07cedab251d7e46e60e3fa145db1966aab7 Mon Sep 17 00:00:00 2001 From: Carter Jernigan Date: Fri, 3 Mar 2023 08:06:03 -0500 Subject: [PATCH] [#762] Simplified seed backup UX MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Because we’re making UI text changes, I’ve forked our views into “long” and “short” versions that preserve the previous experience while allowing the shorter experience to be different. One limitation of the current approach is that the screenshot tests are limited to the current configuration, so there is some risk of ‘bit rot’ with the screenshot tests for the longer onboarding. For this PR, I manually switched the feature flags and re-ran the screenshot tests to make sure they still worked. --------- Co-authored-by: Honza --- ...ark_test_connectedBenchmarkAndroidTest.xml | 28 +++ .../_ui_screenshot_test_connectedCheck.xml | 28 +++ ...ark_test_connectedBenchmarkAndroidTest.xml | 55 ----- .../ui_design_lib_connectedCheck.xml | 5 +- .../ui_screenshot_test_connectedCheck.xml | 57 ----- ui-lib/build.gradle.kts | 4 +- .../backup/integration/BackupActivityTest.kt | 6 +- .../integration/BackupIntegrationTest.kt | 6 +- ...kupTestSetup.kt => LongBackupTestSetup.kt} | 4 +- ...ackupViewTest.kt => LongBackupViewTest.kt} | 21 +- ...kt => LongBackupViewsSecuredScreenTest.kt} | 4 +- .../backup/view/ShortBackupTestSetup.kt | 44 ++++ .../screen/backup/view/ShortBackupViewTest.kt | 64 ++++++ .../view/ShortBackupViewsSecuredScreenTest.kt | 55 +++++ ...estSetup.kt => LongOnboardingTestSetup.kt} | 15 +- .../onboarding/ShortOnboardingTestSetup.kt | 44 ++++ .../integration/OnboardingActivityTest.kt | 5 +- .../integration/OnboardingIntegrationTest.kt | 5 +- ...gViewTest.kt => LongOnboardingViewTest.kt} | 38 +--- .../view/ShortOnboardingViewTest.kt | 68 ++++++ .../co/electriccoin/zcash/ui/MainActivity.kt | 4 +- .../ui/configuration/ConfigurationEntries.kt | 7 +- .../zcash/ui/screen/backup/AndroidBackup.kt | 71 +++++- .../ui/screen/backup/view/ChipDropDown.kt | 9 +- ...ckupView.kt => LongNewWalletBackupView.kt} | 4 +- .../backup/view/ShortNewWalletBackupView.kt | 159 +++++++++++++ .../ui/screen/onboarding/AndroidOnboarding.kt | 94 ++++---- ...nboardingView.kt => LongOnboardingView.kt} | 25 +-- .../onboarding/view/ShortOnboardingView.kt | 143 ++++++++++++ .../src/main/res/ui/backup/values/strings.xml | 5 + ui-lib/src/main/res/ui/new/values/strings.xml | 6 + .../main/res/ui/onboarding/values/strings.xml | 4 + .../main/res/ui/receive/values/strings.xml | 4 +- .../res/ui/wallet_address/values/strings.xml | 3 +- .../zcash/ui/screenshot/ScreenshotTest.kt | 208 ++++++++++-------- 35 files changed, 942 insertions(+), 360 deletions(-) create mode 100644 .idea/runConfigurations/_ui_benchmark_test_connectedBenchmarkAndroidTest.xml create mode 100644 .idea/runConfigurations/_ui_screenshot_test_connectedCheck.xml delete mode 100644 .idea/runConfigurations/ui_benchmark_test_connectedBenchmarkAndroidTest.xml delete mode 100644 .idea/runConfigurations/ui_screenshot_test_connectedCheck.xml rename ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/backup/view/{BackupTestSetup.kt => LongBackupTestSetup.kt} (97%) rename ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/backup/view/{BackupViewTest.kt => LongBackupViewTest.kt} (94%) rename ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/backup/view/{BackupViewsSecuredScreenTest.kt => LongBackupViewsSecuredScreenTest.kt} (95%) create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/backup/view/ShortBackupTestSetup.kt create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/backup/view/ShortBackupViewTest.kt create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/backup/view/ShortBackupViewsSecuredScreenTest.kt rename ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/onboarding/{OnboardingTestSetup.kt => LongOnboardingTestSetup.kt} (79%) create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/onboarding/ShortOnboardingTestSetup.kt rename ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/onboarding/view/{OnboardingViewTest.kt => LongOnboardingViewTest.kt} (85%) create mode 100644 ui-lib/src/androidTest/java/co/electriccoin/zcash/ui/screen/onboarding/view/ShortOnboardingViewTest.kt rename ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/backup/view/{BackupView.kt => LongNewWalletBackupView.kt} (99%) create mode 100644 ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/backup/view/ShortNewWalletBackupView.kt rename ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/onboarding/view/{OnboardingView.kt => LongOnboardingView.kt} (91%) create mode 100644 ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/onboarding/view/ShortOnboardingView.kt create mode 100644 ui-lib/src/main/res/ui/new/values/strings.xml diff --git a/.idea/runConfigurations/_ui_benchmark_test_connectedBenchmarkAndroidTest.xml b/.idea/runConfigurations/_ui_benchmark_test_connectedBenchmarkAndroidTest.xml new file mode 100644 index 00000000..35a01105 --- /dev/null +++ b/.idea/runConfigurations/_ui_benchmark_test_connectedBenchmarkAndroidTest.xml @@ -0,0 +1,28 @@ + + + + + + + + true + true + false + + + \ No newline at end of file diff --git a/.idea/runConfigurations/_ui_screenshot_test_connectedCheck.xml b/.idea/runConfigurations/_ui_screenshot_test_connectedCheck.xml new file mode 100644 index 00000000..8f3e0b7d --- /dev/null +++ b/.idea/runConfigurations/_ui_screenshot_test_connectedCheck.xml @@ -0,0 +1,28 @@ + + + + + + + + true + true + false + + + \ No newline at end of file diff --git a/.idea/runConfigurations/ui_benchmark_test_connectedBenchmarkAndroidTest.xml b/.idea/runConfigurations/ui_benchmark_test_connectedBenchmarkAndroidTest.xml deleted file mode 100644 index d6eab902..00000000 --- a/.idea/runConfigurations/ui_benchmark_test_connectedBenchmarkAndroidTest.xml +++ /dev/null @@ -1,55 +0,0 @@ - - - - - \ No newline at end of file diff --git a/.idea/runConfigurations/ui_design_lib_connectedCheck.xml b/.idea/runConfigurations/ui_design_lib_connectedCheck.xml index a0c9523b..fd5e682b 100644 --- a/.idea/runConfigurations/ui_design_lib_connectedCheck.xml +++ b/.idea/runConfigurations/ui_design_lib_connectedCheck.xml @@ -1,20 +1,17 @@ -