- all dependencies are now consolidated
- cleanup of dependencies
- getting rid of all .live instances in the tests
- all dependencies use mocked or noOp instances
- BalanceBreakdown migrated
- unit and snapshot tests fixed
- some terminology cleanup beyond scope of this task, the dependencies are keys essentially so I refactored all of them to follow the same syntax
- SDKSynchronizer refactored to sdkSynchronizer
- RecoveryPhraseDisplay migrated to new TCA's ReducerProtocol
- fixed unit tests
- TODO Ensure that sensitive information can't be logged intentionally or by accident #444
Closes#25
- Add `todos` swiftlint rule which detects `TODO:` or `FIXME:` without
ticket number.
- Use `TODO [#<issue number>]:` to not trigger this rule.
- Updated TODOs and FIXMEs which had issue number in different format in
the code.
Following dependencies refactored to await/async
- RecoveryPhraseValidationFlowReducer
- RecoveryPhraseDisplayStore
- AppStore
- UserPreferencesStorage
- WrappedUserDefaults
which allowed to reduce imports of Combine/TCA
- recovery phrase randomizer & wrapper
- did finish launching -> initialized wallet test
- cleanup of static dependencies
- did finish launching -> keys missing integration test
- did finish launching -> uninitialized integration test
- database files were missing, mocked to behave like it's available
- key missing test fix, the database files were missing too => mocked to act like being present
- scan UI view
- UI representable
- scaffold of scan view
- rect of interest support
- simple URI parser and validator
- tests
[106] [Scaffold] Scan QR Screen
- scan status added
- scan status tests
[106] [Scaffold] Scan QR Screen
- custom back button added
[106] [Scaffold] Scan QR Screen
- fixed typo
[106] [Scaffold] Scan QR Screen (321)
- valid vs. invalid code part of the enum
[106] [Scaffold] Scan QR Screen (321)
- refactor
[106] [Scaffold] Scan QR Screen (321)
- cleanup
[106] [Scaffold] Scan QR Screen (321)
- review comments solved
- some improvements added
- firing the valid qr code after 1s
[106] [Scaffold] Scan QR Screen (321)
- tests fixed
- onAppear test added
- print() cleanup
[106] [Scaffold] Scan QR Screen (321)
- wrapped audio services
- vibrate when QR found
- alphabetical order of environmental parameters
- AVCaptureSession stopRunning explicit call, probably handled by AVCaptureSession itself but I didn't find proof
- QRCodeScanView simplified and cleaned up
[106] [Scaffold] Scan QR Screen (321)
- URIParser added to the project
Lukas Korba
Michal Fousek