From 150778f0083008dfde5fe464c4f44d39014f7d84 Mon Sep 17 00:00:00 2001 From: Honza Rychnovsky Date: Wed, 17 Aug 2022 15:48:02 +0200 Subject: [PATCH] [#367] Fix Kotlin compiler warnings * Fix missing room schema export directory * Fix returned unused fields from cursor * Fix missing db column index * Improved TODO. Added suppress warning * Changed parameters name to correspond to their supertype * Changed type to Kotlin variant * Use priority parameter * Unified parameter names * Suppress unchecked type warning * Removed inline function * Suppress obsolete coroutine warnings * Improve previous commit * Fix unnecessary safe call warning * Remove unused parameter * Unreachable code * toLowerCase where possible * Changed parameter name * Suppress several "unused" warnings * Fixed fromHtml() deprecation * Suppress intentionally unused parameter warning * Remove redundant initializer * Remove inline function * Suppress intentionally used deprecated code * Unreachable code * Suppress obsolete coroutine warnings * Suppress intentionally unused parameter * Remove unused expression * Supertype parameter name * Warnings of GetBlockRangeFragment.kt * Deprecated onActivityCreated * Suppress obsolete coroutine/flow warnings * Unnecessary null check * Suppress intentionally unused parameter * Suppress intentionally unused parameters * Deprecated onActivityCreated * Predetermined type * ListUtxosFragment clean code * Suppress intentionally unused parameter * Lint checks warnings fix * Add data db migration * Enable treating Kotlin compiler warnings as errors * Solve several darkside-test-lib tests warnings * Solve several demo-app tests warnings * Solve several sdk-lib tests warnings * Ktlint check result fix * Remove parentheses now that Synchronizer is not cast * Remove wildcard imports for java.util * Revert "Add data db migration" * Revert "Fix missing db column index" * Suppress missing indexes on data db entities Co-authored-by: Carter Jernigan --- .idea/codeStyles/Project.xml | 5 +++ .../sdk/darkside/reorgs/InboundTxTests.kt | 4 +-- .../android/sdk/darkside/test/DarksideTest.kt | 2 +- .../darkside/test/DarksideTestCoordinator.kt | 15 ++++---- .../android/sdk/darkside/test/ScopedTest.kt | 4 ++- .../sdk/darkside/test/SimpleMnemonics.kt | 4 +-- .../android/sdk/darkside/test/TestWallet.kt | 2 ++ .../sdk/sample/demoapp/SampleCodeTest.kt | 4 +-- .../android/sdk/demoapp/BaseDemoFragment.kt | 9 +++-- .../z/ecc/android/sdk/demoapp/MainActivity.kt | 22 ++++++------ .../demos/getblock/GetBlockFragment.kt | 10 +++--- .../getblockrange/GetBlockRangeFragment.kt | 14 ++++---- .../GetLatestHeightFragment.kt | 2 +- .../getprivatekey/GetPrivateKeyFragment.kt | 11 ++++-- .../sdk/demoapp/demos/home/HomeFragment.kt | 4 +++ .../ListTransactionsFragment.kt | 12 +++++-- .../listtransactions/TransactionAdapter.kt | 29 ++++++++------- .../listtransactions/TransactionViewHolder.kt | 8 ++--- .../demos/listutxos/ListUtxosFragment.kt | 36 +++++++++---------- .../demoapp/demos/listutxos/UtxoAdapter.kt | 29 ++++++++------- .../demoapp/demos/listutxos/UtxoViewHolder.kt | 8 ++--- .../sdk/demoapp/demos/send/SendFragment.kt | 11 ++++-- .../android/sdk/demoapp/util/NetworkExt.kt | 2 +- .../android/sdk/demoapp/util/SampleStorage.kt | 1 + .../sdk/demoapp/util/SimpleMnemonics.kt | 4 +-- gradle.properties | 3 +- sdk-lib/build.gradle.kts | 7 ++-- .../z/ecc/android/sdk/ext/TestExtensions.kt | 2 ++ .../ecc/android/sdk/integration/SanityTest.kt | 6 ++-- .../sdk/integration/TestnetIntegrationTest.kt | 12 +++---- .../PersistentTransactionManagerTest.kt | 20 +++++------ .../cash/z/ecc/android/sdk/test/ScopedTest.kt | 4 ++- .../z/ecc/android/sdk/util/SimpleMnemonics.kt | 4 +-- .../cash/z/ecc/android/sdk/util/TestWallet.kt | 2 ++ .../cash/z/ecc/android/sdk/Initializer.kt | 9 +++-- .../cash/z/ecc/android/sdk/SdkSynchronizer.kt | 23 +++++++----- .../sdk/block/CompactBlockProcessor.kt | 24 ++++++++----- .../z/ecc/android/sdk/db/entity/Received.kt | 2 ++ .../cash/z/ecc/android/sdk/db/entity/Sent.kt | 2 ++ .../ecc/android/sdk/db/entity/Transactions.kt | 2 ++ .../cash/z/ecc/android/sdk/db/entity/Utxo.kt | 2 ++ .../z/ecc/android/sdk/ext/BatchMetrics.kt | 8 ++--- .../ecc/android/sdk/ext/ConsensusBranchId.kt | 2 +- .../android/sdk/internal/db/DerivedDataDb.kt | 6 ++-- .../z/ecc/android/sdk/internal/ext/Ext.kt | 4 +-- .../internal/ext/android/ComputableFlow.kt | 4 +++ .../sdk/internal/ext/android/FlowPagedList.kt | 3 +- .../ext/android/FlowPagedListBuilder.kt | 5 ++- .../PersistentTransactionManager.kt | 17 +++++---- .../transaction/TransactionManager.kt | 4 ++- .../z/ecc/android/sdk/tool/CheckpointTool.kt | 8 ++--- .../z/ecc/android/sdk/tool/DerivationTool.kt | 11 +++--- 52 files changed, 256 insertions(+), 192 deletions(-) diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml index 4317c7f1..577406e4 100644 --- a/.idea/codeStyles/Project.xml +++ b/.idea/codeStyles/Project.xml @@ -1,6 +1,11 @@ +