From 2a3c070a014ff75ea4b6d6ea76f73eecc4dde0a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Honza=20Rychnovsk=C3=BD?= Date: Wed, 17 Apr 2024 17:51:31 +0200 Subject: [PATCH] Remove logs stripping check entirely (#1444) - As ensuring the check should be applied is not possible for a library that depends on clients build type and their different use cases - Stripping tested manually with different client wallets, and it works as expected --- .../src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sdk-lib/src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt b/sdk-lib/src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt index 4cdfd9ae..4bc740f7 100644 --- a/sdk-lib/src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt +++ b/sdk-lib/src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt @@ -571,8 +571,6 @@ interface Synchronizer { validateAlias(alias) - validateLogging() - val saplingParamTool = SaplingParamTool.new(applicationContext) val loadedCheckpoint = @@ -741,10 +739,3 @@ private fun validateAlias(alias: String) { "characters and only contain letters, digits, hyphens, and underscores." } } - -private fun validateLogging() { - if (BuildConfig.BUILD_TYPE == "release") { - // In release builds, logs should be stripped by R8 rules - Twig.assertLoggingStripped() - } -}