This implementation is somewhat special from our other Gradle properties, because it does not get declared in the root gradle.properties. The reason is that included builds are supposed to have their own properties e.g.
root_project/gradle.properties
root_project/build-conventions/gradle.properties
Instead of declaring the property in different places which might lead to confusion, this leaves the property undeclared, with the Gradle scripts assuming a default value of true. The only time this is expected to be overridden is due to a workaround for an Android Studio bug.
* [#585] Add checkpoints for Orchard Activation Height
Closes#585
these checkpoints will be useful for wallets supporting orchard
that had existing orchard activity from activation height on and
after NU5 SDK support is implemented they need to rescan for orchard
funds.
* Add documentation on special checkpoints
Co-authored-by: Carter Jernigan <git@carterjernigan.com>
- Added instructions to readme for updating checkpoints
- Added new checkpoints since the last release
- Re-generated old checkpoints for consistent formatting of the height in quotes. Although our JSON parser supports both, consistent formatting reduces future bug risks
- Generated missing checkpoints
- Removed odd-numbered checkpoints (which were left over as the “latest” checkpoint during previous checkpoint updates)
This updates our templates to be more consistent with the Secant app repository.
Note that the checklist item for code coverage was removed for now, until we improve the test infrastructure for the SDK.
This also addresses a security reminder, by explicitly stating that one shouldn't run the demo app from a pull request until after reviewing the code changes.
In addition to using build-conventions to make the build scripts more DRY, the following additional changes are included in this commit:
- Convert build scripts to kts
- Fix a double-build issue with the SDK
- Add configurable options for treating compiler warnings as errors (disabled for now, due to extensive warnings that need to be corrected first)
- Added detekt as an additional static analysis tool
Added instructions for installing Rust with Homebrew, which simplifies setup for many macOS developers.
Add x86_64 target, as the SDK can fail to build out of the box without this option.
Fix instructions for compiling the SDK versus compiling the sample application
- Correct typo and compiler warning in Rust.
'trait objects without an explicity dyn' are deprecated and this is a warning as of Rust 1.37
- update dependencies
- update documentation
docs
Renamed data DB in overview diagram. Initially we expected this to only contain UI data but it was easier to have one database for everything that can be derived from a seed, rather than multiple databases segregated by sensitivity.