From 0e2ee8bcebe9017862669c68e38114692ac5f7e2 Mon Sep 17 00:00:00 2001 From: eliamaldini Date: Thu, 17 Aug 2023 12:05:44 +0200 Subject: [PATCH] fixed typo --- modules/gcve-private-cloud/README.md | 11 +++++------ modules/gcve-private-cloud/main.tf | 2 +- modules/gcve-private-cloud/variables.tf | 2 +- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/modules/gcve-private-cloud/README.md b/modules/gcve-private-cloud/README.md index ab374c08..df472334 100644 --- a/modules/gcve-private-cloud/README.md +++ b/modules/gcve-private-cloud/README.md @@ -2,12 +2,11 @@ This module implements the creation and management of a Google Cloud VMWare Engine Private Cloud with its management cluster. If configured, it also creates the VMWare engine network or it can work with an existing one. The creation of the private connection with the user VPC requires the execution of the [Google SDK command](https://cloud.google.com/sdk/gcloud/reference/vmware/private-connections/create#--routing-mode) the module provides as an output. +To undersatnd the limits and to propertly configure the vSphere/vSAN subnets CIDR range please refer to the [GCVE public documetation](https://cloud.google.com/vmware-engine/docs/quickstart-networking-requirements). + Be aware that the deployment of this module might require up to 2 hours depending on the selected private cloud target zone. -## TOC - -- [TOC](#toc) - [Limitations](#limitations) - [Basic Private Cloud Creation](#basic-private-cloud-creation) - [Private Cloud Creation with custom nodes and cores count](#private-cloud-creation-with-custom-nodes-and-cores-count) @@ -34,7 +33,7 @@ module "gcve-pc" { transit-conn1 = { name = "transit-conn1", network_self_link = "projects/test-prj-elia-01/global/networks/default", - peering = "servicenetworking-googleapis-com" + peering_name = "servicenetworking-googleapis-com" type = "PRIVATE_SERVICE_ACCESS", routing_mode = "REGIONAL" } @@ -62,7 +61,7 @@ module "gcve-pc" { transit-conn1 = { name = "transit-conn1", network_self_link = "projects/test-prj-elia-01/global/networks/default", - peering = "servicenetworking-googleapis-com" + peering_name = "servicenetworking-googleapis-com" type = "PRIVATE_SERVICE_ACCESS", routing_mode = "REGIONAL" } @@ -81,7 +80,7 @@ module "gcve-pc" { | [zone](variables.tf#L91) | Private cloud zone. | string | ✓ | | | [description](variables.tf#L17) | Private cloud description. | string | | "Terraform-managed." | | [management_cluster_config](variables.tf#L28) | Management cluster configuration. | object({…}) | | {…} | -| [private_connections](variables.tf#L47) | VMWare private connections configuration. It is used to create the gcloud command printed as output. | map(object({…})) | | {} | +| [private_connections](variables.tf#L47) | VMWare private connections configuration. It is used to create the gcloud command printed as output. | map(object({…})) | | {} | | [vmw_network_create](variables.tf#L79) | Create the VMware Engine network. When set to false, it uses a data source to reference an existing VMware Engine network. | bool | | true | | [vmw_network_description](variables.tf#L85) | VMware Engine network description. | string | | "Terraform-managed." | diff --git a/modules/gcve-private-cloud/main.tf b/modules/gcve-private-cloud/main.tf index 2568f29d..13b915b7 100644 --- a/modules/gcve-private-cloud/main.tf +++ b/modules/gcve-private-cloud/main.tf @@ -38,7 +38,7 @@ data "google_vmwareengine_network" "private-cloud-network" { data "google_compute_network_peering" "psa_peering" { for_each = var.private_connections - name = each.value.peering + name = each.value.peering_name network = each.value.network_self_link } diff --git a/modules/gcve-private-cloud/variables.tf b/modules/gcve-private-cloud/variables.tf index 61e5b1d4..c1586f41 100644 --- a/modules/gcve-private-cloud/variables.tf +++ b/modules/gcve-private-cloud/variables.tf @@ -49,7 +49,7 @@ variable "private_connections" { type = map(object({ name = string network_self_link = string - peering = string + peering_name = string description = optional(string, "Terraform-managed.") type = optional(string, "REGIONAL") routing_mode = optional(string, "PRIVATE_SERVICE_ACCESS")