From 43b3490ef10691637d2f07c64962a234ba4f1b2d Mon Sep 17 00:00:00 2001 From: Alejandro Leal Date: Thu, 29 Jun 2023 21:47:17 -0400 Subject: [PATCH 1/2] Updating a few files for typos fast/stages/3-data-platform/dev/README.md fast/stages/3-data-platform/dev/outputs.tf CHANGELOG.md blueprints/data-solutions/data-platform-minimal/README.md blueprints/data-solutions/data-platform-minimal/outputs.tf blueprints/data-solutions/data-platform-foundations/README.md --- CHANGELOG.md | 6 +++--- .../data-solutions/data-platform-foundations/README.md | 2 +- blueprints/data-solutions/data-platform-minimal/README.md | 2 +- blueprints/data-solutions/data-platform-minimal/outputs.tf | 2 +- fast/stages/3-data-platform/dev/README.md | 2 +- fast/stages/3-data-platform/dev/outputs.tf | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a213cf6..c49e7c18 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -630,7 +630,7 @@ All notable changes to this project will be documented in this file. - [[#1006](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1006)] Add settings for autoscaling to Bigtable module. ([iht](https://github.com/iht)) - [[#999](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/999)] Default nodepool creation fix ([astianseb](https://github.com/astianseb)) - [[#1005](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1005)] Only set partitioned table when sink type is bigquery ([juliocc](https://github.com/juliocc)) -- [[#997](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/997)] Add BigQuery subcriptions to Pubsub module. ([iht](https://github.com/iht)) +- [[#997](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/997)] Add BigQuery subscriptions to Pubsub module. ([iht](https://github.com/iht)) - [[#995](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/995)] Push container images to GitHub instead of Google Container Registry ([kunzese](https://github.com/kunzese)) - [[#994](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/994)] Add schemas to Pubsub topic module. ([iht](https://github.com/iht)) - [[#979](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/979)] Add network tags support to the organization module ([LucaPrete](https://github.com/LucaPrete)) @@ -902,8 +902,8 @@ All notable changes to this project will be documented in this file. - added `environment` and `context` resource management tags - use resource management tags to restrict scope of roles/orgpolicy.policyAdmin - use `xpnServiceAdmin` (custom role) for stage 3 service accounts that need to attach to a shared VPC -- simplify and standarize ourputs from each stage -- standarize names of projects, service accounts and buckets +- simplify and standardize ourputs from each stage +- standardize names of projects, service accounts and buckets - switch to folder-level `xpnAdmin` and `xpnServiceAdmin` - moved networking projects to folder matching their environments diff --git a/blueprints/data-solutions/data-platform-foundations/README.md b/blueprints/data-solutions/data-platform-foundations/README.md index 15c22ded..427d6b29 100644 --- a/blueprints/data-solutions/data-platform-foundations/README.md +++ b/blueprints/data-solutions/data-platform-foundations/README.md @@ -282,7 +282,7 @@ You can find examples in the `[demo](./demo)` folder. | [df_template](outputs.tf#L49) | Dataflow template image and template details. | | | [gcs-buckets](outputs.tf#L58) | GCS buckets. | | | [kms_keys](outputs.tf#L71) | Cloud MKS keys. | | -| [projects](outputs.tf#L76) | GCP Projects informations. | | +| [projects](outputs.tf#L76) | GCP Projects information. | | | [vpc_network](outputs.tf#L102) | VPC network. | | | [vpc_subnet](outputs.tf#L111) | VPC subnetworks. | | diff --git a/blueprints/data-solutions/data-platform-minimal/README.md b/blueprints/data-solutions/data-platform-minimal/README.md index 5760f3f6..7072f717 100644 --- a/blueprints/data-solutions/data-platform-minimal/README.md +++ b/blueprints/data-solutions/data-platform-minimal/README.md @@ -301,7 +301,7 @@ The application layer is out of scope of this script. As a demo purpuse only, on | [gcs_buckets](outputs.tf#L38) | GCS buckets. | | | [kms_keys](outputs.tf#L47) | Cloud MKS keys. | | | [network](outputs.tf#L52) | VPC network. | | -| [projects](outputs.tf#L60) | GCP Projects informations. | | +| [projects](outputs.tf#L60) | GCP Projects information. | | | [service_accounts](outputs.tf#L78) | Service account created. | | diff --git a/blueprints/data-solutions/data-platform-minimal/outputs.tf b/blueprints/data-solutions/data-platform-minimal/outputs.tf index 5b975443..7496be41 100644 --- a/blueprints/data-solutions/data-platform-minimal/outputs.tf +++ b/blueprints/data-solutions/data-platform-minimal/outputs.tf @@ -58,7 +58,7 @@ output "network" { } output "projects" { - description = "GCP Projects informations." + description = "GCP Projects information." value = { project_number = { common = module.common-project.number diff --git a/fast/stages/3-data-platform/dev/README.md b/fast/stages/3-data-platform/dev/README.md index 17338155..8f8154c7 100644 --- a/fast/stages/3-data-platform/dev/README.md +++ b/fast/stages/3-data-platform/dev/README.md @@ -211,7 +211,7 @@ You can find examples in the `[demo](../../../../blueprints/data-solutions/data- | [demo_commands](outputs.tf#L47) | Demo commands. | | | | [gcs_buckets](outputs.tf#L52) | GCS buckets. | | | | [kms_keys](outputs.tf#L57) | Cloud MKS keys. | | | -| [projects](outputs.tf#L62) | GCP Projects informations. | | | +| [projects](outputs.tf#L62) | GCP Projects information. | | | | [vpc_network](outputs.tf#L67) | VPC network. | | | | [vpc_subnet](outputs.tf#L72) | VPC subnetworks. | | | diff --git a/fast/stages/3-data-platform/dev/outputs.tf b/fast/stages/3-data-platform/dev/outputs.tf index 2eb813b4..bb9956ec 100644 --- a/fast/stages/3-data-platform/dev/outputs.tf +++ b/fast/stages/3-data-platform/dev/outputs.tf @@ -60,7 +60,7 @@ output "kms_keys" { } output "projects" { - description = "GCP Projects informations." + description = "GCP Projects information." value = module.data-platform.projects } From d3739cc0ff59c2dfc454b24a5a98f7f19a7a24e3 Mon Sep 17 00:00:00 2001 From: Alejandro Leal Date: Thu, 29 Jun 2023 22:36:27 -0400 Subject: [PATCH 2/2] Update outputs.tf --- blueprints/data-solutions/data-platform-foundations/outputs.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blueprints/data-solutions/data-platform-foundations/outputs.tf b/blueprints/data-solutions/data-platform-foundations/outputs.tf index ae853da0..5bc93123 100644 --- a/blueprints/data-solutions/data-platform-foundations/outputs.tf +++ b/blueprints/data-solutions/data-platform-foundations/outputs.tf @@ -74,7 +74,7 @@ output "kms_keys" { } output "projects" { - description = "GCP Projects informations." + description = "GCP Projects information." value = { project_number = { dwh-landing = module.dwh-lnd-project.number,