Merge pull request #1078 from rosmo/stateful-disks-deletion-rule-fix

Fixed delete_rule in compute-mig module for stateful disks

modules/compute-mig/README.md

@@ -321,7 +321,7 @@ module "nginx-mig" {
     }
   }
   stateful_disks = {
-    repd-1 = null
+    repd-1 = false
   }
 }
 # tftest modules=2 resources=3

modules/compute-mig/main.tf

@@ -71,7 +71,7 @@ resource "google_compute_instance_group_manager" "default" {
     for_each = var.stateful_disks
     content {
       device_name = stateful_disk.key
-      delete_rule = stateful_disk.value
+      delete_rule = stateful_disk.value ? "ON_PERMANENT_INSTANCE_DELETION" : "NEVER"
     }
   }
 
@@ -161,7 +161,7 @@ resource "google_compute_region_instance_group_manager" "default" {
     for_each = var.stateful_disks
     content {
       device_name = stateful_disk.key
-      delete_rule = stateful_disk.value
+      delete_rule = stateful_disk.value ? "ON_PERMANENT_INSTANCE_DELETION" : "NEVER"
     }
   }
 

tests/modules/compute_mig/test_plan.py

@@ -84,7 +84,7 @@ def test_stateful_mig(plan_runner):
   "Test stateful instances - mig."
 
   stateful_disks = '''{
-    persistent-disk-1 = null
+    persistent-disk-1 = false
   }'''
   _, resources = plan_runner(stateful_disks=stateful_disks)
   assert len(resources) == 1