zecfoundation
/
cloud-foundation-fabric
mirror of https://github.com/ZcashFoundation/cloud-foundation-fabric.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1078 from rosmo/stateful-disks-deletion-rule-fix 

Fixed delete_rule in compute-mig module for stateful disks
This commit is contained in:
Taneli Leppä 2023-01-04 09:14:40 +01:00 committed by GitHub
parent 7adfcad1dc fbf42197a0
commit 344a0b08d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/compute-mig/README.md
View File

@ -321,7 +321,7 @@ module "nginx-mig" {
} }
} }
stateful_disks = { stateful_disks = {
repd-1 = null repd-1 = false
} }
} }
# tftest modules=2 resources=3 # tftest modules=2 resources=3

4
modules/compute-mig/main.tf
View File

@ -71,7 +71,7 @@ resource "google_compute_instance_group_manager" "default" {
for_each = var.stateful_disks for_each = var.stateful_disks
content { content {
device_name = stateful_disk.key device_name = stateful_disk.key
delete_rule = stateful_disk.value delete_rule = stateful_disk.value ? "ON_PERMANENT_INSTANCE_DELETION" : "NEVER"
} }
} }
@ -161,7 +161,7 @@ resource "google_compute_region_instance_group_manager" "default" {
for_each = var.stateful_disks for_each = var.stateful_disks
content { content {
device_name = stateful_disk.key device_name = stateful_disk.key
delete_rule = stateful_disk.value delete_rule = stateful_disk.value ? "ON_PERMANENT_INSTANCE_DELETION" : "NEVER"
} }
} }

2
tests/modules/compute_mig/test_plan.py
View File

@ -84,7 +84,7 @@ def test_stateful_mig(plan_runner):
"Test stateful instances - mig." "Test stateful instances - mig."
stateful_disks = '''{ stateful_disks = '''{
persistent-disk-1 = null persistent-disk-1 = false
}''' }'''
_, resources = plan_runner(stateful_disks=stateful_disks) _, resources = plan_runner(stateful_disks=stateful_disks)
assert len(resources) == 1 assert len(resources) == 1