From 357f6d5939066962663c7fdfb232560c6052b562 Mon Sep 17 00:00:00 2001 From: Ludovico Magnocavallo Date: Wed, 1 Dec 2021 12:08:04 +0100 Subject: [PATCH] depend log sinks from IAM roles, fixes #371 --- modules/folder/main.tf | 4 ++++ modules/organization/main.tf | 5 +++++ modules/project/main.tf | 5 +++++ 3 files changed, 14 insertions(+) diff --git a/modules/folder/main.tf b/modules/folder/main.tf index cab6b7f0..3c23d861 100644 --- a/modules/folder/main.tf +++ b/modules/folder/main.tf @@ -213,6 +213,10 @@ resource "google_logging_folder_sink" "sink" { filter = exclusion.value } } + + depends_on = [ + google_folder_iam_binding.authoritative + ] } resource "google_storage_bucket_iam_member" "gcs-sinks-binding" { diff --git a/modules/organization/main.tf b/modules/organization/main.tf index 22867ca3..e845c549 100644 --- a/modules/organization/main.tf +++ b/modules/organization/main.tf @@ -297,6 +297,11 @@ resource "google_logging_organization_sink" "sink" { filter = exclusion.value } } + depends_on = [ + google_organization_iam_binding.authoritative, + google_organization_iam_member.additive, + google_organization_iam_policy.authoritative, + ] } resource "google_storage_bucket_iam_member" "gcs-sinks-binding" { diff --git a/modules/project/main.tf b/modules/project/main.tf index 30deaf7a..bb4ca986 100644 --- a/modules/project/main.tf +++ b/modules/project/main.tf @@ -299,6 +299,11 @@ resource "google_logging_project_sink" "sink" { filter = exclusion.value } } + + depends_on = [ + google_project_iam_binding.authoritative, + google_project_iam_member.additive + ] } resource "google_storage_bucket_iam_member" "gcs-sinks-binding" {