diff --git a/CHANGELOG.md b/CHANGELOG.md index 11bfa115..ce2c3c61 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file. ### BLUEPRINTS +- [[#1548](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1548)] Minor fixes in Vertex Ai MLOPs blueprint ([javiergp](https://github.com/javiergp)) - [[#1547](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1547)] **incompatible change:** Peering module refactor ([ludoo](https://github.com/ludoo)) - [[#1542](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1542)] Grant IAM rights to service identities in host project ([wiktorn](https://github.com/wiktorn)) - [[#1536](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1536)] **incompatible change:** Update and refactor artifact registry module ([ludoo](https://github.com/ludoo)) @@ -31,6 +32,9 @@ All notable changes to this project will be documented in this file. ### MODULES +- [[#1554](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1554)] Fix in IAM bindings of cloud function v2 module ([apichick](https://github.com/apichick)) +- [[#1551](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1551)] Fix in validation of healthchecks variable ([apichick](https://github.com/apichick)) +- [[#1552](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1552)] Add image path output to ar module ([ludoo](https://github.com/ludoo)) - [[#1550](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1550)] Fix in validation of healthchecks variable ([apichick](https://github.com/apichick)) - [[#1547](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1547)] **incompatible change:** Peering module refactor ([ludoo](https://github.com/ludoo)) - [[#1542](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1542)] Grant IAM rights to service identities in host project ([wiktorn](https://github.com/wiktorn)) diff --git a/blueprints/data-solutions/vertex-mlops/main.tf b/blueprints/data-solutions/vertex-mlops/main.tf index ec2d174a..6879955d 100644 --- a/blueprints/data-solutions/vertex-mlops/main.tf +++ b/blueprints/data-solutions/vertex-mlops/main.tf @@ -116,8 +116,7 @@ module "gcs-bucket" { module "gcs-bucket-cloudbuild" { source = "../../../modules/gcs" project_id = module.project.project_id - name = "${var.prefix}_cloudbuild" - prefix = var.prefix + name = "${module.project.project_id}_cloudbuild" location = var.region storage_class = "REGIONAL" versioning = false @@ -137,10 +136,10 @@ module "vpc-local" { count = local.use_shared_vpc ? 0 : 1 source = "../../../modules/net-vpc" project_id = module.project.project_id - name = "default" + name = "vertex" subnets = [ { - "name" : "default", + "name" : "subnet-${var.region}", "region" : "${var.region}", "ip_cidr_range" : "10.4.0.0/24", "secondary_ip_range" : null diff --git a/modules/cloud-function-v2/main.tf b/modules/cloud-function-v2/main.tf index 23699fc4..71979ee3 100644 --- a/modules/cloud-function-v2/main.tf +++ b/modules/cloud-function-v2/main.tf @@ -155,7 +155,7 @@ resource "google_cloudfunctions2_function" "function" { } resource "google_cloudfunctions2_function_iam_binding" "default" { - for_each = var.iam + for_each = local.iam project = var.project_id location = google_cloudfunctions2_function.function.location cloud_function = google_cloudfunctions2_function.function.name