From b92135a56d272d14feff73e52870c44f4369352f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wiktor=20Niesiob=C4=99dzki?= Date: Sat, 6 Jan 2024 11:46:19 +0000 Subject: [PATCH] Remove null address for PSC null address results in following error: Error creating GlobalAddress: googleapi: Error 400: Invalid value for field 'resource.address': ''. The field is not a valid IP address or does not match the given prefix length, invalid --- modules/net-address/README.md | 6 +----- tests/modules/net_address/examples/psc.yaml | 10 ++-------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/modules/net-address/README.md b/modules/net-address/README.md index e6398303..5ff4f20e 100644 --- a/modules/net-address/README.md +++ b/modules/net-address/README.md @@ -100,16 +100,12 @@ module "addresses" { project_id = var.project_id psc_addresses = { one = { - address = null - network = var.vpc.self_link - } - two = { address = "10.0.0.32" network = var.vpc.self_link } } } -# tftest modules=1 resources=2 inventory=psc.yaml e2e +# tftest modules=1 resources=1 inventory=psc.yaml e2e ``` # IPSec Interconnect addresses diff --git a/tests/modules/net_address/examples/psc.yaml b/tests/modules/net_address/examples/psc.yaml index 3a897e4c..bd57a518 100644 --- a/tests/modules/net_address/examples/psc.yaml +++ b/tests/modules/net_address/examples/psc.yaml @@ -14,18 +14,12 @@ values: module.addresses.google_compute_global_address.psc["one"]: + address: 10.0.0.32 address_type: INTERNAL name: one network: projects/xxx/global/networks/aaa project: project-id purpose: PRIVATE_SERVICE_CONNECT - module.addresses.google_compute_global_address.psc["two"]: - address: 10.0.0.32 - address_type: INTERNAL - name: two - network: projects/xxx/global/networks/aaa - project: project-id - purpose: PRIVATE_SERVICE_CONNECT counts: - google_compute_global_address: 2 + google_compute_global_address: 1