From c420f17636811fbfd673cefc48e9cebffb3adbc7 Mon Sep 17 00:00:00 2001 From: bluPhy Date: Sun, 7 Apr 2024 05:49:07 -0400 Subject: [PATCH] Updating cloud-run-v2 terraform and some typos (#2201) * Updating cloud-run-v2 terraform and some typos Updating modules/cloud-run-v2/main.tf to determine the tcp_socket value Fixin typos in: tests/fixtures.py modules/workstation-cluster/README.md modules/net-lb-int/README.md modules/dataplex/README.md modules/dataform-repository/README.md modules/__docs/20230816-iam-refactor.md CONTRIBUTING.md blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/startup-script.tpl blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/README.md * Update README.md --------- Co-authored-by: Ludovico Magnocavallo Co-authored-by: Ludovico Magnocavallo --- CONTRIBUTING.md | 2 +- .../f5-bigip/f5-bigip-ha-active/README.md | 2 +- .../f5-bigip/f5-bigip-ha-active/startup-script.tpl | 2 +- modules/__docs/20230816-iam-refactor.md | 2 +- modules/dataform-repository/README.md | 2 +- modules/dataplex/README.md | 2 +- modules/net-lb-int/README.md | 4 ++-- modules/workstation-cluster/README.md | 2 +- tests/fixtures.py | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c35d091e..4182daf3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1209,7 +1209,7 @@ The script will create in `` following structure: The `infra` directory contains the sandbox infrastructure as well as all environment variables dumped into `terraform.tfvars` file. The script runs `terraform init` and `terraform apply -auto-approve` in this folder. -The `` has empty `main.tf` where you can paste any example, and it will get all necessary variables from `e2e_tests.auto.tfvars` file. +The `` has empty `main.tf` where you can paste any example, and it will get all necessary variables from `e2e_tests.auto.tfvars` file. If there are any changes to the test sandbox, you can rerun the script and only changes will be applied to the project. diff --git a/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/README.md b/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/README.md index 79333aec..420d627d 100644 --- a/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/README.md +++ b/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/README.md @@ -344,7 +344,7 @@ module "f5-lb" { ## F5 code copyright -This repository usees code from the third-party project [terraform-gcp-bigip-module](https://github.com/F5Networks/terraform-gcp-bigip-module). +This repository uses code from the third-party project [terraform-gcp-bigip-module](https://github.com/F5Networks/terraform-gcp-bigip-module). This code is also licensed as Apache 2.0. diff --git a/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/startup-script.tpl b/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/startup-script.tpl index 56cc4df8..f89ba09f 100644 --- a/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/startup-script.tpl +++ b/blueprints/third-party-solutions/f5-bigip/f5-bigip-ha-active/startup-script.tpl @@ -1,6 +1,6 @@ # Copyright 2014-2019 F5 Networks Inc. # -# This file usees code from the following third-party project: +# This file uses code from the following third-party project: # * [terraform-gcp-bigip-module] - [https://github.com/F5Networks/terraform-gcp-bigip-module] # # The code from this project is licensed under the Apache 2.0 license. diff --git a/modules/__docs/20230816-iam-refactor.md b/modules/__docs/20230816-iam-refactor.md index 80b3e564..e2c51e1f 100644 --- a/modules/__docs/20230816-iam-refactor.md +++ b/modules/__docs/20230816-iam-refactor.md @@ -60,7 +60,7 @@ This variable will not be internally merged in modules with `iam` or `group_iam` ### Additive bindings -Additive bindings have evolved to mimick authoritative ones, but the result is an interface which is bloated (no one uses `iam_additive_members`), and hard to understand and use without triggering dynamic errors. Coverage is also spotty and uneven across modules, and the interface needs to support aliasing of project service accounts in the project module to work around dynamic errors. +Additive bindings have evolved to mimic authoritative ones, but the result is an interface which is bloated (no one uses `iam_additive_members`), and hard to understand and use without triggering dynamic errors. Coverage is also spotty and uneven across modules, and the interface needs to support aliasing of project service accounts in the project module to work around dynamic errors. The `iam_additive` variable is used in a special patterns in data blueprints, to allow code to not mess up existing IAM bindings in an external project on destroy. This pattern only works in a limited set of cases, where principals are passed in via static variables or refer to "magic" static outputs in our modules. This is a simple example of the pattern: diff --git a/modules/dataform-repository/README.md b/modules/dataform-repository/README.md index daf60a27..47699dc1 100644 --- a/modules/dataform-repository/README.md +++ b/modules/dataform-repository/README.md @@ -7,7 +7,7 @@ This module allows managing a dataform repository, allows adding IAM permissions ## Examples -### Simple dataform repository with access configration +### Simple dataform repository with access configuration Simple dataform repository and specifying repository access via the IAM variable. diff --git a/modules/dataplex/README.md b/modules/dataplex/README.md index c858c1d3..bc16be74 100644 --- a/modules/dataplex/README.md +++ b/modules/dataplex/README.md @@ -1,4 +1,4 @@ -# Dataplex instance with lake, zone & assests +# Dataplex instance with lake, zone & assets This module manages the creation of Dataplex instance along with lake, zone & assets in single regions. diff --git a/modules/net-lb-int/README.md b/modules/net-lb-int/README.md index 5f803c1a..7b84cef3 100644 --- a/modules/net-lb-int/README.md +++ b/modules/net-lb-int/README.md @@ -7,7 +7,7 @@ This module allows managing a GCE Internal Load Balancer and integrates the forw - [Referencing existing MIGs](#referencing-existing-migs) - [Externally managed instances](#externally-managed-instances) - [Passing multiple protocols through the load balancers](#passing-multiple-protocols-through-the-load-balancers) - - [Mutiple forwarding rules](#mutiple-forwarding-rules) + - [Multiple forwarding rules](#multiple-forwarding-rules) - [Dual stack (IPv4 and IPv6)](#dual-stack-ipv4-and-ipv6) - [PSC service attachments](#psc-service-attachments) - [End to end example](#end-to-end-example) @@ -146,7 +146,7 @@ module "ilb" { # tftest modules=1 resources=4 ``` -### Mutiple forwarding rules +### Multiple forwarding rules You can add more forwarding rules to your load balancer and override some forwarding rules defaults, including the global access policy, the IP protocol, the IP version and ports. diff --git a/modules/workstation-cluster/README.md b/modules/workstation-cluster/README.md index 4a0592c3..cf454514 100644 --- a/modules/workstation-cluster/README.md +++ b/modules/workstation-cluster/README.md @@ -74,7 +74,7 @@ module "workstation-cluster" { ## Custom image -Example showing how to create a cluster with publicly accesible workstation that run a custom image. +Example showing how to create a cluster with publicly accessible workstation that run a custom image. ```hcl module "workstation-cluster" { diff --git a/tests/fixtures.py b/tests/fixtures.py index e3ff5a06..93b853c3 100644 --- a/tests/fixtures.py +++ b/tests/fixtures.py @@ -392,7 +392,7 @@ def e2e_tfvars_path(): Otherwise, create a unique test environment (in case of multiple workers - as many environments as there are workers), that will be injected into each example test instead of `tests/examples/variables.tf`. - Returns path to tfvars file that contains information about envrionment to use for the tests. + Returns path to tfvars file that contains information about environment to use for the tests. """ if tfvars_path := os.environ.get('TFTEST_E2E_TFVARS_PATH'): # no need to set up the project