Fix TODOs

This commit is contained in:
Lorenzo Caggioni 2022-02-01 07:25:00 +01:00
parent 97b0d57053
commit c533642b85
4 changed files with 5 additions and 5 deletions

View File

@ -123,7 +123,7 @@ We implemented a centralized model for Data Loss Prevention material. Templates
![Centralized Cloud DLP high level diagram](./images/dlp_diagram.png "Centralized Cloud DLP high level diagram")
# How to run this script #TODO
# How to run this script
The Data Platform is meant to be executed by a Service Account (or a regular user) having this minial set of permission:
* **Org level**:
* `"compute.organizations.enableXpnResource"`
@ -135,7 +135,7 @@ The Data Platform is meant to be executed by a Service Account (or a regular use
* `"roles/resourcemanager.folderAdmin"`
* `"roles/resourcemanager.projectCreator"`
* **Cloud KMS Keys** (if Cloud KMS keys are configured):
* `"roles/cloudkms.admin"` or Permissions: `cloudkms.cryptoKeys.getIamPolicy`, `cloudkms.cryptoKeys.list`, `cloudkms.cryptoKeys.setIamPolicyTODO`
* `"roles/cloudkms.admin"` or Permissions: `cloudkms.cryptoKeys.getIamPolicy`, `cloudkms.cryptoKeys.list`, `cloudkms.cryptoKeys.setIamPolicy`
* **on the host project** for the Shared VPC/s
* `"roles/browser"`
* `"roles/compute.viewer"`

View File

@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# tfdoc:file:description TODO
# tfdoc:file:description Core locals
locals {
groups = { for k, v in var.groups : k => "${v}@${var.organization.domain}" }

View File

@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# tfdoc:file:description TODO
# tfdoc:file:description Output variables
output "bigquery-datasets" {
description = "BigQuery datasets."

View File

@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# tfdoc:file:description TODO
# tfdoc:file:description Terraform Variables
variable "composer_config" {
type = object({