diff --git a/examples/data-solutions/dp-foundation/README.md b/examples/data-solutions/dp-foundation/README.md index fced8a48..c982ae59 100644 --- a/examples/data-solutions/dp-foundation/README.md +++ b/examples/data-solutions/dp-foundation/README.md @@ -123,7 +123,7 @@ We implemented a centralized model for Data Loss Prevention material. Templates ![Centralized Cloud DLP high level diagram](./images/dlp_diagram.png "Centralized Cloud DLP high level diagram") -# How to run this script #TODO +# How to run this script The Data Platform is meant to be executed by a Service Account (or a regular user) having this minial set of permission: * **Org level**: * `"compute.organizations.enableXpnResource"` @@ -135,7 +135,7 @@ The Data Platform is meant to be executed by a Service Account (or a regular use * `"roles/resourcemanager.folderAdmin"` * `"roles/resourcemanager.projectCreator"` * **Cloud KMS Keys** (if Cloud KMS keys are configured): - * `"roles/cloudkms.admin"` or Permissions: `cloudkms.cryptoKeys.getIamPolicy`, `cloudkms.cryptoKeys.list`, `cloudkms.cryptoKeys.setIamPolicyTODO` + * `"roles/cloudkms.admin"` or Permissions: `cloudkms.cryptoKeys.getIamPolicy`, `cloudkms.cryptoKeys.list`, `cloudkms.cryptoKeys.setIamPolicy` * **on the host project** for the Shared VPC/s * `"roles/browser"` * `"roles/compute.viewer"` diff --git a/examples/data-solutions/dp-foundation/main.tf b/examples/data-solutions/dp-foundation/main.tf index abcfaa4b..02373c7c 100644 --- a/examples/data-solutions/dp-foundation/main.tf +++ b/examples/data-solutions/dp-foundation/main.tf @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# tfdoc:file:description TODO +# tfdoc:file:description Core locals locals { groups = { for k, v in var.groups : k => "${v}@${var.organization.domain}" } diff --git a/examples/data-solutions/dp-foundation/output.tf b/examples/data-solutions/dp-foundation/output.tf index ce33bdfe..5738c3b4 100644 --- a/examples/data-solutions/dp-foundation/output.tf +++ b/examples/data-solutions/dp-foundation/output.tf @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# tfdoc:file:description TODO +# tfdoc:file:description Output variables output "bigquery-datasets" { description = "BigQuery datasets." diff --git a/examples/data-solutions/dp-foundation/variables.tf b/examples/data-solutions/dp-foundation/variables.tf index 3f383a86..59d4906c 100644 --- a/examples/data-solutions/dp-foundation/variables.tf +++ b/examples/data-solutions/dp-foundation/variables.tf @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# tfdoc:file:description TODO +# tfdoc:file:description Terraform Variables variable "composer_config" { type = object({