From de883957fea39fe22dd37b5ccc9f2f97971de209 Mon Sep 17 00:00:00 2001 From: lcaggio Date: Wed, 4 Oct 2023 12:15:51 +0200 Subject: [PATCH] Minimal Data Platform - Fix (#1730) * Fix * Fix README * Fix data platform minimal tests --------- Co-authored-by: Julio Castillo --- .../data-solutions/data-platform-minimal/02-composer.tf | 1 + .../data-solutions/data-platform-minimal/02-processing.tf | 4 +--- blueprints/data-solutions/data-platform-minimal/README.md | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/blueprints/data-solutions/data-platform-minimal/02-composer.tf b/blueprints/data-solutions/data-platform-minimal/02-composer.tf index c250b1fd..e82008c3 100644 --- a/blueprints/data-solutions/data-platform-minimal/02-composer.tf +++ b/blueprints/data-solutions/data-platform-minimal/02-composer.tf @@ -24,6 +24,7 @@ locals { DP_REGION = var.region LAND_PRJ = module.land-project.project_id LAND_GCS = module.land-cs-0.url + LAND_BQ_DATASET = module.land-bq-0.dataset_id PHS_CLUSTER_NAME = try(module.processing-dp-historyserver[0].name, "") PROCESSING_GCS = module.processing-cs-0.url PROCESSING_PRJ = module.processing-project.project_id diff --git a/blueprints/data-solutions/data-platform-minimal/02-processing.tf b/blueprints/data-solutions/data-platform-minimal/02-processing.tf index 720e2a81..b00e250d 100644 --- a/blueprints/data-solutions/data-platform-minimal/02-processing.tf +++ b/blueprints/data-solutions/data-platform-minimal/02-processing.tf @@ -105,9 +105,7 @@ module "processing-project" { iam_bindings_additive = ( var.project_config.billing_account_id != null ? {} : local.iam_prc_additive ) - compute_metadata = { - enable-oslogin = "false" - } + services = [ "bigquery.googleapis.com", "bigqueryreservation.googleapis.com", diff --git a/blueprints/data-solutions/data-platform-minimal/README.md b/blueprints/data-solutions/data-platform-minimal/README.md index 62b30acd..42d746e5 100644 --- a/blueprints/data-solutions/data-platform-minimal/README.md +++ b/blueprints/data-solutions/data-platform-minimal/README.md @@ -229,7 +229,7 @@ module "data-platform" { prefix = "myprefix" } -# tftest modules=23 resources=138 +# tftest modules=23 resources=137 ``` ## Customizations