Merge pull request #1898 from GoogleCloudPlatform/wiktorn-fix-logging-bucket-tests

Use unique names for logging buckets in examples

modules/folder/README.md

@@ -225,7 +225,7 @@ module "bucket" {
   source      = "./fabric/modules/logging-bucket"
   parent_type = "project"
   parent      = var.project_id
-  id          = "bucket"
+  id          = "${var.prefix}-bucket"
 }
 
 module "folder-sink" {

modules/organization/README.md

@@ -291,7 +291,7 @@ module "bucket" {
   source      = "./fabric/modules/logging-bucket"
   parent_type = "project"
   parent      = var.project_id
-  id          = "bucket"
+  id          = "${var.prefix}-bucket"
 }
 
 module "org" {

modules/project/README.md

@@ -461,7 +461,7 @@ module "bucket" {
   source      = "./fabric/modules/logging-bucket"
   parent_type = "project"
   parent      = var.project_id
-  id          = "bucket"
+  id          = "${var.prefix}-bucket"
 }
 
 module "project-host" {
@@ -822,7 +822,7 @@ module "bucket" {
   source      = "./fabric/modules/logging-bucket"
   parent_type = "project"
   parent      = var.project_id
-  id          = "bucket"
+  id          = "${var.prefix}-bucket"
 }
 # tftest modules=7 resources=53 inventory=data.yaml e2e
 ```

tests/modules/project/examples/data.yaml

@@ -15,7 +15,7 @@
 
 values:
   module.bucket.google_logging_project_bucket_config.bucket[0]:
-    bucket_id: bucket
+    bucket_id: test-bucket
     project: project-id
   module.create-project.google_project.project[0]:
     billing_account: 123456-123456-123456