Merge branch 'master' into lcaggio/dp-dc-policy-tag

2022-04-04 15:38:52 +02:00 · 2022-04-04 15:38:52 +02:00 · ec3832760d
parent f1a404a5d4 bc2ad7dec3
commit ec3832760d
2 changed files with 2 additions and 1 deletions
--- a/examples/data-solutions/gcs-to-bq-with-least-privileges/main.tf
+++ b/examples/data-solutions/gcs-to-bq-with-least-privileges/main.tf
@ -44,6 +44,7 @@ locals {
      module.service-account-df.iam_email
    ]
    # common roles
+    "roles/logging.admin" = var.data_eng_principals
    "roles/logging.logWriter" = [
      module.service-account-bq.iam_email,
      module.service-account-landing.iam_email,
--- a/tests/examples/data_solutions/gcs_to_bq_with_least_privileges/test_plan.py
+++ b/tests/examples/data_solutions/gcs_to_bq_with_least_privileges/test_plan.py
@ -24,4 +24,4 @@ def test_resources(e2e_plan_runner):
  "Test that plan works and the numbers of resources is as expected."
  modules, resources = e2e_plan_runner(FIXTURES_DIR)
  assert len(modules) == 11
-  assert len(resources) == 46
+  assert len(resources) == 47