zecfoundation
/
cloud-foundation-fabric
mirror of https://github.com/ZcashFoundation/cloud-foundation-fabric.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update CONTRIBUTING.md 

Suggest change of wording related to `terraform format`: should be done from the top, recursively, and after `pytest` step, because fixtures are also going to be checked for linting during PR.
This commit is contained in:
arsenyspb 2021-12-15 18:41:51 +08:00 committed by GitHub
parent 38b8ea1757
commit ece8c0896f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -7,8 +7,8 @@ The basic process is pretty simple:
* Fork the Project
* Create your Feature Branch<br>`git checkout -b feature/AmazingFeature`
* Commit your Changes<br>`git commit -m 'Add some AmazingFeature`
* Make sure Terraform linting is ok (hint: `terraform format`)
* Make sure tests pass!<br>`pytest # in the root folder`
* Make sure Terraform linting is ok (hint: `terraform fmt -recursive` in the root folder)
* Make sure any changes to variables and outputs are reflected in READMEs<br>`./tools/tfdoc.py [changed folder]`
* Push to the Branch<br>`git push origin feature/AmazingFeature`
* Open a Pull Request