Merge pull request #1432 from GoogleCloudPlatform/jccb/fix-1431
Make internal/external addresses optional in compute-vm
This commit is contained in:
commit
eddef7e5b6
|
@ -1,4 +1,4 @@
|
|||
# Copyright 2022 Google LLC
|
||||
# Copyright 2023 Google LLC
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||
# you may not use this file except in compliance with the License.
|
||||
|
@ -68,7 +68,6 @@ module "nodes" {
|
|||
nat = false
|
||||
addresses = {
|
||||
internal = module.ip-addresses.internal_addresses[each.value].address
|
||||
external = null
|
||||
}
|
||||
}]
|
||||
|
||||
|
@ -122,7 +121,6 @@ module "witness" {
|
|||
nat = false
|
||||
addresses = {
|
||||
internal = module.ip-addresses.internal_addresses[each.value].address
|
||||
external = null
|
||||
}
|
||||
}]
|
||||
|
||||
|
|
|
@ -152,7 +152,6 @@ module "nva" {
|
|||
subnetwork = module.landing-untrusted-vpc.subnet_self_links["${each.value.region}/landing-untrusted-default-${each.value.shortname}"]
|
||||
nat = false
|
||||
addresses = {
|
||||
external = null
|
||||
internal = google_compute_address.nva_static_ip_untrusted[each.key].address
|
||||
}
|
||||
},
|
||||
|
@ -161,7 +160,6 @@ module "nva" {
|
|||
subnetwork = module.landing-trusted-vpc.subnet_self_links["${each.value.region}/landing-trusted-default-${each.value.shortname}"]
|
||||
nat = false
|
||||
addresses = {
|
||||
external = null
|
||||
internal = google_compute_address.nva_static_ip_trusted[each.key].address
|
||||
}
|
||||
}
|
||||
|
|
|
@ -215,7 +215,7 @@ module "vm-internal-ip" {
|
|||
network_interfaces = [{
|
||||
network = var.vpc.self_link
|
||||
subnetwork = var.subnet.self_link
|
||||
addresses = { external = null, internal = "10.0.0.2" }
|
||||
addresses = { internal = "10.0.0.2" }
|
||||
}]
|
||||
}
|
||||
|
||||
|
@ -228,7 +228,7 @@ module "vm-external-ip" {
|
|||
network = var.vpc.self_link
|
||||
subnetwork = var.subnet.self_link
|
||||
nat = true
|
||||
addresses = { external = "8.8.8.8", internal = null }
|
||||
addresses = { external = "8.8.8.8" }
|
||||
}]
|
||||
}
|
||||
# tftest modules=2 resources=2 inventory=ips.yaml
|
||||
|
@ -507,7 +507,7 @@ module "instance-group" {
|
|||
| name | description | type | required | default |
|
||||
|---|---|:---:|:---:|:---:|
|
||||
| [name](variables.tf#L182) | Instance name. | <code>string</code> | ✓ | |
|
||||
| [network_interfaces](variables.tf#L187) | Network interfaces configuration. Use self links for Shared VPC, set addresses to null if not needed. | <code title="list(object({ nat = optional(bool, false) network = string subnetwork = string addresses = optional(object({ internal = string external = string }), null) alias_ips = optional(map(string), {}) nic_type = optional(string) }))">list(object({…}))</code> | ✓ | |
|
||||
| [network_interfaces](variables.tf#L187) | Network interfaces configuration. Use self links for Shared VPC, set addresses to null if not needed. | <code title="list(object({ nat = optional(bool, false) network = string subnetwork = string addresses = optional(object({ internal = optional(string) external = optional(string) }), null) alias_ips = optional(map(string), {}) nic_type = optional(string) }))">list(object({…}))</code> | ✓ | |
|
||||
| [project_id](variables.tf#L224) | Project id. | <code>string</code> | ✓ | |
|
||||
| [zone](variables.tf#L283) | Compute zone. | <code>string</code> | ✓ | |
|
||||
| [attached_disk_defaults](variables.tf#L17) | Defaults for attached disks options. | <code title="object({ auto_delete = optional(bool, false) mode = string replica_zone = string type = string })">object({…})</code> | | <code title="{ auto_delete = true mode = "READ_WRITE" replica_zone = null type = "pd-balanced" }">{…}</code> |
|
||||
|
|
|
@ -1,5 +1,5 @@
|
|||
/**
|
||||
* Copyright 2022 Google LLC
|
||||
* Copyright 2023 Google LLC
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
|
@ -191,8 +191,8 @@ variable "network_interfaces" {
|
|||
network = string
|
||||
subnetwork = string
|
||||
addresses = optional(object({
|
||||
internal = string
|
||||
external = string
|
||||
internal = optional(string)
|
||||
external = optional(string)
|
||||
}), null)
|
||||
alias_ips = optional(map(string), {})
|
||||
nic_type = optional(string)
|
||||
|
|
Loading…
Reference in New Issue