Commit Graph

191 Commits

Author SHA1 Message Date
Julio Castillo 513fdfe91a Make directive for supporting files in examples more explicit 2022-12-18 14:00:19 +01:00
Julio Castillo e629a997d1 Only set partitioned table when sink type is bigquery
Fixes 990
2022-11-22 15:48:48 +01:00
Julio Castillo 2cd74823b1 Generate files based on readme contents 2022-11-18 17:48:52 +01:00
Julio Castillo b2510ea4cf Fix org policies factories 2022-11-18 17:48:52 +01:00
Julio Castillo 5cfa1062cc Ensure inline README file match fixture files 2022-11-18 17:48:52 +01:00
Julio Castillo 7be3288cc7 Add tests for factory examples 2022-11-18 17:48:52 +01:00
Miren Esnaola 3501d20785 Apigee module and blueprint 2022-11-16 19:49:26 +01:00
Julio Castillo c83a7de076 Remove as_logging_destination 2022-11-12 19:24:41 +01:00
Julio Castillo 8fe19ad7c2 Rename bigquery_use_partitioned_table 2022-11-12 11:30:34 +01:00
Julio Castillo 486d398c7d Update logging sink to tf1.3 in resman modules 2022-11-11 19:22:05 +01:00
Natalia Strelkova d96f95c2b6 cannot instead of can not 2022-11-11 11:56:47 +00:00
Natalia Strelkova d5d1d9eb34 terraform formatting fixed 2022-11-10 15:11:38 +00:00
Natalia Strelkova 68c3b13d6a prefix variable consistency across modules 2022-11-10 15:05:53 +00:00
Julio Castillo 649bedc291
Update README.md 2022-11-03 13:19:02 +01:00
Julio Castillo e29957c394
Update README.md 2022-11-03 13:18:21 +01:00
Julio Castillo 4b278a1533 Update variable description 2022-11-03 12:35:50 +01:00
Julio Castillo f64c43e893 Add org policy factory example 2022-11-03 12:12:50 +01:00
Julio Castillo 3e18575fad Add factory support for new org policies 2022-11-03 11:41:53 +01:00
Julio Castillo 38e761c3a8 Add test that ensures the implementation of org policies is consistent 2022-11-02 10:41:38 +01:00
Ludovico Magnocavallo 8c51a2a386
Enable org policy service and add README notice to modules (#936)
* enable org policy service and add README notice to modules

* fix tests
2022-11-01 14:25:07 +01:00
Julio Castillo ad420138ad Fix readme examples 2022-10-28 17:49:44 +02:00
Julio Castillo f44f4a74dc Fix module tests 2022-10-28 17:49:44 +02:00
Julio Castillo b23d07b0c6 Update project/folder/module to use new org policies API and tf1.3 optionals. 2022-10-28 17:49:44 +02:00
Julio Castillo 1a3bb25917 Update provider version (needed for dns logging support). 2022-10-25 12:15:02 +02:00
Ludovico Magnocavallo e8056577ce
Refactor GKE nodepool and blueprints (#875)
* first shot, untested

* example tests working

* module tests

* work on gke blueprints

* multitenant fleet doc examples

* fix gke hub doc examples

* blueprint tests

* move master range to vpc config

* fast stage 3 gke test

* tfdoc

* bump provider versions

* and bump provider again to latest
2022-10-12 12:59:36 +02:00
Natalia Strelkova 5dbc61cb8c temporary revert to Terraform 1.3.1 to support Cloud Shell 2022-10-10 09:19:55 +00:00
Ludovico Magnocavallo a0171b2c49
Bump terraform required version (#864)
* bump terraform required version

* fix test

* debug test

* debug test

* disable test

* fix CI file, bump terraform action version
2022-10-07 12:51:56 +02:00
Julio Castillo 894647ff9e Leverage new shared VPC project config defaults across the repo 2022-10-07 08:55:47 +02:00
Julio Castillo 07249194dd Fix README 2022-10-06 15:52:09 +02:00
Julio Castillo 1955a61159 Make project shared vpc fields optional 2022-10-06 15:48:37 +02:00
ddaluka 9c2a53f7a9
Management of GCP project default service accounts (#844)
* Added change for default service account deprivilege setting

* Updated readme and variable name

* Updated readme and variable name
2022-09-29 15:10:07 +02:00
Julio Castillo ac835b6d50 Update terraform version 2022-09-28 11:28:05 +02:00
lcaggio 495a5bbfff Add Artifact registry Service Identity SA creation. 2022-09-20 10:36:12 +02:00
Julio Castillo 67c031c41c Change `modules/project` service_config default 2022-09-09 09:23:09 +02:00
Julio Castillo 5e1974b9c7 Merge branch 'master' into fast/gke2 2022-09-07 13:39:17 +02:00
Julio Castillo a866182161 Test documentation examples in the examples/ folder 2022-09-06 17:46:09 +02:00
Julio Castillo 52e7e0517a Merge branch 'master' into fast/gke2 2022-08-24 15:37:15 +02:00
Simone Ruffilli a29faa7f8c
instance_termination_action must be set for compute-vm spot instances (#778)
* Bumped providers version
* Adds ability to control instance_termination_action for SpotVMs
2022-08-20 18:37:17 +02:00
Ludovico Magnocavallo 531acf3476 Merge remote-tracking branch 'origin/master' into fast/gke2 2022-08-02 19:15:07 +02:00
Miren Esnaola e6dbf9bf01 Shared vpc service fixes 2022-08-02 18:22:31 +02:00
Miren Esnaola 0920ac3877 Shared vpc service fixes 2022-08-02 18:21:08 +02:00
Ludovico Magnocavallo 133fd07823 unfinished gke hub IAM 2022-07-29 11:31:34 +02:00
Ludovico Magnocavallo b20ab65756
GKE hub module refactor (#760)
GKE hub module refactor 
Co-authored-by: Daniel Marzini <danielmarzini@users.noreply.github.com>
Co-authored-by: Miren Esnaola <mirene@google.com>
2022-07-29 08:39:25 +02:00
apichick 4069e42b66
Merge branch 'master' into shared-vpc-host-dependency 2022-07-21 14:38:31 +02:00
Miren Esnaola f153ab4614 Added dependency on google_compute_shared_vpc_host_project.shared_vpc_host to project_id output and modified tests 2022-07-21 14:11:21 +02:00
Miren Esnaola 6275f1bafb Added gkehub.googleapis.com to jit services 2022-07-21 10:06:47 +02:00
Miren Esnaola 824353a42b Added servicemesh feature to GKE hub and included fleet robot service account in projectmodule 2022-07-15 17:58:39 +02:00
Julio Castillo 07b00c34fe Bump providers versions and pin versions for tests 2022-06-28 10:20:40 +02:00
Julio Castillo 0bf1880431 Fix FAST audit logs when using pubsub as destination
This commit also splits each organization-level logging sink of type
`logging` to a separate logging bucket.
2022-06-10 12:25:26 +02:00
Ludovico Magnocavallo 5e8b06fc85
Initial version of the Contributor's Guide (#666)
* fix IAM in examples

* WIP

* fix service identities IAM example

* design principles

* toc anchors

* fix ordering

* style guide

* checks

* example tests

* tests and tools

* fix project example test

* address typos

* address comments

* address last comments
2022-06-06 15:12:28 +02:00
Ludovico Magnocavallo ab646f38ed
Bump provider versions to >= 4.17.0, terraform to >= 1.1.0 (#634)
* bump provider versions to >= 4.17.0, terraform to >= 1.1.0

* bump teraform version in lint check, edit CHANGELOG
2022-04-17 13:55:40 +02:00
Ludovico Magnocavallo a34823e2d0
Add monitoring notification service identity to project module (#630)
* add monitoring notification service identity

* linting
2022-04-15 01:59:00 +02:00
lcaggio 15cdd179c6
Merge branch 'master' into lcaggio/sql-kms 2022-04-13 09:12:48 +02:00
Ludovico Magnocavallo 420c4de437
Update README.md 2022-04-13 09:10:56 +02:00
Ludovico Magnocavallo 4e1d06fd75
Update README.md 2022-04-13 09:08:01 +02:00
Ludovico Magnocavallo 874e9a57c7
Update README.md 2022-04-13 09:06:18 +02:00
Ludovico Magnocavallo 53c9431c98
Improve project module README (#627)
* improve module README

* Fix a few typos

Co-authored-by: Julio Castillo <jccb@google.com>
2022-04-13 09:05:28 +02:00
Julio Castillo 1f254880b9 Add sqladmin to project jit_si and fix some documentation 2022-04-13 00:22:54 +02:00
Lorenzo Caggioni c7c77541fb Add KMS on CloudSQL module 2022-04-12 19:01:34 +02:00
Ludovico Magnocavallo fef3ed8c93
Fix missing service networking identity in project, PSA (#585)
* test

* test

* test

* fix

* tfdoc

* fix tests

* fix tests
2022-03-17 14:29:28 +01:00
apichick ef1542c1f1
Fixed problem when destroying shared VPC host project (#582) 2022-03-16 07:34:09 +01:00
Ludovico Magnocavallo 0b5ed8b7ef
Add support for resource management tags and tag bindings (#552)
* organization module

* folder module

* project module

* fix project binding

* use id instead of name for references

* kms module

* compute-vm

* fix compute-vm
2022-02-20 11:14:18 +01:00
Julio Castillo ca7dc0e7a2 Add service account prefix to member bindings 2022-02-09 18:22:27 +01:00
Ludovico Magnocavallo 40cb46e1cc
Add support for Shared VPC service IAM to project module (#525)
* project module changes

* fix examples

* add comments in module code

* re-enable nullable on svpc variables

* project factory

* Tests still failing (#526)

* fix pf

* tfdoc

* pf test boilerplate

Co-authored-by: Simone Ruffilli <sruffilli@google.com>
2022-02-09 11:06:51 +01:00
Julio Castillo 52a182ddbd Switch project module to beta provider for SVPC resources 2022-02-04 16:21:00 +01:00
Julio Castillo 52c4b608c2 Rename tf files to use dashes 2022-02-04 08:45:49 +01:00
Simone Ruffilli abb6b50a46
Add periods at the end of each description field where missing (#478) 2022-01-31 10:45:34 +01:00
Julio Castillo e2abd772f2
Update resman modules (#475)
* Make logging sinks in different resources use the same API

* Split resman modules in multiple files. Add nullables where applicable
2022-01-29 19:35:33 +01:00
Julio Castillo cf423998f0 Align tftest syntax with tdoc
This commit changes the token separator for inline examples from a
semicolon to a space
2022-01-28 21:34:15 +01:00
Ludovico Magnocavallo 3717548c25 edit variable description so table does not overflow 2022-01-22 16:12:03 +01:00
Julio Castillo 31f625f149 Link vars and outputs from README 2022-01-22 14:15:16 +01:00
Ludovico Magnocavallo 9a533180a0
Refactor project module, support per-file tags in tfdoc (#450)
* add support for in-doc tfdoc options overrides

* clean up project module

* add file description tags

* only output module and resource columns in tfdoc file table if they exist

* update fast READMEs

* fix check docs
2022-01-22 11:34:18 +01:00
lcaggio a97c606253
Support service dependencies for crypto key bindings in project module (#443)
* Support services that require crypto/decrypt role on robot service accounts

* delete test and upload refactored implementation

* fix duplicate key on dependent services, add tests

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
2022-01-22 08:32:13 +01:00
Roberto Jung Drebes b99e33ce5b fix recreation of resources that depend on project_id on pre-existing projects when data source refresh is triggered 2022-01-21 17:16:20 +00:00
Lorenzo Caggioni 27383fa0a2 Add missing Service Identity Accounts 2022-01-17 09:04:19 +01:00
Julio Castillo 5cc6a62dec Remove unused variables, use regional resources, generate command as output 2022-01-14 16:53:15 +01:00
Simone Ruffilli ee25965c89
Copyright bump (#410) 2022-01-01 15:52:31 +01:00
Ludovico Magnocavallo 2bc5f7d33c
update tfdoc (#404) 2021-12-30 10:56:19 +01:00
Julio Castillo 0c21fecff8
Add metric scopes support (#397)
* Add metric scopes support

* Fix typo

* new tfdoc block in README

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
2021-12-21 09:22:10 +01:00
Ludovico Magnocavallo 1ac3fe4460
New tfdoc version (#396)
* update tfdoc

* rewrite check docs, refactor tfdoc replace, regenerate modules READMEs

* remove dead code from check docs

* do not fail on missing variable files in check docs

* fix typos
2021-12-21 08:51:51 +01:00
Ludovico Magnocavallo 357f6d5939 depend log sinks from IAM roles, fixes #371 2021-12-01 12:08:04 +01:00
Ludovico Magnocavallo f6775aca1b
Use the same versions file everywhere, pin to tf 1.0+ provider 4.0+ (#355)
* add default versions file, remove old providers and versions

* use default versions file everywhere

* fix kms module

* re-add provider configuration for data platform step 2

* update kms module outputs sorting

* update kms documentation

* fix data solutions tests

* fix GKE workload identity attribute name

* work around firewall provider issue in datafusion example
2021-11-03 15:05:43 +01:00
Christopher Avila e42383eab9 update var to skip_delete per feedback 2021-11-01 11:33:24 -05:00
Christopher Avila 3663151465 format project variables 2021-11-01 11:22:30 -05:00
Christopher Avila 88c6af3dbb Add a project_skip_delete variable to optionally let the project stick around after the resources are destroyed. 2021-11-01 10:59:27 -05:00
Julio Castillo 1d13e3e624 Add more validations to linter
- Ensure all variables and outputs are sorted
- Ensure all variables and outputs have a description
- Add data-solutions/data-platform-foundations to linter

Fix all modules to follow these new conventions.
2021-10-08 18:26:04 +02:00
Julio Castillo cb7c65135e
Update CI processes (#296)
- Upgrade to latest terraform version (1.0.4)
- Remove tflint from linting pipeline (was not doing anything)
- Add terraform fmt check to linting pipeline
- Pass all code through terraform fmt
2021-08-12 17:30:53 +02:00
Ludovico Magnocavallo 83e469b07f
Update main.tf 2021-07-28 18:47:53 +02:00
sly92 804ce9bdc4
Add new variable for flexibility between project id & name (#287)
* add new variable for flexibility between project id & name

* remove random feature & use new variable

* remove project_id variable & use local descriptive name variable

* fix bad project_id output & avoid confusing name

* update readme

* Update main.tf

Co-authored-by: slaheddine_bejaoui.ext <slaheddine_bejaoui.ext@orange.com>
Co-authored-by: Ludovico Magnocavallo <ludo@qix.it>
2021-07-28 18:08:51 +02:00
Julio Castillo 0ce81743f2
Update CAI example (#274)
* Add Asset Inventory API to project module

* Create feed from terraform in CAI example

* Fix tests

* sort services

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
2021-07-08 08:57:27 +02:00
lcaggio 3d84897b4b
Create pubsub service identity if service is enabled (#270)
* Create  service identity if service is enabled

* remove dry run mode

* fix tests

* Improve for_each logic
2021-06-25 09:26:33 +02:00
Lorenzo Caggioni f3390839ab Fix dependencies 2021-06-15 09:44:15 +02:00
Lorenzo Caggioni d03773df46 Fix dependencies
Fix role
2021-06-15 00:54:59 +02:00
Lorenzo Caggioni 741de90eed Fix test 2021-06-14 19:03:02 +02:00
Lorenzo Caggioni 12e69c71e3 Add Service Identity for Secret Manager 2021-06-14 18:35:53 +02:00
lcaggio 1a7fe48c46
Merge pull request #263 from terraform-google-modules/lcaggio-kms-prj
Add IAM cryptDecrypt role to robot service account on specified keys
2021-06-11 18:12:58 +02:00
Lorenzo Caggioni 4a2ba0c36c Add example 2021-06-11 18:02:35 +02:00
Lorenzo Caggioni 136fe03e1d Remove extralines 2021-06-11 17:41:19 +02:00
Lorenzo Caggioni dc01db0426 Update Readme and rename variable 2021-06-11 17:38:27 +02:00
Lorenzo Caggioni 476d2c79e9 Add IAM cryptDecrypt role to robo service account on specified keys 2021-06-11 16:00:20 +02:00