Expose signing share in ciphersuite libraries (#404)

* Add SigningShare to ciphersuite libraries (#403)

* Update ciphersuite libraries to use own implementation of SigningShare and not generic (#403)

frost-core/CHANGELOG.md

@@ -6,6 +6,8 @@ Entries are listed in reverse chronological order.
 
 ## 0.5.0
 
+* add SigningShare type to ciphersuite libraries
+
 ## Released
 
 ## 0.4.0

frost-ed25519/src/lib.rs

@@ -257,6 +257,9 @@ pub mod keys {
     /// .into(), which under the hood also performs validation.
     pub type SecretShare = frost::keys::SecretShare<E>;
 
+    /// A secret scalar value representing a signer's share of the group secret.
+    pub type SigningShare = frost::keys::SigningShare<E>;
+
     /// A FROST(Ed25519, SHA-512) keypair, which can be generated either by a trusted dealer or using
     /// a DKG.
     ///
@@ -291,7 +294,7 @@ pub mod keys {
 
 /// FROST(Ed25519, SHA-512) Round 1 functionality and types.
 pub mod round1 {
-    use frost_core::frost::keys::SigningShare;
+    use crate::keys::SigningShare;
 
     use super::*;
 
@@ -314,7 +317,7 @@ pub mod round1 {
     /// operation.
     pub fn commit<RNG>(
         participant_identifier: frost::Identifier<E>,
-        secret: &SigningShare<E>,
+        secret: &SigningShare,
         rng: &mut RNG,
     ) -> (SigningNonces, SigningCommitments)
     where

frost-ed448/src/lib.rs

@@ -251,6 +251,9 @@ pub mod keys {
     /// .into(), which under the hood also performs validation.
     pub type SecretShare = frost::keys::SecretShare<E>;
 
+    /// A secret scalar value representing a signer's share of the group secret.
+    pub type SigningShare = frost::keys::SigningShare<E>;
+
     /// A FROST(Ed448, SHAKE256) keypair, which can be generated either by a trusted dealer or using
     /// a DKG.
     ///
@@ -285,7 +288,7 @@ pub mod keys {
 
 /// FROST(Ed448, SHAKE256) Round 1 functionality and types.
 pub mod round1 {
-    use frost_core::frost::keys::SigningShare;
+    use crate::keys::SigningShare;
 
     use super::*;
 
@@ -308,7 +311,7 @@ pub mod round1 {
     /// operation.
     pub fn commit<RNG>(
         participant_identifier: frost::Identifier<E>,
-        secret: &SigningShare<E>,
+        secret: &SigningShare,
         rng: &mut RNG,
     ) -> (SigningNonces, SigningCommitments)
     where

frost-p256/src/lib.rs

@@ -281,6 +281,9 @@ pub mod keys {
     /// .into(), which under the hood also performs validation.
     pub type SecretShare = frost::keys::SecretShare<P>;
 
+    /// A secret scalar value representing a signer's share of the group secret.
+    pub type SigningShare = frost::keys::SigningShare<P>;
+
     /// A FROST(P-256, SHA-256) keypair, which can be generated either by a trusted dealer or using
     /// a DKG.
     ///
@@ -315,7 +318,7 @@ pub mod keys {
 
 /// FROST(P-256, SHA-256) Round 1 functionality and types.
 pub mod round1 {
-    use frost_core::frost::keys::SigningShare;
+    use crate::keys::SigningShare;
 
     use super::*;
 
@@ -338,7 +341,7 @@ pub mod round1 {
     /// operation.
     pub fn commit<RNG>(
         participant_identifier: frost::Identifier<P>,
-        secret: &SigningShare<P>,
+        secret: &SigningShare,
         rng: &mut RNG,
     ) -> (SigningNonces, SigningCommitments)
     where

frost-ristretto255/src/lib.rs

@@ -245,6 +245,9 @@ pub mod keys {
     /// .into(), which under the hood also performs validation.
     pub type SecretShare = frost::keys::SecretShare<R>;
 
+    /// A secret scalar value representing a signer's share of the group secret.
+    pub type SigningShare = frost::keys::SigningShare<R>;
+
     /// A FROST(ristretto255, SHA-512) keypair, which can be generated either by a trusted dealer or using
     /// a DKG.
     ///
@@ -279,7 +282,7 @@ pub mod keys {
 
 /// FROST(ristretto255, SHA-512) Round 1 functionality and types.
 pub mod round1 {
-    use frost_core::frost::keys::SigningShare;
+    use crate::keys::SigningShare;
 
     use super::*;
 
@@ -302,7 +305,7 @@ pub mod round1 {
     /// operation.
     pub fn commit<RNG>(
         participant_identifier: frost::Identifier<R>,
-        secret: &SigningShare<R>,
+        secret: &SigningShare,
         rng: &mut RNG,
     ) -> (SigningNonces, SigningCommitments)
     where

frost-secp256k1/src/lib.rs

@@ -280,6 +280,9 @@ pub mod keys {
     /// .into(), which under the hood also performs validation.
     pub type SecretShare = frost::keys::SecretShare<S>;
 
+    /// A secret scalar value representing a signer's share of the group secret.
+    pub type SigningShare = frost::keys::SigningShare<S>;
+
     /// A FROST(secp256k1, SHA-256) keypair, which can be generated either by a trusted dealer or using
     /// a DKG.
     ///
@@ -314,7 +317,7 @@ pub mod keys {
 
 /// FROST(secp256k1, SHA-256) Round 1 functionality and types.
 pub mod round1 {
-    use frost_core::frost::keys::SigningShare;
+    use crate::keys::SigningShare;
 
     use super::*;
 
@@ -337,7 +340,7 @@ pub mod round1 {
     /// operation.
     pub fn commit<RNG>(
         participant_identifier: frost::Identifier<S>,
-        secret: &SigningShare<S>,
+        secret: &SigningShare,
         rng: &mut RNG,
     ) -> (SigningNonces, SigningCommitments)
     where