Commit Graph

398 Commits

Author SHA1 Message Date
Conrado Gouvea 828279d847
Hash serialized scalars entirely; update test vectors to V10 (#139)
* v9

* update to v10 vectors

* update spec links

* Make Rustdoc happy

* Make Rustdoc happy

* refactor coefficient generation into a function

* rustdoc

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-10-03 18:41:02 +00:00
Conrado Gouvea 45d16cb801
add H5; update to V8 (#137)
* add H5; update to V8

* Link H4

* Link H5

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-10-03 04:31:58 -04:00
dependabot[bot] 897b8bd8c9 Bump reviewdog/action-actionlint from 1.31.0 to 1.32.0
Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.31.0 to 1.32.0.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](https://github.com/reviewdog/action-actionlint/compare/v1.31.0...v1.32.0)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-03 04:14:09 -04:00
Conrado Gouvea 57bf58a24e
use per-signer Rho per V7 spec (#112)
* use per-signer Rho per V7 spec

* Update frost-core/src/frost.rs

* Update frost-core/src/frost.rs

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-10-03 04:13:25 -04:00
dependabot[bot] 50f9524d4c
Bump reviewdog/action-actionlint from 1.30.0 to 1.31.0 (#135)
Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](https://github.com/reviewdog/action-actionlint/compare/v1.30.0...v1.31.0)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-26 21:07:12 +00:00
dependabot[bot] 76e8cb7a2e
Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#128)
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v3.1.0...v3.1.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-26 20:51:08 +00:00
Conrado Gouvea 66914e6f92
add ristretto255 docs (#110)
* add ristretto255 docs

* mention FROST(ristretto255, SHA-512) explicitly

* Update frost-ristretto255/src/lib.rs

* Update frost-ristretto255/src/lib.rs

* Update frost-ristretto255/src/lib.rs

* Update frost-ristretto255/src/lib.rs

* "# Security'

* rustfmt

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-09-19 19:59:14 +00:00
Conrado Gouvea 8f2af1987c derive verification share and group public key from commitments 2022-09-19 15:24:21 -04:00
dependabot[bot] 0f18d63f5a Bump reviewdog/action-actionlint from 1.29.0 to 1.30.0
Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.29.0 to 1.30.0.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](https://github.com/reviewdog/action-actionlint/compare/v1.29.0...v1.30.0)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-19 15:11:44 -04:00
Conrado Gouvea d0c969d40a
rename keys::{Secret, Public} (#106)
* rename keys::{Secret, Public} to SecretShareValue, PublicVerificationShare

* Add SharedSecret; rename types to SigningShare, VerifyingShare

* Tidy rustdoc

* round2 rustdoc

* Happy rustdoc

* Remove commented out random() associated function for SigningShare

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-09-15 16:15:53 +00:00
dependabot[bot] 6de0e09b87 Update criterion requirement from 0.3 to 0.4
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version.
- [Release notes](https://github.com/bheisler/criterion.rs/releases)
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bheisler/criterion.rs/compare/0.3.0...0.4.0)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-12 17:25:48 -04:00
dependabot[bot] 66ad23278b
Bump reviewdog/action-actionlint from 1.27.0 to 1.29.0 (#122)
Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.27.0 to 1.29.0.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](https://github.com/reviewdog/action-actionlint/compare/v1.27.0...v1.29.0)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-05 22:15:47 +00:00
Conrado Gouvea 1ccee574ce
Remove PartialEq bounds (#107)
* make tests generic

* restore serialization test; remove Debug bound by using debugless-unwrap

* fix spacings in Cargo.toml

* Add PartialEq bound to Ciphersuite and Group; remove it from functions

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-09-05 16:54:58 -04:00
Conrado Gouvea 298da8f5fd
Make tests generic (#105)
* make tests generic

* restore serialization test; remove Debug bound by using debugless-unwrap

* fix spacings in Cargo.toml
2022-09-05 16:34:28 -04:00
Conrado Gouvea d1ddf72136
Make verification per-ciphersuite (#103)
* add VerifySignature method to Ciphersuite with default implementation

* VerifySignature -> verify_signature; fix comment

* add comment to verify_signature about batch verification

* fix batch support after rebase

* derive Eq when possible and disable clippy::derive_partial_eq_without_eq which is emitting false positives

* Make verify_prehashed() an associated method of the generic VerifyingKey

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-09-02 22:26:41 -04:00
Conrado Gouvea 86e1218fa9
use Identifier instead of index (#96)
* use Identifier instead of index

* remove pub(crate) from the Identifier index

* A comment

* Whitespace for readability

* check for zero in Identifier::to_scalar()

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-09-01 17:07:50 -03:00
dependabot[bot] 789551186a Bump reviewdog/action-actionlint from 1.26.0 to 1.27.0
Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](https://github.com/reviewdog/action-actionlint/compare/v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-08-04 18:58:50 -04:00
Deirdre Connolly 866fdefb20
CI: Clippy, linting, check rustdoc, etc (#104)
* Clippy, linting, check rustdoc, etc

* Ignore frost-redjubjub in the workspace for now

* Make rustfmt happy

* Clippy

* Appease Clippy

* Comment out bench for now
2022-08-03 23:04:37 -04:00
Deirdre Connolly c551cd56eb
Support naive batch verification (#73)
* Support naive batch verification

* Generic batch verification compiles, but the batch verify test in core fails 😭

* The 'z' in old impl is now 'blind', as we call the response 'z' in our signatures

Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>

* Do the last scalar mul by the Ciphersuite::Group::cofactor() with the check

* Make VerifyingKey::verify_prehashed() pub(crate)

Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
2022-08-02 10:50:13 -03:00
Conrado Gouvea 2e8509837c
Fix clippy lints (#88)
fix clippy lints
2022-08-02 01:46:11 +00:00
dependabot[bot] e8bb1c2d64 Update digest requirement from 0.9 to 0.10
Updates the requirements on [digest](https://github.com/RustCrypto/traits) to permit the latest version.
- [Release notes](https://github.com/RustCrypto/traits/releases)
- [Commits](https://github.com/RustCrypto/traits/compare/digest-v0.9.0...digest-v0.10.0)

---
updated-dependencies:
- dependency-name: digest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-26 20:27:06 -04:00
Deirdre Connolly 4cb11ec393
V5 (#89)
* add commit(), use it instead of preprocess()

* use a single scalarmul in compute_group_commitment per v5 spec

* add nonce_generate() from the spec and use it

* remove Order() from Group trait since it's not used

* style: carriage return

* use Secret instead of KeyPackage in some methods

* change commit to take explicit params and not return vectors

* removed unused import

Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
2022-07-19 20:17:20 +00:00
Conrado Gouvea af2839f6dc
Add P-256 support (#77)
* add support for P-256 curve

* use a fixed-size array for P_256 point encoding (instead of )

* Apply suggestions from code review

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>

* frost-p256: remove direct elliptic_curve dependency; use the one from p256

* fix comment in invert()

* frost-p256: rename shorthand alias

* Apply suggestions from code review

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>

* improve imports, docs, use expect instead of unwrap

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
2022-07-01 14:16:22 +00:00
Conrado Gouvea e1f466902c
Fix for P-256 support due to identity encoding; other improvements (#76)
* Remove AsMut bound which is not needed

* Use the generator point to get the encoded point size, since the identity in P-256 is just a single byte

* Remove FromHex bound

* Remove Default bound from Group
2022-06-27 21:47:27 +00:00
Deirdre Connolly a0bf3c57f2
Port frost-ristretto255 to frost-core (#57)
* Start port to frost-core

* Fix Signature from_bytes, frost-ristretto255 README / src/lib.rs doc test

* Move frost-ristretto255 test vector tests to that crate

* Uncomment proptest checks to exercise signature and verifying key (de)serialization

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-06-17 14:54:54 -04:00
Deirdre Connolly 1d5740f8ec ci(Mergify): configuration update
Signed-off-by: Deirdre Connolly <null>
2022-06-15 20:13:45 -04:00
Deirdre Connolly e6d5afdfb2
Merge pull request #50 from ZcashFoundation/frost-core
* frost-core Cargo.toml

* Ciphersuite trait

* Signature trait

* Copy stub ristretto impl for now

* First stab at making signing and verifying generic over frost-core::Ciphersuite

* Update signing

* Nice const generics and stuff for frost-core::Ciphersuite

* Have to implement traits for the pre-parameterized types inside the module

* Ciphersuite::Group::Field

* Make frost/keys generic over Ciphersuite

* frost-core genericization mostly done, modulo batch

* Move tests around

* Remove internal test module

* Lots of tidies, including type refinement of Scalar, Challenge

* More genericization and tidy'ing

* Test vectors working against Ristretto impl in the frost-core integration tests

* clippy fix

* Fix generic params for full frost example integration test using ristretto

* Genericize proptests

* clippy --fix

* Doc comment identifier module

* In-flight batch and multiscalar mul

* Stop using Scalar::from_hash() as it expects impl Digest which sha2 0.10+ isn't doing anymore

* run cargo udeps

* Update frost-core/src/frost/round1.rs

* Update frost-core/src/frost.rs

* Update frost-core/src/frost/keys.rs
2022-05-16 16:53:17 -04:00
dependabot[bot] 2c86646e80 Bump codecov/codecov-action from 2.1.0 to 3
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.1.0 to 3.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v2.1.0...v3)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-08 17:21:43 -04:00
Deirdre Connolly 4677f353dc
Add README.md for frost-core and update for root of repo (#52)
* Add README.md for frost-core and update for root of repo

* More FROST context adapted from the spec intro
2022-04-08 09:02:49 -06:00
Deirdre Connolly f5773819da
V04 compat (#49)
* Enforce nonces cannot be generated or represented if zero

* rustdoc

* rustdoc

* Remove the unused and deprecated Commitment type
2022-04-05 11:10:59 -06:00
Deirdre Connolly c5ad38ff9d Update test vectors 2022-03-28 15:46:48 -04:00
Deirdre Connolly 7aff3b763f Make sure threshold, num signer mins are checked 2022-03-28 15:46:48 -04:00
Deirdre Connolly 506edbbe7b Do not generate commitment share as part of signing
Generate the group commitment from all round one signing commitments as part
of aggregate(). Only re-derive a commitment share from the signing share
as part of signing share verification, just before aggregate.
2022-03-28 15:46:48 -04:00
Deirdre Connolly fcd4599ec5 Some docs 2022-03-28 15:46:48 -04:00
Deirdre Connolly f757b761c6 Rename generate_ to derive_lagrange_coeff 2022-03-28 15:46:48 -04:00
Deirdre Connolly f15657b516 Reject signer or signing commitment indices that == 0 2022-03-28 15:46:48 -04:00
Deirdre Connolly f9e5f5a110 Run coverage on main to diff against base 2022-03-28 15:14:48 -04:00
Deirdre Connolly 11973761b6
Refactor frost into round1, round2 submodules (#38)
* Refactor frost into round1, round2 submodules

* Move around some stuff into frost.rs
2022-03-22 16:33:59 -04:00
Deirdre Connolly c88b5ffe1b Rename ShareCommitment VerifiableSecretSharingCommitment 2022-03-08 14:11:41 -05:00
Deirdre Connolly 0b1b7eecd5 Move keygen, key types, into frost::keys 2022-03-08 14:11:41 -05:00
Deirdre Connolly ac79d00c76 Ignore .DS_Store 2022-03-08 14:11:41 -05:00
dependabot[bot] 4d2baf07ac Bump actions/checkout from 2.4.0 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2.4.0...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-03 15:52:45 -05:00
Deirdre Connolly b7b6aa7907 Ensure we compute each signature share's R_share from signers' round 1 nonce commitments 2022-03-03 12:55:45 -05:00
Deirdre Connolly 48f084816b Remove commented out FromHex impl for SignatureResponse 2022-03-03 12:55:45 -05:00
Deirdre Connolly a41c02581d We no longer H3(msg) to create the challange, only to create the binding_factor 2022-03-03 12:55:45 -05:00
Deirdre Connolly bf8b138595 Small fixes, trying to get test vector sig share verification working 2022-03-03 12:55:45 -05:00
Deirdre Connolly 15706f0b48 Remove comments 2022-03-03 12:55:45 -05:00
Deirdre Connolly 77bb412c7a A bunch of fixes 2022-03-03 12:55:45 -05:00
Deirdre Connolly 5f35150088 Almost all parse, being partially checked in test 2022-03-03 12:55:45 -05:00
Deirdre Connolly c59d36d508 Turn several functions into type methods, impl FromHex for some for test vectors 2022-03-03 12:55:45 -05:00