zecfoundation
/
redjubjub
mirror of https://github.com/ZcashFoundation/redjubjub.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add comments to the checks

This commit is contained in:
Marek 2021-03-18 16:30:25 +00:00 committed by Deirdre Connolly
parent 3e28bf6c07
commit 6481d0af91
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/frost.rs
View File

@ -342,6 +342,8 @@ impl SigningNonces {
}
}
// The values of 'hiding' and 'biding' must be non-zero so that commitments are not the
// identity.
let hiding = Scalar::from_bytes_wide(&random_nonzero_bytes(rng));
let binding = Scalar::from_bytes_wide(&random_nonzero_bytes(rng));
@ -481,9 +483,11 @@ fn gen_group_commitment(
let mut accumulator = identity;
for commitment in signing_package.signing_commitments.iter() {
if identity == commitment.binding && identity == commitment.hiding {
return Err("Commitment equals the identity.");
}
// The following check prevents a party from accidentally revealing their share.
// Note that the '&&' operator would be sufficient.
if identity == commitment.binding || identity == commitment.hiding {
return Err("Commitment equals the identity.");
}
let rho_i = bindings
.get(&commitment.index)