zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

wallet: Batch-validate all Orchard signatures in the wallet on load 

A batch item is 128 bytes, so for a wallet with 200k Orchard actions
this would require around 25MiB, which is reasonable.
This commit is contained in:
Jack Grigg 2021-09-22 14:01:53 +01:00
parent f9a1986e43
commit 092ffed2cc
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/wallet/walletdb.cpp
View File

@ -298,8 +298,9 @@ public:
bool fAnyUnordered;
int nFileVersion;
vector<uint256> vWalletUpgrade;
orchard::AuthValidator orchardAuth;
CWalletScanState() {
CWalletScanState(): orchardAuth(orchard::AuthValidator::Batch()) {
nKeys = nCKeys = nKeyMeta = nZKeys = nCZKeys = nZKeyMeta = nSapZAddrs = 0;
fIsEncrypted = false;
fAnyUnordered = false;
@ -338,11 +339,9 @@ ReadKeyValue(CWallet* pwallet, CDataStream& ssKey, CDataStream& ssValue,
ssValue >> wtx;
CValidationState state;
auto verifier = ProofVerifier::Strict();
auto orchardAuth = orchard::AuthValidator::Batch();
if (!(
CheckTransaction(wtx, state, verifier, orchardAuth) &&
CheckTransaction(wtx, state, verifier, wss.orchardAuth) &&
(wtx.GetHash() == hash) &&
orchardAuth.Validate() &&
state.IsValid())
) {
return false;
@ -802,6 +801,12 @@ DBErrors CWalletDB::LoadWallet(CWallet* pwallet)
LogPrintf("%s\n", strErr);
}
pcursor->close();
// Run the Orchard batch validator; if it fails, treat it like a bad transaction record.
if (!wss.orchardAuth.Validate()) {
fNoncriticalErrors = true;
SoftSetBoolArg("-rescan", true);
}
}
catch (const boost::thread_interrupted&) {
throw;