From 0cab2e70940ed4c39ab46b6a58b64cd8faf56a5e Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Sun, 14 Mar 2021 12:00:37 +1300 Subject: [PATCH] metrics: Remove zcash.sync.* metrics - zcash.sync.block.downloaded.total is redundant, and can be replaced by zcash.net.in.messages[command=block]. - zcash.sync.block.verified.total and zcash.chain.verified.block.total are identical for us, because we verify blocks synchronously. --- src/main.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index a9bea3f58..a8d0d360c 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -6287,7 +6287,6 @@ bool static ProcessMessage(const CChainParams& chainparams, CNode* pfrom, string CInv inv(MSG_BLOCK, block.GetHash()); LogPrint("net", "received block %s peer=%d\n", inv.hash.ToString(), pfrom->id); - MetricsIncrementCounter("zcash.sync.block.downloaded.total"); pfrom->AddInventoryKnown(inv); @@ -6306,8 +6305,6 @@ bool static ProcessMessage(const CChainParams& chainparams, CNode* pfrom, string LOCK(cs_main); Misbehaving(pfrom->GetId(), nDoS); } - } else if (state.IsValid()) { - MetricsIncrementCounter("zcash.sync.block.verified.total"); } }