Apply suggestions from code review

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
Greg Pfeil 2022-10-26 09:07:58 -06:00 committed by GitHub
parent 8e333b3f49
commit 1296b646b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions

View File

@ -28,9 +28,10 @@ Check that dependencies are up-to-date or have been postponed:
$ ./qa/zcash/updatecheck.py
```
You can optionally create an `$XDG_DATA_HOME/zcash/updatecheck/token` file to
avoid running into GitHub rate limiting. Create an unprivileged personal access
token on GitHub and copy the value into the file.
You can optionally create a file `~/.local/share/zcash/updatecheck/token` (or
`$XDG_DATA_HOME/zcash/updatecheck/token` if the `XDG_DATA_HOME` environment
variable is set) to avoid running into GitHub rate limiting. Create an
unprivileged personal access token on GitHub and copy the value into the file.
If there are updates that have not been postponed, review their changelogs
for urgent security fixes, and if there aren't any, postpone the update by

View File

@ -203,7 +203,7 @@ class GithubTagReleaseLister:
def all_tag_names(self):
url = "https://api.github.com/repos/" + safe(self.org) + "/" + safe(self.repo) + "/git/refs/tags"
auth = ()
auth = {}
if token:
auth = { 'Authorization': 'Bearer ' + token }
r = requests.get(url, headers=auth)