Style improvements in RPC tests.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
parent
c1cd8a7e2d
commit
1cd92e579c
|
@ -44,8 +44,7 @@ class WalletAccountsTest(BitcoinTestFramework):
|
|||
assert_equal(actual['minimum_confirmations'], minconf)
|
||||
return total_balance
|
||||
|
||||
def check_balance(self, node, account, address, expected, minconf=None):
|
||||
minconf = 1 if minconf is None else minconf
|
||||
def check_balance(self, node, account, address, expected, minconf=1):
|
||||
acct_balance = self._check_balance_for_rpc('z_getbalanceforaccount', node, account, expected, minconf)
|
||||
z_getbalance = self.nodes[node].z_getbalance(address, minconf)
|
||||
assert_equal(acct_balance, z_getbalance)
|
||||
|
|
|
@ -37,7 +37,7 @@ class WalletShieldCoinbaseUANU5(WalletShieldCoinbaseTest):
|
|||
)
|
||||
|
||||
total_balance = node.z_getbalance(self.addr) * COIN
|
||||
assert(total_balance == sapling_balance)
|
||||
assert_equal(total_balance, sapling_balance)
|
||||
|
||||
if __name__ == '__main__':
|
||||
print("Test shielding to a unified address with NU5 activated")
|
||||
|
|
|
@ -35,7 +35,7 @@ class WalletShieldCoinbaseUASapling(WalletShieldCoinbaseTest):
|
|||
)
|
||||
|
||||
total_balance = node.z_getbalance(self.addr) * COIN
|
||||
assert(total_balance == sapling_balance)
|
||||
assert_equal(total_balance, sapling_balance)
|
||||
|
||||
if __name__ == '__main__':
|
||||
print("Test shielding to a unified address with sapling activated (but not NU5)")
|
||||
|
|
|
@ -36,8 +36,7 @@ class WalletZSendmanyTest(BitcoinTestFramework):
|
|||
assert_equal(actual['minimum_confirmations'], minconf)
|
||||
return total_balance
|
||||
|
||||
def check_balance(self, node, account, address, expected, minconf=None):
|
||||
minconf = 1 if minconf is None else minconf
|
||||
def check_balance(self, node, account, address, expected, minconf=1):
|
||||
acct_balance = self._check_balance_for_rpc('z_getbalanceforaccount', node, account, expected, minconf)
|
||||
z_getbalance = self.nodes[node].z_getbalance(address, minconf)
|
||||
assert_equal(acct_balance, z_getbalance)
|
||||
|
|
Loading…
Reference in New Issue