From 2be143a20b99b1b1fb62cd8711d3f4b8883cc979 Mon Sep 17 00:00:00 2001 From: furszy Date: Fri, 13 Nov 2020 10:56:39 -0300 Subject: [PATCH] sendmany::find_unspent_notes removing an unneeded recursive lock, GetFilteredNotes is already locking cs_main and cs_wallet. --- src/wallet/asyncrpcoperation_sendmany.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/wallet/asyncrpcoperation_sendmany.cpp b/src/wallet/asyncrpcoperation_sendmany.cpp index 17eccb2d4..bb9f4e0ff 100644 --- a/src/wallet/asyncrpcoperation_sendmany.cpp +++ b/src/wallet/asyncrpcoperation_sendmany.cpp @@ -920,10 +920,7 @@ bool AsyncRPCOperation_sendmany::load_inputs(TxValues& txValues) { bool AsyncRPCOperation_sendmany::find_unspent_notes() { std::vector sproutEntries; std::vector saplingEntries; - { - LOCK2(cs_main, pwalletMain->cs_wallet); - pwalletMain->GetFilteredNotes(sproutEntries, saplingEntries, fromaddress_, mindepth_); - } + pwalletMain->GetFilteredNotes(sproutEntries, saplingEntries, fromaddress_, mindepth_); // If using the TransactionBuilder, we only want Sapling notes. // If not using it, we only want Sprout notes.