From 37b4faab6a30a88b2b58a206db9a2b5e2983f522 Mon Sep 17 00:00:00 2001
From: Kris Nuttycombe <kris.nuttycombe@gmail.com>
Date: Tue, 7 Jul 2020 09:41:32 -0600
Subject: [PATCH] Pass by const reference where possible.

Co-authored-by: Larry Ruane <larry@z.cash>
---
 src/consensus/params.cpp | 4 ++--
 src/consensus/params.h   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/consensus/params.cpp b/src/consensus/params.cpp
index d4a4adf2d..4ff3eeb76 100644
--- a/src/consensus/params.cpp
+++ b/src/consensus/params.cpp
@@ -142,7 +142,7 @@ namespace Consensus {
         const Consensus::Params& params,
         const int startHeight,
         const int endHeight,
-        const std::vector<std::string> strAddresses)
+        const std::vector<std::string>& strAddresses)
     {
         // Parse the address strings into concrete types.
         std::vector<FundingStreamAddress> addresses;
@@ -167,7 +167,7 @@ namespace Consensus {
         FundingStreamIndex idx,
         int startHeight,
         int endHeight,
-        const std::vector<std::string> strAddresses)
+        const std::vector<std::string>& strAddresses)
     {
         vFundingStreams[idx] = FundingStream::ParseFundingStream(*this, startHeight, endHeight, strAddresses);
     };
diff --git a/src/consensus/params.h b/src/consensus/params.h
index f7348818d..959c7f190 100644
--- a/src/consensus/params.h
+++ b/src/consensus/params.h
@@ -108,7 +108,7 @@ private:
     int endHeight;
     std::vector<FundingStreamAddress> addresses;
 
-    FundingStream(int startHeight, int endHeight, std::vector<FundingStreamAddress> addresses):
+    FundingStream(int startHeight, int endHeight, const std::vector<FundingStreamAddress>& addresses):
         startHeight(startHeight), endHeight(endHeight), addresses(addresses) { }
 public:
     FundingStream(const FundingStream& fs):
@@ -125,7 +125,7 @@ public:
         const Consensus::Params& params,
         const int startHeight,
         const int endHeight,
-        const std::vector<std::string> strAddresses);
+        const std::vector<std::string>& strAddresses);
 
     int GetStartHeight() const { return startHeight; };
     int GetEndHeight() const { return endHeight; };
@@ -212,7 +212,7 @@ struct Params {
         FundingStreamIndex idx,
         int startHeight,
         int endHeight,
-        const std::vector<std::string> addresses);
+        const std::vector<std::string>& addresses);
 
     /**
      * Default block height at which the future timestamp soft fork rule activates.