From 5514542a0a8e1ad62637fd4d502bfd1cce1ae69a Mon Sep 17 00:00:00 2001 From: Greg Pfeil Date: Fri, 23 Sep 2022 18:39:00 -0600 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Daira Hopwood --- qa/rpc-tests/finalorchardroot.py | 1 - src/rpc/blockchain.cpp | 6 ++++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/qa/rpc-tests/finalorchardroot.py b/qa/rpc-tests/finalorchardroot.py index fcc110bb2..3ec7b8ded 100755 --- a/qa/rpc-tests/finalorchardroot.py +++ b/qa/rpc-tests/finalorchardroot.py @@ -277,7 +277,6 @@ class FinalOrchardRootTest(BitcoinTestFramework): assert_equal(len(new_treestate["orchard"]["commitments"]["finalRoot"]), 64) assert_equal(len(new_treestate["orchard"]["commitments"]["finalState"]), 260) - pass if __name__ == '__main__': diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp index f9646de4c..a929d1c19 100644 --- a/src/rpc/blockchain.cpp +++ b/src/rpc/blockchain.cpp @@ -723,7 +723,8 @@ UniValue getblock(const UniValue& params, bool fHelp) " main chain.\n" " NB: The serialized representation of this field returned by this method\n" " was byte-flipped relative to its representation in the `getrawtransaction`\n" - " output in prior releases up to v5.2.0. This has now been rectified.\n" + " output in prior releases up to and including v5.2.0. This has now been\n" + " rectified.\n" " \"tx\" : [ (array of string) The transaction ids\n" " \"transactionid\" (string) The transaction id\n" " ,...\n" @@ -1254,7 +1255,8 @@ UniValue z_gettreestate(const UniValue& params, bool fHelp) " \"finalRoot\": \"hex\", (string)\n" " NB: The serialized representation of this field returned by this method\n" " was byte-flipped relative to its representation in the `getrawtransaction`\n" - " output in prior releases up to v5.2.0. This has now been rectified.\n" + " output in prior releases up to and including v5.2.0. This has now been\n" + " rectified.\n" " \"finalState\": \"hex\" (string)\n" " }\n" " },\n"